public inbox for [email protected]  

help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal
Date: Mon, 18 Apr 2022 12:46:57 +0530
Message-ID: <CANxoLDe8KU-gnow=cY1Esbh-ZzGj0LFSDRLW2+cbmqJW_UU57A@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELerJ5RNAmO+UL2dj=yFx6b-hh7nc3vOJFG-S+KDcKK+XA@mail.gmail.com>
References: <CAFOhELerJ5RNAmO+UL2dj=yFx6b-hh7nc3vOJFG-S+KDcKK+XA@mail.gmail.com>

Hi Khushboo

Following are the review comments:
*GUI:*

   - Facing error in the browser. Please check the below screenshot

             [image: 2nd Page.png]

   - Unable to test ahead because 'Regions' are not available to select in
   the dropdown. Even the code has been verified successfully

                  [image: Code.png].        [image: Region_Error.png]


*Code:*

   - Jasmine test cases are missing.
   - Documentation is missing.
   - Function comments are not present in the new files. Overall very less
   comments about the code. Add comments in rds.py and io.py
   - Access token gets printed at the backend, it should not or at
   least should be in the Debug log.
   - Move BASE_URL = 'https://portal.biganimal.com/api/v1'; to constants.py
   and remove it from the multiple files.
   - Fixed SonarQube issues from the new files and from existing files if
   introduced with this patch or previous patch for AWS RDS.
   - Update line "help='Amazon AWS RDS PostgreSQL'" in BigAnimal.py.
   -

   sid = _create_server({
       'gid': data['db_details']['gid'],
       'name': data['instance_details']['cluster_name'],
       'db': 'edb_admin',
       'username': 'edb_admin',
       'port': 5432,
       'cloud_status': -1
   }).  Update Why db, username and port are hard coded?

   -

   In "misc/cloud/__init__.py" two function with same name "def
get_db_versions()"

   -

   Correct the string "edb_bibanimal_authentication" to
"edb_biganimal_authentication" in CloudWizard.jsx and 'VigAnimal
Volume Types" to "BigAnimal Volume Types".



On Thu, Apr 14, 2022 at 2:04 PM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached patch for the implementation of the RM #7179 - PostgreSQL
> deployment on EDB BigAnimal.
>
> Thanks,
> Khushboo
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


Attachments:

  [image/png] 2nd Page.png (522.6K, 3-2nd%20Page.png)
  download | view image

  [image/png] Code.png (55.9K, 4-Code.png)
  download | view image

  [image/png] Region_Error.png (214.0K, 5-Region_Error.png)
  download | view image

view thread (7+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] - RM #7179 - PostgreSQL deployment on EDB BigAnimal
  In-Reply-To: <CANxoLDe8KU-gnow=cY1Esbh-ZzGj0LFSDRLW2+cbmqJW_UU57A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox