MIME-Version: 1.0
References: 
 <436f7edcc84e463fac5ed65866dc5ee3@G08CNEXMBPEKD06.g08.fujitsu.local>
In-Reply-To: 
 <436f7edcc84e463fac5ed65866dc5ee3@G08CNEXMBPEKD06.g08.fujitsu.local>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 18 Jan 2021 16:40:58 +0530
Message-ID: 
 <CANxoLDe9ZB-GxyW6z7AoTnGwn=BvjXSaNPFFuZucOCc_1dzFVA@mail.gmail.com>
Subject: Re: There is an error when checking the major version of servers in
 schema diff
To: "Huang, Jun" <huangj.fnst@cn.fujitsu.com>
Cc: "pgadmin-hackers@postgresql.org" <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000072421305b92ac73a"
Precedence: bulk

--00000000000072421305b92ac73a
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Sun, Jan 17, 2021 at 6:28 PM Huang, Jun <huangj.fnst@cn.fujitsu.com>
wrote:

> Hi,
>
> The function get_round_val() outputs the wrong value when major version is
> before 10.
> For example,
>    Source server version: 90500
>    Target server version: 90502
> Or
>    Source server version: 90502
>    Target server version: 90602
>
> The attached patch shows the changes.
> --
> Thanks && regards
> HuangJ
>
>
>
>

-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--00000000000072421305b92ac73a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.<br></div><br><div class=3D"gmail_qu=
ote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Jan 17, 2021 at 6:28 PM =
Huang, Jun &lt;<a href=3D"mailto:huangj.fnst@cn.fujitsu.com">huangj.fnst@cn=
.fujitsu.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">Hi,<br>
<br>
The function get_round_val() outputs the wrong value when major version is =
before 10.<br>
For example,<br>
=C2=A0 =C2=A0Source server version: 90500<br>
=C2=A0 =C2=A0Target server version: 90502<br>
Or<br>
=C2=A0 =C2=A0Source server version: 90502<br>
=C2=A0 =C2=A0Target server version: 90602<br>
<br>
The attached patch shows the changes.<br>
--<br>
Thanks &amp;&amp; regards<br>
HuangJ<br>
<br>
<br>
<br>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--00000000000072421305b92ac73a--