public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters.
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters.
@ 2020-11-26 08:13  Nikhil Mohite <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Nikhil Mohite @ 2020-11-26 08:13 UTC (permalink / raw)
  To: pgadmin-hackers

Hi Team,

Please find the patch for RM-5992
<https://redmine.postgresql.org/issues/5992;: Escape character shown when
server/database name has some special characters.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*


Attachments:

  [application/octet-stream] RM_5992.patch (3.0K, 3-RM_5992.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js b/web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js
index 258e83d..721b583 100644
--- a/web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js
+++ b/web/pgadmin/tools/datagrid/static/js/datagrid_panel_title.js
@@ -74,20 +74,20 @@ export function setQueryToolDockerTitle(panel, is_query_tool, panel_title, is_fi
 export function generateTitle(title_placeholder, title_data) {
 
   if(title_data.type == 'query_tool') {
-    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), title_data.database);
-    title_placeholder = title_placeholder.replace(new RegExp('%USERNAME%'), title_data.username);
-    title_placeholder = title_placeholder.replace(new RegExp('%SERVER%'), title_data.server);
+    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), _.unescape(title_data.database));
+    title_placeholder = title_placeholder.replace(new RegExp('%USERNAME%'), _.unescape(title_data.username));
+    title_placeholder = title_placeholder.replace(new RegExp('%SERVER%'), _.unescape(title_data.server));
   } else if(title_data.type == 'datagrid') {
-    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), title_data.database);
-    title_placeholder = title_placeholder.replace(new RegExp('%USERNAME%'), title_data.username);
-    title_placeholder = title_placeholder.replace(new RegExp('%SERVER%'), title_data.server);
-    title_placeholder = title_placeholder.replace(new RegExp('%SCHEMA%'), title_data.schema);
-    title_placeholder = title_placeholder.replace(new RegExp('%TABLE%'), title_data.table);
+    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), _.unescape(title_data.database));
+    title_placeholder = title_placeholder.replace(new RegExp('%USERNAME%'), _.unescape(title_data.username));
+    title_placeholder = title_placeholder.replace(new RegExp('%SERVER%'), _.unescape(title_data.server));
+    title_placeholder = title_placeholder.replace(new RegExp('%SCHEMA%'), _.unescape(title_data.schema));
+    title_placeholder = title_placeholder.replace(new RegExp('%TABLE%'), _.unescape(title_data.table));
   } else if(title_data.type == 'debugger') {
-    title_placeholder = title_placeholder.replace(new RegExp('%FUNCTION%'), title_data.function_name);
-    title_placeholder = title_placeholder.replace(new RegExp('%ARGS%'), title_data.args);
-    title_placeholder = title_placeholder.replace(new RegExp('%SCHEMA%'), title_data.schema);
-    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), title_data.database);
+    title_placeholder = title_placeholder.replace(new RegExp('%FUNCTION%'), _.unescape(title_data.function_name));
+    title_placeholder = title_placeholder.replace(new RegExp('%ARGS%'), _.unescape(title_data.args));
+    title_placeholder = title_placeholder.replace(new RegExp('%SCHEMA%'), _.unescape(title_data.schema));
+    title_placeholder = title_placeholder.replace(new RegExp('%DATABASE%'), _.unescape(title_data.database));
   }
 
   return _.escape(title_placeholder);


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters.
@ 2020-12-01 06:08  Akshay Joshi <[email protected]>
  parent: Nikhil Mohite <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2020-12-01 06:08 UTC (permalink / raw)
  To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers

Thanks, patch applied.

On Thu, Nov 26, 2020 at 1:43 PM Nikhil Mohite <
[email protected]> wrote:

> Hi Team,
>
> Please find the patch for RM-5992
> <https://redmine.postgresql.org/issues/5992;: Escape character shown when
> server/database name has some special characters.
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*


^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2020-12-01 06:08 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 08:13 [pgAdmin][RM-5992]: Escape character shown when server/database name has some special characters. Nikhil Mohite <[email protected]>
2020-12-01 06:08 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox