Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9Qpa-0004eK-55 for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:05:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9QpZ-0007mG-3a for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Feb 2021 11:05:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9QpY-0007m9-TN for pgadmin-hackers@lists.postgresql.org; Tue, 09 Feb 2021 11:05:16 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9QpR-0006Hu-1k for pgadmin-hackers@postgresql.org; Tue, 09 Feb 2021 11:05:16 +0000 Received: by mail-il1-x132.google.com with SMTP id o7so11165307ils.2 for ; Tue, 09 Feb 2021 03:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EJKnljivP6OiTOAxk3fOHJurLtB9OmG3Co3U3l3fubU=; b=KhpFgwPrSgHl2wAl0N04F5j2RfOqIAqYHB+aDhi3x/nFuQUqlfGQ4i0zDo18JzzyPg +FNej60i2WGBA6wvIXew8+6AhpuD3sGzaUB0O8gPToqbsTbOZprIEIpeFRhm6OeCljsr f9D185SbR6Bh/Uw4vyTyHUVzFrbtGoY4G0baMm1JU7kMG40OsGWAujHZsZcvVqlX5eho 2Keb3OjvDq+BuMuOID6x6RgV4T8OYqkJCxg4hToaFxNrpydvI4a8/Sp33mGW5DyslFoy /iXziLOcU+W5hGweOyq1G9gxNJAuYMEq96rLyYlHFjJ2dGj9WNeWxU2Y0oTN7rlAUhd+ ByHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EJKnljivP6OiTOAxk3fOHJurLtB9OmG3Co3U3l3fubU=; b=gS3d2elSNcFS08qX7qNcj9IL/Dm6ALmrkzReFSK934dexWwcER7znGDh7C0++/wFtN b3YsJ/BhMK8nQ8bLKv7HdbaOIA1csjFU8ooZh97a6EH+0MpTweo8bct/bZx7JP1fratP aO64MFtKhBbZ3Wg88pLa9lrQicYgYlIDTRcfvJLVz9Ozq/PG3Nts2yPS88XVe9dK09pM RQ88mPTcRiXh1JaCDPiD+yyhQW01IPt6J69WTldAZ3mGY1zJ5D0oyqRamFkBKutR4YhS 4krH2+q5zoACENHYrVq/hijSQnuxp/YNcQmy6UXsJsC+xbaJdFM2oQH4zGl3DyN+8vCV 8gGQ== X-Gm-Message-State: AOAM530PhR2Epe2iAIWgbBS2b+x6YgJDOZ84f8LQRlyquWfM5yMVtuBU mvk3HDZbxrdHurXLqguTfvw7CF1bKBespnKEzGHZrnuTSTVtjqn7PVtqSleCBbMDMBzu+wEHSBC RMh5xjsWnJxJpkzxEBUUJAzwOZ9osl11zGKdVQC0ke35OUlBFnLgu39/XGiBd45Tb818D0eWZV4 9io70pNpsD0LP6NwFjj4do4dNmkijYigdDf7fN88tQlHZcjbBvVdD7Rbecd+IwsXg= X-Google-Smtp-Source: ABdhPJwuxv+iSUuL/bBCpfZX48qEB/2BHo5pvSUF3VjK/V1unKc2lrFFWFJRpCbK80zwsEj160SOiS/TgBPlsP/1OhM= X-Received: by 2002:a92:cd81:: with SMTP id r1mr19211968ilb.252.1612868707085; Tue, 09 Feb 2021 03:05:07 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 9 Feb 2021 16:34:56 +0530 Message-ID: Subject: Re: [pgAdmin][RM6207] Update JS dependencies To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000005b0d9305bae54265" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000005b0d9305bae54265 Content-Type: text/plain; charset="UTF-8" Hi Aditya One jasmine test is failing, please fix that and resend the patch. On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to update the JS dependencies to latest. Changes > include: > 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking > changes, so updated multiple webpack plugins and changed the config > accordingly. > 2) Replaced iconfont-webpack-plugin with a more maintained > webfonts-loader. > 3) Replaced deprecated babel-eslint with @babel/eslint-parser > 4) Replaced optimize-css-assets-webpack-plugin with a more maintained > css-minimizer-webpack-plugin > 5) Updated all other JS packages and made the required code changes. > > Note, there is an update available for slickgrid and I tried to update it. > But it was not working as expected. So without wasting time, I've not > updated slickgrid, and can be updated as a separate task. > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000005b0d9305bae54265 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

One jasmine test is fail= ing, please fix that and resend the patch.

On Mon, Feb 8, 2021 at 5:07= PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to update the JS depend= encies to latest. Changes include:
1) Migrate from webpack 4 to webpack = 5. This had a lot of breaking changes, so updated multiple webpack plugins = and changed the config accordingly.
2) Replaced iconfont-webpack-plugin = with a more maintained =C2=A0webfonts-loader.
3) =C2=A0Replaced depre= cated babel-eslint with @babel/eslint-parser
4) =C2=A0Replaced optimize-= css-assets-webpack-plugin with a more maintained css-minimizer-webpack-plug= in
5) Updated all other JS packages and made the required code changes.<= /font>

Note, there is an update available for slickgrid an= d I tried to update it. But it was not working as expected. So without wast= ing time, I've not updated slickgrid, and can be updated as a separate = task.

<= /div>
Please review.

--
<= div dir=3D"ltr">
Thanks,
Aditya Toshniwal
pgAdmin hacker= =C2=A0| Sr. Software Engineer | edbpost= gres.com
"Don't Complain about Heat, Plan= t a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000005b0d9305bae54265--