Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZdO7-0008En-4p for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 12:54:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cZdO6-0000WA-Dr for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Feb 2017 12:54:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cZdNs-0000Ge-Oh for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 12:54:36 +0000 Received: from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cZdNk-0007zn-6M for pgadmin-hackers@postgresql.org; Fri, 03 Feb 2017 12:54:36 +0000 Received: by mail-qt0-x22d.google.com with SMTP id w20so32841795qtb.1 for ; Fri, 03 Feb 2017 04:54:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=h69VC2FtCOLfQk/7wOr1Y9rYWfJawr6V291HNa2wJps=; b=RNCvQ4KHprof8FGBBYQvj+QhN68y6AxnaP/G+004xkmbizSJECux+TxHuGtIFUrHGt o/LnGOVzWjVEc+nvZ8lQYwvbUDTc9PHXbda3ukKI4maLOmJB1TzrxI0Y9cAR6ia0cE17 b0SZgOX77w3LP/KJrvoKdFnhmUETypJgG9UpqnVA0QvSVSgeZGZ9CETScc65gMgLBfJs gVyKQNbVzeTGWAirSIJV0q6HzL5UjBb5KHNT/7zOrbKsf1TXz93sK1r70vx3rbv+80Xi PmUWwsGoPSB16pGLqXFNCtWsqxXgLq0/94etRI5TWhwIlhtDWBg9HixEJPuw+tc5Naab x8jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=h69VC2FtCOLfQk/7wOr1Y9rYWfJawr6V291HNa2wJps=; b=IUAYdbVxf3tkjxY1jkAK0ppbkh9p2kVpXg+hoUpuf5aUF0oI072DQOjdBuQaY7KmBH +DzD9m8iyc0UwsdEiRrc5jBpLEO+ZIaI2619InPXKUiEi9hO+UhHoqQ/wH08W1lud9Su loDHdR/JKqUMcczvrCH170mKUjUalycSTCxoec6BPg06mYNfgVnQRI/GWUObJ8V/RLEN RChzJtC6v540aPrQU5uBNQOG4PjYe005bbzFJlv7z+jqPZf8vasG/rmVx9ee9rxiiEhs 2DzFu0gcPi8w8psHjSKfpFx6aXg3ykQenW2LGlRpRObbwEHDzxsQNGzEcG5L7zmAsq+6 FTtQ== X-Gm-Message-State: AMke39mAjKbx+jBKuwRYUt+iwc+n52j0LB1Uhn8DCtF+EfKJiFpHvARB4KvRwOiOREHGqR112F/IIe18/lXHLjM4 X-Received: by 10.55.112.7 with SMTP id l7mr12889297qkc.252.1486126462653; Fri, 03 Feb 2017 04:54:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.181.156 with HTTP; Fri, 3 Feb 2017 04:54:22 -0800 (PST) In-Reply-To: References: From: Akshay Joshi Date: Fri, 3 Feb 2017 18:24:22 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114fe988e6170e05479fc73c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114fe988e6170e05479fc73c Content-Type: text/plain; charset=UTF-8 Hi Dave I have reviewed the patch and after applying it output in pgAdmin4 CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry) RETURNS boolean LANGUAGE 'sql' COST 100.0 *IMMUTABLE NOT LEAKPROOF * * PARALLEL SAFE* AS $function$ SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2) $function$; but as per psql it should be CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 geometry) RETURNS boolean LANGUAGE sql *IMMUTABLE PARALLEL SAFE* AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Intersects($1,$2)$function$ is this behaviour correct?? On Fri, Feb 3, 2017 at 5:31 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix RM 2089 : PARALLEL SAFE support for > functions missing. > > Fix: Incorporated the PARALLEL SAFE support for the functions and > procedures for PostgreSQL 9.6. > > Thanks, > Khushboo > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a114fe988e6170e05479fc73c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave=C2=A0

I have reviewed the patch= and after applying it output in pgAdmin4 =C2=A0

<= div>CREATE OR REPLACE FUNCTION public.st_intersects(geom1 geometry, geom2 g= eometry)
=C2=A0 =C2=A0 RETURNS boolean
=C2=A0 =C2=A0 LANGUAGE &#= 39;sql'
=C2=A0 =C2=A0 COST 100.0
=C2=A0 =C2=A0 I= MMUTABLE NOT LEA= KPROOF=C2=A0
=C2=A0 =C2=A0 PARALLEL SAFE
<= div>AS $function$
SELECT $1 OPERATOR(public.&&) $2 AND pu= blic._ST_Intersects($1,$2)
$function$;

=
but as per = psql it should be=C2=A0

CREATE OR REPLACE = FUNCTION public.st_intersects(geom1 geometry, geom2 geometry)

=C2=A0RETURNS b= oolean

=C2=A0LANGUAGE = sql

=C2=A0IMMUTABLE PARALLEL SAFE

AS $function$SELECT $1 OPERATOR(public.&&) $2 AND public._ST_Inter= sects($1,$2)$function$


is this behaviour correct??



On Fri, Feb 3, 2017 at 5:31 PM, Khush= boo Vashi <khushboo.vashi@enterprisedb.com> wr= ote:
Hi,

<= div>Please find the attached patch to fix RM 2089 : PARALLEL SAFE support f= or functions missing.

Fix: Incorporated the =C2=A0= PARALLEL SAFE support for the functions and procedures for PostgreSQL 9.6.<= /div>

Thanks,
Khushboo



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
=
Akshay Joshi
Principal Software Engineer=C2=A0


Phone: +91 20-3058-9517
Mobile: +91 976-7= 88-8246
--001a114fe988e6170e05479fc73c--