Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKcmu-0004FQ-JV for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 Mar 2021 08:04:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lKcmt-0006QI-Hm for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 Mar 2021 08:04:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKcmt-0006Nf-CC for pgadmin-hackers@lists.postgresql.org; Fri, 12 Mar 2021 08:04:47 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lKcmr-000635-5h for pgadmin-hackers@postgresql.org; Fri, 12 Mar 2021 08:04:46 +0000 Received: by mail-il1-x133.google.com with SMTP id s1so1759387ilh.12 for ; Fri, 12 Mar 2021 00:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fpxhQ99Ncvq8L2eogathy+EJNzvitISLkDoyxsD+SqE=; b=cP8+5SUqXLeUDkM61N8Cf6zws0Tr1m0E94KX+blBZtWY1hirCMqHNBPS595JIAP8K3 NJ1ESM4Sm3NC6KEMFqOc411VDWCHykLxEAyac8Aoz6FyOa5rp1X0DYrodDkyZH2x3qqi UyetEsgZp9WAnziG2hwDw2bbiQc6GQLOCoGj6Gk9H0BGp4oWqSBr+js8M1fnCtZs/R+A 2lHlChEX/XCx1LhBb2EI5yylSoktV+v80PoAXoAgBM+A46C6EQaXwIa92nAgCy05qMVm 7JcUGnPJTu1420+zbHpWTLsRWfrePeOZojYnkdf+lE/W39u9qyTJhDlt8dVUWaIsSjF9 87eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fpxhQ99Ncvq8L2eogathy+EJNzvitISLkDoyxsD+SqE=; b=OuQYL2XXS6ozDqi95Kso5UimVOK7ylt7sy3rDRqRn1f3B1ucTRJVCZTJPSezAM/mic sP7yHoJhDBcRuGyHHjrIQxkqyqWla6qgv2vreFNOXTY5+ki1X9t8PCf4U69/z2h+MaFf EotGm+hp8ZjK5o+8LbO1JBI8mwtRmcTkm3E2JwWdLnhq3pWT3gujY4AFKAta8LN3rExv 10tBsR7ZJz47RnQ63rpAby3jqaJeZZTDy+wQwocWNK90v2Ax8p5Z9GM8U1dfEd4itU36 TkCTY4TtCynvOOlOYJPdGq0banV/EHU4Lge5t9sWaX+dKjjkSRxqNCrHOfMiz0ZdO7kX kavA== X-Gm-Message-State: AOAM533mW+IaOw/UQJJQA+zHx8i7v3mOK+icP+R+D6S7iPOlEhYZOv/k 3ScGG7jlpWCefqtv1BdOcurkYPWzM2c+/f8CM8zZkL9qwD8zwEr5SkeqFVGJ5heOsm7Vywqh2GI 2WnLwTeGfV3NnYfB3Afb5OW/J30CpcCEytwreOQgZcG8k/lpH+0QMXhyr8D3+5Sip7dtu4KQIPE 4hqOnDSSNlQUMeb6VP2pYUHS+DB0crLZqiEBxqd+kY/fhXCh68zIcOYqUJWw== X-Google-Smtp-Source: ABdhPJylbcDsDF+mgwhlnub5urRAoXMQHRcQJsd2Nmqzzq/vtPqHh+DU+mjwgj/amE6QhYwHIYuTQXnJEzJQbdRA3iA= X-Received: by 2002:a92:d58f:: with SMTP id a15mr1915237iln.257.1615536284317; Fri, 12 Mar 2021 00:04:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 12 Mar 2021 13:34:33 +0530 Message-ID: Subject: Re: [pgAdmin][RM-5404]: Show the login roles that are members of a group role be shown when examining a group role. To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000005953c705bd525a91" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000005953c705bd525a91 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Mar 10, 2021 at 5:31 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-5404 > : Show the login roles that > are members of a group role be shown when examining a group role. > Updated the existing "Role" label to "Member of" and added a new option > "Members" to show all the roles that are members of the current Role/Group. > Users can add or remove the roles from the list similar to the "Members of" > option. > > Also added 2 UI fixes: > 1. "Member of" (Roles in earlier implementation) and "Members" fields > (Membership section) should be read-only in the properties panel. > 2. If the select2 controller is set to read-only its background color is > not getting set as per the theme color. (earlier it is set to '#eee' for > all themes.) > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000005953c705bd525a91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Mar 10, 2021 at 5:31 PM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Hackers,

Plea= se find the attached patch for RM-5404:=C2=A0Show the login roles that ar= e members of a group role be shown when examining a group role.
U= pdated the existing "Role" label to "Member of" and add= ed a new option "Members" to show all the roles that are members = of the current Role/Group. Users can add or remove the roles from the list = similar to the "Members of" option.

Also= added 2 UI fixes:
1. "Member of" (Roles in earlier imp= lementation) and "Members" fields (Membership section) should be = read-only=C2=A0in the=C2=A0properties=C2=A0panel.
2. If the selec= t2 controller is set to read-only its background color is not getting set a= s per the theme color. (earlier it is set to '#eee' for all themes.= )

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000005953c705bd525a91--