Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iXh3N-00057W-Ny for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2019 07:39:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iXh3M-0006EB-AF for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2019 07:39:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iXh3L-0006E3-QD for pgadmin-hackers@lists.postgresql.org; Thu, 21 Nov 2019 07:39:00 +0000 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iXh3I-0000oL-Ur for pgadmin-hackers@postgresql.org; Thu, 21 Nov 2019 07:38:58 +0000 Received: by mail-il1-x134.google.com with SMTP id q15so2316708ils.8 for ; Wed, 20 Nov 2019 23:38:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BBR5JdrJ3CSJsuHPuS0UG5AmRRtuqxljeB3KDCOw+Ls=; b=K93U+XZiccNSqyzmSu6gq39rGUVin5T3D4Z80bEmjvF1f6CgiDwdoQYsQBL7CEyLt0 iTsCtBJCBJch2eli6WLe8EFeipLqA4EqB95J9xcfNqx6agZ7Du/QZ5zTKKLyYJ3eUAJZ YXVujH6yfNAp2JjiSHscaCZTcIky4ARiKNQGrpNDfCeu6QK5ieewkk55NqSswYYJwTBI 3rcE40TBdofthbWLQQrCvsWAlf/nkQdJFFZ1OSfy/rV/LqrFNNaVwQS3ndmJCMd6zVgm +vwli8Fc5jh1TQILN2CoSVU1PxkwYiXrVh61KF9/rKTOy02R/BdbikSQsu/bt9C8amfV p0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BBR5JdrJ3CSJsuHPuS0UG5AmRRtuqxljeB3KDCOw+Ls=; b=UWVDXUFsAX1BseimGyJkPQTi3t9jPC94CDaldGd6NqwR+YSGwOEtdcHtkpqGIZrFeT fbgz9zvpwX+l9RSr8p52jPUnxRM6hS6e8c4QLDQbCC7h/PUfSv94x+871vtTkzo+ANEX siVGQXsuEUw0XcrMULFUk8o/vHK5IXs5oQFmKOumGH3GwRLobNtmhMLrR5XLv1UFTKSM VXkzB368ZBHRZpR/hbgsNqGjpz8b6oQHKObx7g5N7+J4kfnLhF22c/ahzyDE9KEFLKw0 jlsjc2OQxK1dIyL2gZ8zi1z6cOEhsH38Fv4f3X00vWQpTlu3aHjOEcRfwWL90T2oigXV YKsA== X-Gm-Message-State: APjAAAXw78Yk30aEZcv0oedsYQUdNblUQwpI3T4MhDmOduyJRGLiRrD0 p/5G5I7DH1UQZuzRmNMOvC+jOngb3Qbzt4FW5UFw9Z1TR8r/ID+5ZErZAJnDG4F099iRMNiX0K+ X/T68YQPZJ9B/aT+CRig+ALrzNDpeeAmZ8kzdYuTN5d9IzI0414JReyQYrez6JwFtIR7RFtIvQJ t9jPW5IO0SIixDFWR+fNEsLizoGnc6/6SPywzj9OBe04tr4BKHG1Y= X-Google-Smtp-Source: APXvYqyiKXpoCjD1BfN3HugqsO0IgOkk/gzH0+agjZXPogO/weaJ+lrjpqB3twyAmZ9m0Mpe5giWZj4SNgA6fI+xPrU= X-Received: by 2002:a92:5d49:: with SMTP id r70mr8871485ilb.257.1574321935812; Wed, 20 Nov 2019 23:38:55 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 21 Nov 2019 13:08:44 +0530 Message-ID: Subject: Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000bf22330597d66361" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000bf22330597d66361 Content-Type: text/plain; charset="UTF-8" Hi Rahul Some more review comments: - Don't create new file test_view.json as I tested and committed the old code. - Remove hardcoded "oid: 17869" from JSON file. - MSQL endpoints and file name missing in some test cases. - Cover all the controls in create and alter as much as possible. On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi wrote: > Hi Rahul > > Test cases failing on all EPAS servers. Please fix and send the patch > again. > > On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < > rahul.shirsat@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have attached the patch for RE-SQL/MSQL test cases for View as well as >> Materialized View. >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000bf22330597d66361 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Rahul

Some more review comments= :
  • Don't create new file test_view.json as I tested an= d committed the old code.
  • Remove hardcoded "oid: 17869" f= rom JSON file.
  • MSQL=C2=A0endpoints and file name=C2=A0missing in so= me test cases.
  • Cover all the controls in create and alter as much a= s possible.

On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <= ;akshay.joshi@enterprisedb= .com> wrote:
Hi=C2=A0Rahul

Test cases failing on= all EPAS servers. Please fix and send the patch again.

On Tue, Nov 19= , 2019 at 12:47 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:=
Hi Hackers,

I have attached the patch for RE-SQL/MSQL= =C2=A0test cases for View as well as Materialized View.

=
--
Rahul Shirsat
Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000bf22330597d66361--