Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFH2g-000120-5e for pgadmin-hackers@arkaria.postgresql.org; Mon, 07 Sep 2020 13:18:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kFH2e-0002sy-2f for pgadmin-hackers@arkaria.postgresql.org; Mon, 07 Sep 2020 13:18:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFH2d-0002sn-MR for pgadmin-hackers@lists.postgresql.org; Mon, 07 Sep 2020 13:18:39 +0000 Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kFH2b-00024o-Ag for pgadmin-hackers@postgresql.org; Mon, 07 Sep 2020 13:18:38 +0000 Received: by mail-il1-x132.google.com with SMTP id t13so12448837ile.9 for ; Mon, 07 Sep 2020 06:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=moma3sMRrQByIyaPuKHNypRrPhLAtFrzDofsGOW1LCU=; b=gQ0cuPxyxFzIWUlQn6nmyu5YYmbF0YM1D3pzWkFVcCTDJe5zUUfnflTpFq50e1Bd+u jUSo1FABw99iMUHVrze8JFtdbCGr1pLGuv2U6/iCEbm3psyrfhaHs6xh8pBYwn5gMm28 wCsj0rVBInXtueZOrGE+5Os08M/9XLhtuZThPWz+tyCe3FvsgDI0nVPUATPHdITS0t+u 7iKiLkEJ4zCW8/E3lGVHyPLU5UU9jChEU4NNaJiajfCmtES6asL3OJSoQVoRp75PsmIx ycTMMN9MNVmz1HYos28Cw/Iw7XVPpDD/CZoIU4zRztInW4dW625aK6v+C+BvMKQCByba 4THg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=moma3sMRrQByIyaPuKHNypRrPhLAtFrzDofsGOW1LCU=; b=OAbamqyKyKLZnyEOEiy0lY6rnd73bGACVhex12JvAxC5/duFi7AFVO8EJ10KwmmHvd /Ftt0sAMP7WX3xZNfQ45NN5KU5yx3KPMha0SKXZ/+2nDhaHnoSd+0AsYk6s2F2j4K7Lv XIq5wnfNQiRWGy3wVbGZ6Id4VuzEw+Sl2kylwg+thgei5JfXkI5MUizN/a5QGONNV0mZ rnN+B148PgeXG2fwTyN7kNqBEusXMx3KO7EG0eURz1TKs3MyHWBJOtVvMMCFthCTXCXm cW3FQ/LHjds9AA3zbOvBSXFhYeXH5JHjj92aicZHzMHaXpuy2Kr4Girz9njHIKPT9LBA Citw== X-Gm-Message-State: AOAM530howvLtk0vr5cv3uLuSQjmFevxQiU8s/74S30foV5Ii9V52Sb3 W4AQK1xNusj4i8fhvP6eTFY6WwxG0JlDOSIIfBNgfQtzOXU6XZHp3d+2rl43SyxFIl9ZjXHP2zC CfXOpg1yVgL9zt78YHpJGfh8s4BvjNBIpNfPI31uuSiIJ+S8vHVV0+8+Dn87o91fqOGgiCtSpS0 4tWeO2pj0ES525VfS8YB6qeaf1vx+p9V6mcIijp4s0Xq/tdMMila4yLg21URVscAQ= X-Google-Smtp-Source: ABdhPJxhMBjRu8W+aF/pvQRZgM4HDQMXCnkLyb6oERwwDeqb8YE0stkCLWkxUSOewVpg4uBIk6ZkMe2roFuFyARv0fI= X-Received: by 2002:a92:5a14:: with SMTP id o20mr18937001ilb.236.1599484716089; Mon, 07 Sep 2020 06:18:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 7 Sep 2020 18:48:24 +0530 Message-ID: Subject: Re: [pgAdmin][SonarQube] : Remove duplicates string literals. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000053a18a05aeb90e3a" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000053a18a05aeb90e3a Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Sep 3, 2020 at 7:19 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > > On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi > wrote: > >> Hi Pradip >> >> Following are the review comments: >> >> - ROLE_NOT_FOUND already in wrapped in gettext() then no need to use >> like gone(_(ROLE_NOT_FOUND)). In fact, can we use >> >> self.not_found_error_msg()instead of new constant. >> >> - Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext, >> also we can use this constant for string " >> >> Error retrieving roles from the database server" >> >> >> >> On Thu, Sep 3, 2020 at 4:30 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch for removing duplicates string literals. >>> /server_groups/servers/roles/__init__.py - 8 places >>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000053a18a05aeb90e3a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Sep 3, 2020 at 7:19 PM P= radip Parkale <pradip= .parkale@enterprisedb.com> wrote:
Hi Akshay,

Please fi= nd the updated patch.


On Thu, Sep 3, 2020 at 6:24= PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Pradip <= br>

Following are the review comments:
<= ul>
  • ROLE_NOT_FOUND already in wrapped in gettext() then no need to use l= ike gone(_(ROLE_NOT_FOUND)). In fact, can we use 
    self.not_fo=
und_error_msg()instead of new constant.
  • Same with ERROR_FETCH= ING_ROLE_INFORMATION it's already in gettext, also we can use this cons= tant for string "
    Error retrieving roles from t=
he database server"

    • On Thu, Sep 3, 2020 = at 4:30 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
    <= /div>
    Hi Hackers,

    Attached is a patch for removi= ng duplicates string literals.
    =C2=A0 =C2=A0 =C2=A0 =C2=A0 /= server_groups/servers/roles/__init__.py =C2=A0- 8 places


    --
    Thanks & Regards,
    =
    Pradip Parkale
    Software Engineer | Enter= priseDB Corporation


    --
    Thanks & R= egards
    Akshay Joshi
    pgAdmin Hacker | Sr. Software Architect=
    = EDB Postgres
    Mobile: +91 976-788-8246



    --
    Thanks & Regards,
    =
    Pradip Parkale
    Software Engineer |= EnterpriseDB Corporation


    --
    Thanks & Regards
    Akshay Joshi
    <= div>pgAdmin Hacker | = Sr. Software Architect
    EDB Postgres
    Mobile: +91 976-788-8246

    <= /div>
    --00000000000053a18a05aeb90e3a--