Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMqC1-0000Nd-4Z for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:43:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jMqBz-0005pW-1n for pgadmin-hackers@arkaria.postgresql.org; Fri, 10 Apr 2020 09:43:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMqBy-0005pP-Ml for pgadmin-hackers@lists.postgresql.org; Fri, 10 Apr 2020 09:43:18 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jMqBr-0003Xd-RY for pgadmin-hackers@postgresql.org; Fri, 10 Apr 2020 09:43:17 +0000 Received: by mail-io1-xd2b.google.com with SMTP id m4so1232542ioq.6 for ; Fri, 10 Apr 2020 02:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FfrwZ8LhYX63MfThrwEZX/hma6P1fv5uzjM0/S/eSY0=; b=aWiFRqALNPdAuJLOsoQgp8FwTuMTcDNL4udJyNLG5HeLjBuDOKaXrOyDXzIYutYFf8 gAp/yxUlrSC5c5zHYaB6pigzzuj0MoFR8I5TmU+XkztSGjn86/qDLGMJSqPndmlzHCCC NqxBIkguv+IoSLXEdgqewoCAYIFF5ievz4uvBMPBiCR66WXtC0ro/adTy5mD3zW9jSKN altMLDhveZeBZCB2d4UbYzOOCVk/FafeDdt+rhYaACtXC+ycXLm7pfxi5XOXTPbQ3qza JMyqzAkbQJxOI1ONRKQ9cP0r80hRzbUXytsz1gw7mzri/In75W9uFre8RGuw/H93TB23 sUpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FfrwZ8LhYX63MfThrwEZX/hma6P1fv5uzjM0/S/eSY0=; b=TVU23eeOz7B5iEEXVH3LyAC7DP3dCo3wbr5MoplTFqAeInkSxHcohQsM+fDc/gsdRM Voc2ZB/QE0YML9sKJz6Ty9kemUDFGcNHyYUFtCQlrQf1cHMTGRbvtrR5l/ToJm52JrwY kmHz/w7b5aNyFwRJSMlrHMX30/VNAKRGsH0R/QoCftHLHjuDC6HlzZCIv4jV8xxlVVkG 0g6Z0JgVQOAALO+g3RYuLIcWCkxNBM1fkXw8Ery1wMqpfEJmNkfb3W/qJmPNvRPYJqb7 NAyj3rxJxZP0qO6MsxOrOyKgYe/nCjEZO99PVSVM6Evfi3rusinSyAFeWYaPdpeDmDXS 5+DQ== X-Gm-Message-State: AGi0PuaEufRwVRlA7t3+IGJZPWwPjjz6CHD6HN+jN6cxGRN5nYYPjUIA m+AmnITaAckJP6+37nAgz4s+4c2K9ur7slwae7IcEs87/vyrGlLt0qBbTJSNioYnERenGs5lovm T2UINV5HpsnkVYhmwGtZQAigOJQc3p54cZGWAdDVbl9w5UehsC6abUhBIqUFV5EE2QkIG8uAEyx Nrm8efsN7ZY0PW6FBsR+iXGNQzEk9oTKCyDdEPbPrUdynNUh5/Qlc= X-Google-Smtp-Source: APiQypIYLaxPNhI5SxxPLwUAO6a6H+PyAQ6tlAzvWckuAgLJoenYdU4wxJ6kP257AXnTz9JY+inVv8xvtFNX2F99f38= X-Received: by 2002:a02:650f:: with SMTP id u15mr3882441jab.53.1586511790747; Fri, 10 Apr 2020 02:43:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 10 Apr 2020 15:12:59 +0530 Message-ID: Subject: Re: [pgAdmin][RM5227] Cannot add user To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b850dc05a2ec8f39" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b850dc05a2ec8f39 Content-Type: text/plain; charset="UTF-8" Hi Aditya Can you please rebase and send the patch again. On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix following user management related issues: > 1) Unable to add a user when there are many users. The dialog went blank. > Fixed. > 2) Error message did not have a close button. Fixed. > 3) When clicked on the add button, then cursor will focus on the email box > of the new row for convenience. > 4) When the dialog opens, the cursor will focus on the search text box. > 5) By default, "User" role will be selected when adding a new user. Also > removed an empty option in the roles dropdown. > 6) When the search filter is applied and we try to add an already existing > user, the validation is done only on the filtered data and not on all the > users data. This is fixed. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000b850dc05a2ec8f39 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

Can you please rebase an= d send the patch again.

On Fri, Apr 10, 2020 at 10:33 AM Aditya Toshn= iwal <aditya.toshni= wal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to f= ix following user management related issues:
1) Unable to add a user when t= here are many users. The dialog went blank. Fixed.
2) Error message did not= have a close button. Fixed.
3) When clicked on the add button, then cursor= will focus on the email box of the new row for convenience.
4) When the di= alog opens, the cursor will focus on the search text box.
5) By default, = "User" role will be selected when adding=C2=A0a new user. Also re= moved an empty option in the roles dropdown.
6) When the search filter = is applied and we try to add an already existing user, the validation is do= ne only on the filtered data and not on all the users data. This is fixed.<= /div>
=
Please review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0EnterpriseDB In= dia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"
=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000b850dc05a2ec8f39--