Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmD6D-0004qG-WE for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 07:37:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmD6C-0006kd-Kx for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 07:37:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmD6C-0006je-FK for pgadmin-hackers@lists.postgresql.org; Wed, 23 Jan 2019 07:37:24 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmD68-0005Rn-Lu for pgadmin-hackers@postgresql.org; Wed, 23 Jan 2019 07:37:23 +0000 Received: by mail-qt1-x82a.google.com with SMTP id e5so1275165qtr.12 for ; Tue, 22 Jan 2019 23:37:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uY/0nc9NfTbfCS7Z1I3TCK9c+v46u/Ryj21hAlzzkHs=; b=GDE1WS+0bCRXUGIuz/gDuxY91dHkVHy4L3lrSpqix/CIqvcsM3W1uKNkaa8FRgtacl Ol3DGwC9eUlf9xHAHw/gSO7tKb7r/9RNjihws8HdGpaG2Clp9IbEgiG4Wh/7k7sMouzX 1cqmJVwVUBkDZIBFLyAtuk6AONlsv91KaJyitlgjCgv/vcY+AS7Px94CPqtTG3yORm21 k1H/ZppciqcQ5uSvW1UtgA6HQeLRsdPpwyKEiP/oSvzRXR0iWMKCtMpBD/7BI8wvLf8E Zc2he0ukzQGznObbl2cMV/yKphysGQRYfBEI32O4l6yOWi1STSaGhJBXRvZrUlXq/wHt 5cXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uY/0nc9NfTbfCS7Z1I3TCK9c+v46u/Ryj21hAlzzkHs=; b=eh+Ocle+On8VwCidusqqWAuy3qoQ8TyhQcI6AEqaChicXrpLKMHTomMOp9H7TIHJZT AOwiBx27eeX2hNal7RTasbcQQRyb1NQVTeND3bjD+CLn5ZBlOgSuaGeztIwyur9t1E9O jSjVns2EVZmiWn2lOoa07mMvV2Ommnu+tZAyJJgVtGCnrHDhfclDzwBW69xizQFxh+G4 m+i1lPNw3l41xNo2iMWpgzg337C86EFeG+hkciqQl/twa+MVKDu/qqKGMGdYicouqsPR pBEjGeriEppd1NJ3nP6aZOrxp7WZAy+MyLJisiz6GMyNs2A9vsqfqylQlEQZxKXIvR5f 99yg== X-Gm-Message-State: AJcUukdvIA39LiKENDhD6XgPzvOFLnOpqukz0YMRQyFDKbZDBIxbxfs4 P2JPWRz6lwrGZU/0YPaf68sXReXTRgTvegjqJ1PHrw== X-Google-Smtp-Source: ALg8bN5i+7mnLhlM2OHLcVlDHQ3f9eNLPp5W69rRZ2CFiU3zjU/8VVGFjqoW6zXG9WE/YoF6HUhJH8+EHRq1oyp3xgs= X-Received: by 2002:ac8:7201:: with SMTP id a1mr1126385qtp.291.1548229038577; Tue, 22 Jan 2019 23:37:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 23 Jan 2019 13:07:07 +0530 Message-ID: Subject: Re: [pgAdmin4][patch] pgAdmin4 better exception handling To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e02fe905801b2977" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e02fe905801b2977 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Wed, Jan 23, 2019 at 11:01 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch will improve exception handling for pgAdmin4 on the server > side. The app level exception handler will handle unhandled exception > gracefully, logging it and sending the exception message as response. > This will also help in getting the exception where users are facing query > tool initialise error. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000e02fe905801b2977 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Wed, Jan 23, 2019 at 11:01 AM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch wil= l improve exception handling for pgAdmin4 on the server side. The app level= exception handler will handle unhandled exception gracefully, logging it a= nd sending the exception message as response.
This will also help in gettin= g the exception where users are facing query tool initialise error.

Ki= ndly review.

--
<= font face=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Thanks = and Regards,
<= font face=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Aditya = Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0<= /span>Pune
"Don't Complain about Heat, Plant a tree"=


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000e02fe905801b2977--