Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVCcu-0002yG-J7 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Oct 2020 11:49:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kVCct-0001Ps-H1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Oct 2020 11:49:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVCct-0001OH-35 for pgadmin-hackers@lists.postgresql.org; Wed, 21 Oct 2020 11:49:55 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kVCcp-0007Yu-TT for pgadmin-hackers@postgresql.org; Wed, 21 Oct 2020 11:49:54 +0000 Received: by mail-il1-x12f.google.com with SMTP id z2so2225692ilh.11 for ; Wed, 21 Oct 2020 04:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ogu+hNGQPMI0PQsbrO0Wx5v0tMHHvoN9wxKx/utB3H8=; b=A7qgWVXKzM6uAEzrZRxbsdfMMBcTm6gxbT+nxvmLvC7sKlcIa+BKS4Iwoh2ieYz1UE iy/NRt3RahCGIJ/cWU/CpG8B+xdPJQI8AWt+MXxJmlAMev3JPYT2PGJxwYEYVoCJtxw4 zR20Rqcdk6WXwffZBwdwrJEBW5P1hoCIddz4hElzebHYqIUtyPwQIQ+8Qx1wyhEBE/cr GTkJvLpOmT/DjkBJ6fv+HLTIlYR5Pw6zRIpyNfOP/UY3PItlZRxb9QKcczTmGWYDRnPc IKxIy4sQ0o24MHaueG++hLI5+8CcVNJWOPe8jeuMRG3m0Gym+8QbgoHQ7qvJ3hin+NWY Tg4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ogu+hNGQPMI0PQsbrO0Wx5v0tMHHvoN9wxKx/utB3H8=; b=MvcJYhEB82XTwD45zZ6oCG4CNk7CQgXFrTUNIkUbylHgW1im7QToI3QrU2hA1FkSJx NaYQgZ4kKlq1SlPfy1kK8oVH0806E84ywmIA97QYW6ynHU/ySxxZanmOx21a5cGzKmWj tvrW4WvK6jwO87qPWZQjmoB6jYki5YRuLPnImYwfQcMCpI6mnYUwLT+C3vKkO0D1lAf5 eJSyDmFC7QBxY2eTQsn69bcOb5RaEbk70Tr6emb0FRp3luDvs9uHpoPBWZbgF5Ad12GL KeZm1+VJ+yQDZVmCAQFd/tq5x8y+MucFIvOoQaJ3B267chB39aisL8o45zJH9Bdxm6hf LBew== X-Gm-Message-State: AOAM530Mk/O0V9E6jGLziQIwsj9NxbXp9/ECPTjoNqyPtXAGkhv+4Bmo F5ul5qnpygkTMJafYBdb+buWP4g5tRgihQez7gVczuT8JKDokPkyM6vs/Yb8hXVuKUPkvRZGfZZ WnhU/hPDfTnA8O0UCuTLT1mijdoS9mVxbvj7YO1HZ6ZgIFcbYQxUe6kTVbDI70efMgJk1cO31Hn UgmhGd/H5zNaawZ5jIOui7Jd0NHC4bgV9UoDQuznMu1oESSCrLKAwVgMjCXw== X-Google-Smtp-Source: ABdhPJzXixyv/IFlAufuoyuaMN37rffEAsYmBWmtcgKT+EpRc84c5BZ5WY2ukjWoBr8DemjhN9pvrNncPru9kAFJmWU= X-Received: by 2002:a92:dd12:: with SMTP id n18mr2143706ilm.236.1603280991017; Wed, 21 Oct 2020 04:49:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 21 Oct 2020 17:19:39 +0530 Message-ID: Subject: Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f1f6dd05b22cf1cb" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000f1f6dd05b22cf1cb Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Oct 21, 2020 at 4:45 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Akshay, > > I have fixed the review comments, PFA the updated patch for the same. > > > Regards, > Nikhil Mohite. > > On Wed, Oct 21, 2020 at 2:55 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Nikhil >> >> Following are the review comments: >> >> - Connect to any server from the browser tree. Open the query tool >> and then open the new connection dialog. Click on the "OK" button without >> changing any field. It shows the popup for "Change connection" which should >> not be raised because the server is the same. >> - In the above scenario, if you click on the Yes button it is showing >> a duplicate entry for the same server. >> - The server name is not getting changed when we connect to any >> other server from the new connection. Changes needed in alertify message, >> tab title, and a combo box. >> - Remove the "." from the "Change connection." title. >> - Change the string "Change connection will lose all non committed >> changes for current connection, do you want to continue?" to "*By >> changing the connection you will lose all your unsaved data for the current >> connection.* >> *Do you want to continue?*" >> >> Please fix the above changes and send the patch again. >> >> On Wed, Oct 21, 2020 at 11:08 AM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have updated the existing implementation as per suggestions. >>> 1. Show servers in server groups in the dropdown. >>> 2. Current selected connection in the new connection dropdown is now >>> highlighted as selected. >>> 3. Notification to the user before the change connection action. >>> 4. If we connect to the server through a new connection dialog, the tree >>> will use the same connection and it will not create a new connection. >>> (In earlier implementation it was asking for the password even we have >>> connected from a new connection dialog.) >>> >>> PFA patch >>> >>> Regards, >>> Nikhil Mohite. >>> >>> On Thu, Oct 8, 2020 at 11:39 AM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Wed, Oct 7, 2020 at 12:11 PM Nikhil Mohite < >>>> nikhil.mohite@enterprisedb.com> wrote: >>>> >>>>> Hi Akshay, >>>>> >>>>> I checked the implementation and found 2 locations which I missed in >>>>> the last patch to remove async: False. >>>>> I have removed all occurrences of async: False now also added missing >>>>> loader in required places. >>>>> >>>>> PFA updated the patch for the same. >>>>> >>>>> Regards, >>>>> Nikhil Mohite. >>>>> >>>>> On Tue, Oct 6, 2020 at 6:19 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Nikhil >>>>>> >>>>>> Please verify and remove async = false wherever possible. >>>>>> >>>>>> On Tue, Oct 6, 2020 at 5:24 PM Dave Page >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala < >>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Akshay, >>>>>>>> >>>>>>>> We have used aysnc=False in most ajax calls with this feature, It >>>>>>>> is causing UI hang in case of slow server response. >>>>>>>> You can try adding a time.sleep() call at the python side response >>>>>>>> and check the UI hang, I think we should avoid sync calls as much as >>>>>>>> possible. >>>>>>>> >>>>>>> >>>>>>> I consider a sync ajax call to be a bug. >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> Murtuza Zabuawala >>>>>>>> *EDB* >>>>>>>> *POWER TO POSTGRES* >>>>>>>> https://www.edbpostgres.com >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Thanks, patch applied. >>>>>>>>> >>>>>>>>> On Thu, Oct 1, 2020 at 10:42 AM Nikhil Mohite < >>>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Akshay, >>>>>>>>>> >>>>>>>>>> I have resolved the sonarQube issues, PFA updated patch for the >>>>>>>>>> same. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Regards, >>>>>>>>>> Nikhil Mohite. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, Sep 29, 2020 at 11:31 AM Akshay Joshi < >>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Nikhil >>>>>>>>>>> >>>>>>>>>>> Your patch introduces 1 new Bug and 13 new code smells, please >>>>>>>>>>> fix those and resend the patch. >>>>>>>>>>> >>>>>>>>>>> On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < >>>>>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Akshay, >>>>>>>>>>>> >>>>>>>>>>>> I have resolved code conflict issues and sonarqube issues. >>>>>>>>>>>> PFA updated patch. >>>>>>>>>>>> >>>>>>>>>>>> Regards, >>>>>>>>>>>> Nikhil Mohite. >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi < >>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Nikhil >>>>>>>>>>>>> >>>>>>>>>>>>> The patch is not applying, rebase, and send it again. Please >>>>>>>>>>>>> check your code should not create any new SonarQube issues. >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < >>>>>>>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Akshay, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have resolved all the review comments and also updated the >>>>>>>>>>>>>> test cases as per the new implementation. >>>>>>>>>>>>>> >>>>>>>>>>>>>> PFA updated patch. >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Sep 21, 2020 at 5:24 PM Akshay Joshi < >>>>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Nikhil >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Following are the initial review comments: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Open View/Edit data on any table and click on the same >>>>>>>>>>>>>>> database connection and then click on the Execute button. Got >>>>>>>>>>>>>>> "get_primary_keys() takes 1 positional argument but 2 were given" error. >>>>>>>>>>>>>>> - In my opinion, we should hide the option to change the >>>>>>>>>>>>>>> database connection for View/Edit Data. >>>>>>>>>>>>>>> - If the user clicks on the same database connection >>>>>>>>>>>>>>> multiple times then no need to change the backend connection and >>>>>>>>>>>>>>> transaction id. Add validation at the backend, no action required in this >>>>>>>>>>>>>>> case. >>>>>>>>>>>>>>> - The role option is missing from the "connect to >>>>>>>>>>>>>>> server" dialog. >>>>>>>>>>>>>>> - The Password field should not be there on the "connect >>>>>>>>>>>>>>> to server" dialog. Sometimes we saved the password so asking a password >>>>>>>>>>>>>>> every time is not correct. Check the pgAdmin 3 behavior. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Code review still remains. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite < >>>>>>>>>>>>>>> nikhil.mohite@enterprisedb.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Team, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Regarding RM-3794 >>>>>>>>>>>>>>>> allow >>>>>>>>>>>>>>>> the user to change the database connection from an open query tool: >>>>>>>>>>>>>>>> I have implemented the feature and also added documentation >>>>>>>>>>>>>>>> for it. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> PFA patch. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> *Thanks & Regards,* >>>>>>>>>>>>>>>> *Nikhil Mohite* >>>>>>>>>>>>>>>> *Software Engineer.* >>>>>>>>>>>>>>>> *EDB Postgres* >>>>>>>>>>>>>>>> *Mob.No: +91-7798364578.* >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>>>>>>>>> *EDB Postgres * >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>>>>>>> *EDB Postgres * >>>>>>>>>>>>> >>>>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>>>>> *EDB Postgres * >>>>>>>>>>> >>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards* >>>>>>>>> *Akshay Joshi* >>>>>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>>>>> *EDB Postgres * >>>>>>>>> >>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> VP & Chief Architect, Database Infrastructure >>>>>>> EDB: http://www.enterprisedb.com >>>>>>> >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Sr. Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Sr. Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000f1f6dd05b22cf1cb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Oct 21, 2020 at 4:45 PM Nikh= il Mohite <nikhil.mohi= te@enterprisedb.com> wrote:
Hi Akshay,

I have fi= xed the review comments, PFA the updated patch for the same.

=

Regards,
Nikhil Mohite.

=
On Wed, Oc= t 21, 2020 at 2:55 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:=
Hi Nikhil

Following are the review comments:
  • Connect to any server from the browser tree. Open the query tool a= nd then open=C2=A0the new connection dialog. Click on the "OK" bu= tton without changing=C2=A0any field. It shows the popup for "Change c= onnection" which should not be raised because=C2=A0the server is the s= ame.
  • In the above scenario, if you click on the Yes button it is sh= owing a=C2=A0duplicate=C2=A0entry for the same server.
  • The server n= ame is not getting changed when we connect to any other=C2=A0server from th= e new connection. Changes needed in alertify message, tab title, and a comb= o box.
  • Remove the "." from the "Change connection.&q= uot; title.
  • Change the string "Change connection will lose all= non committed changes for current connection, do you want to continue?&quo= t;=C2=A0 to "By changing the connection you will lose all your unsa= ved data for the current connection.
    Do you want to continue?"
Please fix the above changes and send the patch agai= n.

On Wed, Oct 21, 2020 at 11:08 AM Nikhil Mohite <nikhil.mohite@enterpris= edb.com> wrote:
Hi Akshay,

I have updated the ex= isting=C2=A0implementation as per suggestions.
1. Show servers in= server groups in the dropdown.
2. Current selected connection in= the new connection dropdown is now highlighted as selected.
3. N= otification to the user before the change connection action.
4. I= f we connect to the server through a new connection dialog, the=C2=A0tree w= ill use the same connection and it will not create a new connection.
<= div>(In earlier implementation it was asking for the password even we=C2=A0= have connected from a new connection dialog.)

PFA = patch

Regards,
Nikhil Mohite.

On Th= u, Oct 8, 2020 at 11:39 AM Akshay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Thanks, patch applied.

On Wed, Oct 7, 2020 at 12:11 PM Nikhil Mohit= e <n= ikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,

=
I checked the implementation and found 2 locations which I missed in t= he last patch to remove async: False.
I have removed all occurren= ces of async: False now also=C2=A0added missing loader in required places.<= /div>

PFA updated the patch for the same.

=
Regards,
Nikhil Mohite.

On Tue, Oct 6, 2020 at 6:= 19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Nikhil=C2= =A0

Please verify and remove async =3D false wherever po= ssible.

On Tue, Oct 6, 2020 at 5:24 PM Dave Page <dave.page@enterprisedb.com> wrote:


On Tue, Oct 6, 2020 at 12:51 PM Murtuza= Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Akshay,

We have use= d aysnc=3DFalse in most ajax calls with this feature, It is causing=C2=A0UI= hang in case of slow server response.
You can try adding a time.sleep() call a= t the python side response and check the UI hang, I think we should avoid s= ync calls as much as possible.

= I consider a sync ajax call to be a bug.
=C2=A0


--
Regards,
Murtuza Zabuawala
EDB
POWER TO = POSTGRES


On Thu, Oct 1, 2020 at 1:31 PM Akshay Joshi <akshay.joshi@enterprised= b.com> wrote:
Thanks, patch applied.

On Thu, Oct 1, 2020 at 10:4= 2 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,

I have=C2=A0resolved the sonarQube issues, PFA update= d patch for the same.


Regards,
Nikhil Mohite.


On Tue, Sep 29, 2020 at 11:31 AM A= kshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil
Your patch introduces 1 new Bug and 13 new code smells, please= fix those and resend the patch.

=
On Mon, Sep 28, 2020 at 7:31 PM Nikhi= l Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,
I have resolved code conflict issues and sonarqube issues.
PFA updated patch.

Regards,
Nikhil= Mohite.

On Mon, Sep 28, 2020 at 5:58 PM Akshay Joshi <akshay.joshi@enter= prisedb.com> wrote:
Hi=C2=A0Nikhil

The patch is = not applying, rebase, and send it again. Please check your code should not = create any new SonarQube issues.

=
On Mon, Sep 28, 2020 at 11:20 AM Nikh= il Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Akshay,
I have resolved all the review comments and also updated the t= est cases as per the new implementation.

PFA updat= ed patch.



On Mon, Sep 21, 2020 at 5:24 P= M Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Nikhil
Following are the initial review comments:
  • Ope= n View/Edit data on any table and click on the same database connection and= then click on the Execute button. Got "get_primary_keys() takes 1 pos= itional argument but 2 were given" error.
  • In my opinion, we sh= ould hide the option to change the database connection for View/Edit Data.<= /li>
  • If the user clicks on the same database connection multiple times t= hen no need to change the backend connection and transaction id. Add valida= tion at the backend, no action required in this case.
  • The role opti= on is missing from the "connect to server" dialog.
  • The Pa= ssword field should not be there on the "connect to server" dialo= g. Sometimes we saved the password so asking a password every time is not c= orrect. Check the pgAdmin 3 behavior.
Code review still remains.

On Thu, Sep 17, 2020 at 4:15 PM Nikhil Mohite <nikhil.mohite@enterpri= sedb.com> wrote:
Hi Team,

Regarding RM-3794 al= low the=C2=A0user to change the database connection from an open query tool= :
I have implemented the feature and also added documentation for= it.

PFA patch.

--
Thanks = & Regards,
Nikhil = Mohite
Software = Engineer.
Mob.No: +91-77983645= 78.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Dave Page
VP & Chief Architect, Database Infr= astructure
EDB: http://www.enterprisedb.com

Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--000000000000f1f6dd05b22cf1cb--