Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzypk-0003vh-SZ for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 09:22:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzypj-0000r4-Ot for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 09:22:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzypj-0000qx-AH for pgadmin-hackers@lists.postgresql.org; Thu, 14 Jan 2021 09:22:23 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kzypg-0003Pe-8T for pgadmin-hackers@postgresql.org; Thu, 14 Jan 2021 09:22:22 +0000 Received: by mail-io1-xd2e.google.com with SMTP id q2so8171567iow.13 for ; Thu, 14 Jan 2021 01:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ovmd4FFsh7TcXHds/G41Sh9QM8jTe9PskAeMAYmpTcE=; b=OH6ssJqf2UABtHfPDmd6De6BEGtoBdYm4xJh4VEHGoqrGT1OzBDWvWkOnUnxDlX80G CV3FM4EklhT2k/0TqKYISeP237N8rpJwqGMlRcAVXtpgqnI5EB+e7v2DNdQ8JVus5RMk NaQc7sYt7QovAzIMTmbVGay/Ant3fBtQ/4se/bU4Mvkd96QGoQYHnqh053sUBiTodOQN vgjtEaETMw2O48Q+G2LfX43FWkVYLTMNR8WMnxjhvirxVyt12/7jTl0d//WxZ3cNmppT mYqJtl0NmRjqNWlSAWC8UZr6NQ4WzWVOFCnsua8Y/jRBzlQ8QbO5MYCmp4YXG4zHiORc OMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ovmd4FFsh7TcXHds/G41Sh9QM8jTe9PskAeMAYmpTcE=; b=GF9ltCtAibFf3uVgZeuYrd6jJSHXeQewOsx8y+idIkx+RCZw2OMnBvaUZNhCm9v19+ QolDDWmICNZbu5L/w9OQwJfKtTNVSwhEDD0MrJGpL98TWE1B08OdflkW+4n80QWHa+Gg R2JHykqvrUbJ4ICBniaTXJQJScePu7R77V8w/AnKb3EC7aFIlbn3EB1RVY3VO73poTQi at+aGx0DZGYXkRGohWSkGr6VJE/lO96hwhacr6gNigIln1BvCrVjJqlczgv/SKv8ZTav JCJpq7bXWJvzLME10bZdnp5EqXeOxnGfmCEK9BhBTFTLrX7Z7lpNgSnVVyTmOE3w50av hMDw== X-Gm-Message-State: AOAM531e1ILJwdpeYq7wXEhHxt+VIltHZ0JrmcpWuRg8jqwV4FUcksxk 5mxdw5gUK8R/5ld1QzQqd+ZAN9Nx0POcp4huCjwwMr/UsXo1u1Dc3Va3deostG0Y0aQi4kTcdEY +3tPlDBArZVjKRkolE5yxdmZwi1oLCDP1IfzKoLrH+RWl36LV1Olrzbq9Ig5qrxldKZMgSDLOnX TWDWulF40bZjxmfL4mOQ0wcY2KjNp9O1L2kxLOhjPRR1CNMhT52yoy7T3B6Q== X-Google-Smtp-Source: ABdhPJwrjFF8JIzk25YWM3mMs6V1D5qQAZRiW7YTNjkEeNieKnGHFQu0QhZej2C8Cg4yn6r8uVFfZKtIDbVcZ6v7K+A= X-Received: by 2002:a92:6706:: with SMTP id b6mr6098323ilc.121.1610616139089; Thu, 14 Jan 2021 01:22:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 14 Jan 2021 14:52:08 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires. To: Nikhil Mohite Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="000000000000d71c5405b8d8caf6" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d71c5405b8d8caf6 Content-Type: text/plain; charset="UTF-8" Hi Nikhil On Thu, Jan 14, 2021 at 2:38 PM Dave Page wrote: > > > On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < >> nikhil.mohite@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> Please find the attached patch for RM-6120 >>> : Adding/updating user >>> should not allow to add an older date in account expires. >>> Added UI validation if a user enters the account expiration date >>> manually. >>> >> > I think this needs to be reverted (and the UI fixed to allow an older date > to be selected). > Please fixed as suggested by Dave and send the patch. I'll update the RM > > Selecting a past expiry date is a perfectly valid way to create an account > that is effectively locked, for example, to allow pre-creation of roles for > staff that are yet to join. > > PostgreSQL doesn't prevent this - why should we? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: http://www.enterprisedb.com > > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000d71c5405b8d8caf6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nikhil

On Thu, Jan 14, 2021 at 2:38 PM = Dave Page <dpage@pgadmin.org>= ; wrote:


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000d71c5405b8d8caf6--