Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQMx-00034o-I4 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 10:44:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewQMw-0004J6-8u for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 10:44:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQMw-0004Iq-0X for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 10:44:22 +0000 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewQMt-0002Lb-3e for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 10:44:20 +0000 Received: by mail-qk0-x230.google.com with SMTP id d206so6731005qkb.3 for ; Thu, 15 Mar 2018 03:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=549ZVjPOVVDGE+S2nXeLSFJ/cxFz1wennQ5+xikcYao=; b=znjooZynoCG+qT9CbOgoYJRxpAovurif5y6xY9rpsHnafu7PYO1jBAgrt2TnOBGLAL Qmq1N5SHoKM41nIEurPmQILgMKhpZAgxT/4LZhZUUPkHJRnChE3s2bbAoS7OsqKcZ5AT 9fjYTJ8/ZUB7ilEtLrSF9l9eiFfCMRIGvieZSJ3sJ0zLn+9D6+dOA8eqeueglCN5qfPq fYchATQLW6deGn3oSJ/CmvuZgGzjaIXsyaR6Akp0s3VUcxdVRiA+66kQV+puU6CO7VLO iVQBdbAVLvGycc+X+C7OCpfTNesWiCGL4kdacb29Ymnm8R+mpy1fJgfstovgyaNFGoOA Z7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=549ZVjPOVVDGE+S2nXeLSFJ/cxFz1wennQ5+xikcYao=; b=jL0oaAVQ8TchbITbz81nG31MGSm3iihII6wD8D+DtGGsj2HOpTNgm87VILgkoVCDTU B8j87J2ZsSYJihS32erCMRnszX1C37UZuX3CQ6r0TkE+YH4N8hSfQBM3OdmX25tsqivw tmLSGCiYWWBwqPzMZlK4jQuK7hzuAu8RD+TXFL1U4s9zQ3tCa7kpme/evP7z/3FyOJPC 7+O2HV7Fa9my3CehzXMjJydh2OSyT4UKqFm6aEdlNEHn4ZEOAaq1SrpAKauZHpG8Lsjr CSyikabPsfcliKH5xli+kxKCstWxKKDPnLKUydD48QQjOb/dXZevdKm+GD6dyBiRuZVG 4W/g== X-Gm-Message-State: AElRT7EKG50S+7PElYAznZHMyQxHfLwSwS8FVLRkk53wEtF1xjFjGsUs sXqGY7HjNsvTvoYieNtEcdhceyAZqwRztQTSsG4qsg== X-Google-Smtp-Source: AG47ELu44EFU6bLws4QmoH767DtsiDCTpYIy2ogpZi/eFlvLr0ajgRCSsO27hpjMy7+Mn1Ikjwz7OvInXCn6Jnll+eo= X-Received: by 10.55.194.77 with SMTP id j13mr11989950qkm.213.1521110657929; Thu, 15 Mar 2018 03:44:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.194.131 with HTTP; Thu, 15 Mar 2018 03:44:17 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Thu, 15 Mar 2018 16:14:17 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317 To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="f4f5e80e55346e2fbf0567712c9b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f4f5e80e55346e2fbf0567712c9b Content-Type: text/plain; charset="UTF-8" Thanks patch applied On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Akshay, > > Given commit introduce PEP8 issue, PFA minor patch to fix the issue. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Sporadically crashes on Windows when exit. Fixes #3177 >> 1) Shutdown the python server properly. >> 2) Disabled "Shutdown server" menu till server is not successfully >> started. >> >> Initial patch sent by Maxim, modified by Akshay Joshi. >> >> Branch >> ------ >> master >> >> Details >> ------- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif >> f;h=54b1a79cb6f90ac9b26db57e616dc750fb2c6b54 >> Author: Maxim Zakharov >> >> Modified Files >> -------------- >> runtime/Server.cpp | 11 +++++++++++ >> runtime/Server.h | 3 +++ >> runtime/TrayIcon.cpp | 11 +++++++++++ >> runtime/TrayIcon.h | 4 ++++ >> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++ >> ++++++++++++++ >> runtime/pgAdmin4.h | 1 + >> web/pgadmin/misc/__init__.py | 16 ++++++++++++++- >> 7 files changed, 91 insertions(+), 1 deletion(-) >> >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --f4f5e80e55346e2fbf0567712c9b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied=C2=A0

On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Aks= hay,

Given commit introduce PEP8 issue, PF= A minor patch to fix the issue.

--
Re= gards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company
<= /div>
<= br>

On Thu, Mar 15, 2018 at 1:27 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:
Sporadically crashes on Windows when exit. = Fixes #3177
=C2=A0 1) Shutdown the python server properly.
=C2=A0 2) Disabled "Shutdown server" menu till server is not succ= essfully started.

Initial patch sent by Maxim, modified by Akshay Joshi.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
Author: Maxim Zakharov <dp.maxime@gmail.com>

Modified Files
--------------
runtime/Server.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++++++++++=
runtime/Server.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 3 += ++
runtime/TrayIcon.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++++++++++
runtime/TrayIcon.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 4 ++++ runtime/pgAdmin4.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 46 ++++++++++++++++= ++++++++++++++++++++++++++++
runtime/pgAdmin4.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 +
web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
7 files changed, 91 insertions(+), 1 deletion(-)





--
Akshay Joshi
Sr. Software Architect
=

<= /font>

Phone: +91 20-3058-9517
Mob= ile: +91 976-788-8246
--f4f5e80e55346e2fbf0567712c9b--