Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiK17-0001TT-3o for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 14:44:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiK08-0004we-0F for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 14:43:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiK07-0004vD-BS for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 14:43:19 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiK04-0001B8-Qr for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 14:43:18 +0000 Received: by mail-qk1-x744.google.com with SMTP id i125so14124504qkd.6 for ; Tue, 02 Jul 2019 07:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+shZflZ5Yrzz3dCMxW7vjAq8SweGlNPwUO62LKuH9jA=; b=jk8yazdD9+xa1h6dFfhr87unPpmbV8Vv2nqR7w2RIeYSYhLcUiYRkqDwYdpNSg7siK PU13NCMtnCSzA48F8t5TOub8SD1SqtsDBDHwKz5E+JdXoAyeLxscNTE9TlVrM9g7kEsk GO48ZgRuaZ/G3dPAvEKmT0/1B4KQ8yLrb/LIFEEGSxOCxG380hgmphKrdAQzaatwTPqH SmI/Hm4WX5I1T9PjJq5roXGkH5exm+q4+JY5nIBThGYvj0DyjW3FAMBiCEYEixSZeqkz X12icIZqyq3gXSE6oqYzGIkJnIjUItl4YHbJbk8OYrEK1yVK1U1pGIRA6F5Db9ODTIYJ conQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+shZflZ5Yrzz3dCMxW7vjAq8SweGlNPwUO62LKuH9jA=; b=RTAOMW2YgYj1ZYxLHJbWSeoFyhaCbG5Gv3dZBZ/EaUGGGaO6hrEMQWVlHKJpCVV7Ki iOzxIiAaeEP2P8l4mMkHs/uvHfAkLmVdIE6cJR+MCt2nGQ6+5dNmcN49xqHhMZu6+zia g7r78M2SactUY8rtVH7aiutCVpOA38G5HK3tSNRlNg2NpudTPcbhIPG5OBRVc/QbZYQ2 A8f+wRFvJWjW0YEH+0HDewyiMcft+V+LGtgvI7Eqwkv8OgfVN5+aBf1FCk93TV71gA7Y UF/ryE4JkXvIiI/0BsgJH1HFteCLt5w27487h5z+JhWp/CC3A856bR8ez5+h6HdpLOh2 1GaA== X-Gm-Message-State: APjAAAX7bqCpF6RudVWrhruoPPvm70ptDnFEbF48B8mAn0AV+vCLqKNN r5DZspXQXWlny+rTE/9NA4JmRa3empbyjV4h9WPXRQ== X-Google-Smtp-Source: APXvYqy/gadbOYVpCIsGTaDuWrXcbqhiPLKcX4uXA5QzdlREn0FQFCrd0yZocebhdbgFjAh3Hkr10yVrKliTCGIM3n8= X-Received: by 2002:a05:620a:69c:: with SMTP id f28mr25383695qkh.274.1562078595848; Tue, 02 Jul 2019 07:43:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 2 Jul 2019 20:13:04 +0530 Message-ID: Subject: Re: pgAdmin4 v4.10 candidate builds To: Aditya Toshniwal Cc: Fahar Abbas , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000d140b5058cb3c306" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000d140b5058cb3c306 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Tue, Jul 2, 2019 at 5:31 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > The issue still persists. I have checked the code and found that > CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 > and not -1. > Attached is the patch. > > Sorry for trouble to build again. :/ > > > On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi > wrote: > >> Hi Fahar >> >> We have fixed RM #4421. Candidate builds and source can be found at >> https://developer.pgadmin.org/builds/2019-07-02-1/ . >> There is some problem with the wheel packages, will check that. Meanwhile >> can you please test the builds for upgrade issue. >> >> On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas >> wrote: >> >>> Hi, >>> >>> Here is the showstopper issue for pgadmin4 4.10: >>> >>> https://redmine.postgresql.org/issues/4421 >>> >>> Kind Regards, >>> >>> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi All, >>>> >>>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>>> release pgAdmin4 v4.10 early. Candidate builds and source can be found >>>> at https://developer.pgadmin.org/builds/2019-06-28-1/ >>>> >>>> Fahar, can you please verify it for release on Tuesday (2nd July). >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Fahar Abbas >>> QMG >>> EnterpriseDB Corporation >>> Phone Office: +92-51-835-8874 >>> Phone Direct: +92-51-8466803 >>> Mobile: +92-333-5409707 >>> Skype ID: *live:fahar.abbas* >>> Website: www.enterprisedb.com >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000d140b5058cb3c306 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Tue, Jul 2, 2019 at 5:31 PM Aditya= Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi,

The issue still persists. I have checked the code and found tha= t CompareVersions(Version, '{#MyAppFullVersion}') =3D -1, this shou= ld b= e 1 and not -1.
Attached is the patch.

Sorry for tro= uble to build again. :/


=
On Tue, Jul 2, 2019 at 4:39 PM Akshay= Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Fahar

We have fixed RM #4421. Candidate=C2=A0builds=C2=A0and source c= an be found at=C2=A0https://developer.pgadmin.org/builds/2019-07-02-1= /=C2=A0.
There is some problem with the wheel packages, will = check that. Meanwhile can you please test the builds for upgrade issue.

On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas <fahar.abbas@enterprisedb.com&g= t; wrote:
Hi,

Here is the showstopper issue = for pgadmin4 4.10:


Kind Regards,
On Fri, J= un 28, 2019 at 8:21 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote= :
Hi All,

Due to an showstopper issue found in pgA= dmin v4.9, we will have to release pgAdmin4 v4.10 early. Candidate=C2=A0= builds=C2= =A0and source can be found at=C2=A0https://developer.pgadmin.org/buil= ds/2019-06-28-1/

Fahar, can you please verify it for release o= n Tuesday (2nd July).
--
Thanks & Regards
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile:= +92-333-5409707
Skype ID: live:fahar.abbas
Website: www.enterprisedb.com=


--
Thanks & Regards
Akshay Joshi
<= div>Sr. Software Arch= itect
EnterpriseDB Soft= ware India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000d140b5058cb3c306--