Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly9kC-00045d-H6 for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jun 2021 09:09:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ly9kB-0007eV-9n for pgadmin-hackers@arkaria.postgresql.org; Tue, 29 Jun 2021 09:09:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ly9kA-0007eN-FU for pgadmin-hackers@lists.postgresql.org; Tue, 29 Jun 2021 09:09:22 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ly9k6-0003wB-Th for pgadmin-hackers@postgresql.org; Tue, 29 Jun 2021 09:09:21 +0000 Received: by mail-io1-xd2f.google.com with SMTP id i189so25724374ioa.8 for ; Tue, 29 Jun 2021 02:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vdIUP6njHWgd4YuAXB2jVE61qIiUkAcqX1I+27ykNVw=; b=HXxWC0AGzj3JSWDfzn5WNETc3n9nI/2xgOiW9+3kXH5nzD7VL8JicKAnzsbVrKaIpL hbiW6FG5ll6YCOkknnq62pRTpEjrTUudEKlB4huOGKVKNOd+8a8HC8KlWNBRmLM2L/E8 MoRT/UKhw3umd4o0PLwKX3n4JI6i6ZJ6wKS9D6RkzGtiwD1whP8IthAmtYwNl/kMMlV5 tNWN3XbQbmCp7RCaw6qesdRBf/yYaXmxXbwpJi+ICWAjlFBF714hsodfM6WG/1b8xrPu +Q03lrtmRVe6Kneszs3cv4+20lnk36FocAq30TinZ+uK3YdiS6VPHvodqeK9pW26Diwn lkLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vdIUP6njHWgd4YuAXB2jVE61qIiUkAcqX1I+27ykNVw=; b=iPRci4xj81MmGUDRQyMlNMf4d8YricV2SrlOlB88ZqWVfpi9clwrcUoS3OUd1y9pP+ Yl5lxTGqNtm6DCyEGWSlGVuu7VsyyNHpo3I5P8qE681OopSibKOpyJ/E2m4qYTkwvnHh XQKTJvNEnLi3BbJx37Lufa5kxrmaLGuJKsT0w3+FiXZPpv2HWgC2me0eIEKEHriUiR+j 4jgSDQUJ1tQweCVW6mOqHQuPH7uTLw7+lJmK1fYEVv92KjigS8hn6z/2qUK3UbB3vJkA 6PeNpAmRzh2uZKCXTndIM1PizGDHinsdMfJSjC/LjCdGka+CwAqWGjlp2GpL2YU6Os4n TddA== X-Gm-Message-State: AOAM532NZGoegEWfu0G+6DW37YqdPiUJeAYvO+83JT1SPTVoHYnDNaug o4pNCWm9hB1j4EY7C/DJtmpEwFVuXqqrcfIJEvzA4gVTh7zNBbVm8yLN2JipzjX9U58w88WyA2W 3dsdJ7KCe6WGlsLg2+rg2GUloSSN6ulQctlfF1mIfrduZaNBfpj6PyiXlyXVW76me+ulxj/IAfF XbCGXOmKl0ud6hTydO/zSfaIX9XV/sIMPX2ABhYFXVd8y0to/BtQ2zRlIkng== X-Google-Smtp-Source: ABdhPJwnW0lkUzLFwnJJN3W8p4L4CmyOCpK5lgKwPIDF/bXhVypQfwiciHwkgJhI1GFGTe4BKBBcuhyeEGBZVnmb3rU= X-Received: by 2002:a02:666d:: with SMTP id l45mr3516869jaf.0.1624957757900; Tue, 29 Jun 2021 02:09:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 29 Jun 2021 14:39:06 +0530 Message-ID: Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ef606b05c5e3f5a5" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000ef606b05c5e3f5a5 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Mon, Jun 28, 2021 at 3:57 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Please ignore the previous patch. Attached is the revised patch. > > On Mon, Jun 28, 2021 at 2:50 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I made some changes to the core code that will be helpful for other nodes. >> Please review. >> >> >> On Thu, Jun 24, 2021 at 5:39 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, the patch applied in the "React_Porting" branch. >>> >>> On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> On Thu, Jun 17, 2021 at 7:26 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached patch marks the beginning of migrating properties dialog/tab >>>>>> to React based code, which is easy to maintain, performant and testable >>>>>> using automation. >>>>>> Patch includes: >>>>>> - Framework for creating React based dynamic form view out of a >>>>>> pre-defined UI schema. Previously, it was based on Backform/Backbone. >>>>>> - The new framework and components will use MaterialUI as base. >>>>>> Previously, Bootstrap/Backform/jQuery components were used. >>>>>> - The new code uses JSS instead of CSS since material ui and most >>>>>> modern React libraries also use JSS. In future, this will allow us to >>>>>> change the theme in real-time without refresh. >>>>>> - 90% code covered by 80-85 new jasmine test cases. >>>>>> - Server group node UI Schema migration to new, with schema test >>>>>> cases. >>>>>> - Server node UI Schema migration to new, with schema test cases. >>>>>> - Database node UI Schema migration to new, with schema test cases. >>>>>> - Few other UI changes. >>>>>> >>>>> >>>>> Nice! >>>>> >>>>> >>>>>> >>>>>> PS: Until all the nodes are migrated, this will not go in the main >>>>>> branch. >>>>>> >>>>> >>>>> Yeah, how are we going to manage this? I agree with building it out in >>>>> a branch until we have full coverage of the dialogues, but I'm concerned >>>>> that it'll become a merge nightmare. Though, I guess we aren't touching the >>>>> dialogues much for other things right now, so maybe not. >>>>> >>>> We'll right now work only on the dialogs. So merging should be >>>> manageable. >>>> BTW, the patch can be merged in the main branch as well. It is backward >>>> compatible, and it will work fine. Only the UI components would look >>>> slightly different from the non-migrated dialogs. >>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: https://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EDB: https://www.enterprisedb.com >>>>> >>>>> >>>> >>>> -- >>>> Thanks, >>>> Aditya Toshniwal >>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>> >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000ef606b05c5e3f5a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Mon, Jun 28, 2021 at 3:57 PM = Aditya Toshniwal <a= ditya.toshniwal@enterprisedb.com> wrote:
Hi=C2=A0Hackers,

Plea= se ignore the previous patch. Attached is the revised patch.
On Mon, J= un 28, 2021 at 2:50 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

I made some changes to the core code that wi= ll be helpful for other nodes.
Please=C2=A0review.


On Thu, Jun 24= , 2021 at 5:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Th= anks, the patch applied in=C2=A0the "React_Porting" branch.
=
On Mon= , Jun 21, 2021 at 9:35 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.co= m> wrote:
Hi Dave,

On Thu, Jun 17, 2021 at 7:26 PM= Dave Page <dpage= @pgadmin.org> wrote:
Hi

On Thu, Jun 17, 2021 at 11:01 AM Aditya= Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch marks the beginning=C2=A0of migrating properties dialog/ta= b to React based code, which is easy to maintain, performant and testable u= sing automation.
Pa= tch includes:
- Framewor= k for creating=C2=A0React based dynamic form view out of a pre-defined UI = schema. Previously, it was based on Backform/Backbone.
- The new framework and components will use = MaterialUI as base. Previously, Bootstrap/Backform/jQuery components were u= sed.
- The new code = uses JSS instead of CSS since material ui and most modern React libraries a= lso use JSS. In future, this will=C2=A0allow us to change the=C2=A0theme in= real-time without refresh.
- 90% code covered by 80-85 new jasmine test cases.
- Server group node UI Schema migration to new, with schema test c= ases.
- Server node UI S= chema migration to new, with schema test cases.
- Database node UI Schema migration to new, wit= h schema test cases.
- F= ew other UI changes.

Nice= !
=C2=A0
<= div dir=3D"ltr">

PS: Until=C2=A0all the node= s are migrated, this will not go in the main branch.

Yeah, how are we going to manage this? I agree = with building it out in a branch until we have full coverage of the dialogu= es, but I'm concerned that it'll become a merge nightmare. Though, = I guess we aren't touching the dialogues much for other things right no= w, so maybe not.
We'll right now work on= ly on the dialogs. So merging should be manageable.
BTW, the p= atch can be merged in the main branch as well. It is backward compatible, a= nd it will work fine. Only the UI components would look slightly different = from the non-migrated dialogs.
=C2=A0
--
=


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000ef606b05c5e3f5a5--