MIME-Version: 1.0
References: 
 <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
In-Reply-To: 
 <CAOBg0AP6zw+5M2Ux8u9igedVHKUOrPwEdH=+pwmCgfki=o=a=A@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Wed, 9 Sep 2020 11:28:05 +0530
Message-ID: 
 <CANxoLDeMg5nqxnKM_H3j3cVLGFJEzB4Dtrm6rqUBDLA4PJQ+Bg@mail.gmail.com>
Subject: Re: Patch for SonarQube code scan fixes.
To: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000042782c05aedb23f6"
Precedence: bulk

--00000000000042782c05aedb23f6
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied. I haven't committed changes for
"sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com>
wrote:

> Hi Team,
>
> I have fixed some code smell issues in the SonarQube scan, PFA patch.
> Details as follows:
>
> 1. psycopg2/connection:
>
>    - Refactor this function to reduce its Cognitive Complexity from 32 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 17 to
>    the 15 allowed.
>
> 2. psycopg2/server_manager:
>
>    - Refactor this function to reduce its Cognitive Complexity from 20 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 33 to
>    the 15 allowed.
>    - Refactor this function to reduce its Cognitive Complexity from 26 to
>    the 15 allowed.
>
> 3. sqlautocomplete/parseutils:
>
>    - Refactor this function to reduce its Cognitive Complexity from 23 to
>    the 15 allowed.
>
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--00000000000042782c05aedb23f6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied. I haven&#39;t committed changes for=
 &quot;sqlautocomplete/parseutils&quot;, as Dave suggested send the patch t=
o pgcli.<br></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"=
gmail_attr">On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite &lt;<a href=3D"mai=
lto:nikhil.mohite@enterprisedb.com">nikhil.mohite@enterprisedb.com</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div>Hi Team,<div><br></div><div>I have fixed some code smell issu=
es in the SonarQube scan, PFA patch.</div><div>Details as=C2=A0follows:</di=
v></div><div><br></div>1.=C2=A0psycopg2/connection:<div><ul><li>Refactor th=
is function to reduce its Cognitive Complexity from 32 to the 15 allowed.</=
li><li>Refactor this function to reduce its Cognitive Complexity from 17 to=
 the 15 allowed.</li></ul>2. psycopg2/server_manager:</div><ul><li>Refactor=
 this function to reduce its Cognitive Complexity from 20 to the 15 allowed=
.</li><li>Refactor this function to reduce its Cognitive Complexity from 33=
 to the 15 allowed.</li><li>Refactor this function to reduce its Cognitive =
Complexity from 26 to the 15 allowed.</li></ul>3. sqlautocomplete/parseutil=
s:<div><ul><li>Refactor this function to reduce its Cognitive Complexity fr=
om 23 to the 15 allowed.</li></ul><div><br></div><div><br></div><div>-- <br=
><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D"verdana, sans-serif">Th=
anks &amp; Regards,</font></b><div><b><font face=3D"verdana, sans-serif">Ni=
khil Mohite</font></b></div><div><b><font face=3D"verdana, sans-serif">Soft=
ware Engineer.</font></b></div><div><a href=3D"https://www.enterprisedb.com=
/" target=3D"_blank"><b><font face=3D"verdana, sans-serif">EDB Postgres</fo=
nt></b></a></div><div><b><font face=3D"verdana, sans-serif">Mob.No: +91-779=
8364578.</font></b></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=
=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"co=
lor:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:=
collapse">Thanks &amp; Regards</span></b></font></div><div><font color=3D"#=
3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;fon=
t-size:13px;border-collapse:collapse">Akshay Joshi</span></b></font></div><=
div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:=
arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmin Hacker | =
Sr. Software Architect</span></b></font></div><font face=3D"arial, sans-ser=
if" color=3D"#000000"><b><a href=3D"http://edbpostgres.com" target=3D"_blan=
k">EDB Postgres</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><s=
pan style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;b=
order-collapse:collapse">Mobile: +91 976-788-8246<br></span></b><br></div><=
/div></div></div></div></div></div>

--00000000000042782c05aedb23f6--