Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icU6Q-00045Q-Bj for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 12:49:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1icU6P-0006pR-6l for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Dec 2019 12:49:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1icU6O-0006pK-SL for pgadmin-hackers@lists.postgresql.org; Wed, 04 Dec 2019 12:49:57 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1icU6L-0008L0-BS for pgadmin-hackers@postgresql.org; Wed, 04 Dec 2019 12:49:55 +0000 Received: by mail-io1-xd43.google.com with SMTP id z23so7792051iog.11 for ; Wed, 04 Dec 2019 04:49:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q4r6te744SCS0umud89MsAypKqjSgwOb2kQy6n4mlxs=; b=v/QoVWURyKilKRTtqEotJ9nLhklEQXJswaa1DHjMp987qKshnIIwXpgbq44QbaNDCw NCt+m02WvDhTTL1owgnihSSuB1DcNM+WtoCSdlK01GTm5iHNXmvMLgqWGsMbUnBMHCrS ILIP/f4uR5N+at3eyDZTlo+sU7uKi49cdcVwTbtnwGjLSVHGBuizXAOqcyMjcaQy6bw3 JtHOR27ylokQ8hN9iNCADgV4N+0lOzIKxR+DDXl1nSdqwJ9yQ9f+3ApM4+WIUP0E15Ua jpG9zkVaAm/NypASf2GNgZUG0oXpFPGmbG5NzsvDZWvVvk2JQ2GwDQMSnSWAbf2HuvmY BMXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q4r6te744SCS0umud89MsAypKqjSgwOb2kQy6n4mlxs=; b=P8vXVl4atjUq3w9DW6svTFSckR3Uv6CQ7vszNFGE7SLlAW/0/LrpWrpycOG4ZLailm Yx+mNYjxOcqLltMS0GzZj8AdlOd59q52JLrdq/+1GIVrd86MWOZnA6UZ3RPEL0eT/ZiC 85nZu/StQsJG3g5GhKH4LoShrwYfYO331/vhM6BBWxnhwRW94dlrhuzpUhCyj9jX17xP BmQuGfLNzpAn/BcrY6ICg0Blavvh6sx1UhQtrALJAqfIzfFUwz44D7rO/HR2LWMMZKyC Ez80UOTiMGLW+GWpDbksZif8W/N+IrqX4WxJrXWHiuGRpjGSqbQR+6Nh2CjCvP8XL9lT iZCA== X-Gm-Message-State: APjAAAXdMJx6abQ944GWQBMiQ5s2aBUMjaj72Us/Wx7f9fK4jX5P7FNJ tdGWExDRILz8OGw6oR4XrPLZ8QZn6bhETADgB67L2BNa5WlZ51ti5WBEOvIIFDjncsH0ZQQQYYv +bcMrIE/in1gDsq0vBRMO3LQu1D1/SItiC7ZVeovJNlEaEmi1yLO/pA+6GEWjOUazUG+dt/GJ4d yFWy2OLrbNLLTfodbacAq2YNTfRoa+i0dtXj37+xI17W4TcQh4pbc= X-Google-Smtp-Source: APXvYqy7kVsrD6m4kHZtDlT2uxEYAyBrR8j9D0B7hI3XV1ParPUHGW/2ZTe6qXGReCsqLPFGo+QOoK6N8W4kSxtjlc4= X-Received: by 2002:a05:6638:285:: with SMTP id c5mr2882641jaq.7.1575463791870; Wed, 04 Dec 2019 04:49:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 4 Dec 2019 18:19:40 +0530 Message-ID: Subject: Re: [pgAdmin][RM4772][Accessibility] Provide aria-label to an invisible label where a visible label cannot be used To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000abe1d40598e03f3d" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000abe1d40598e03f3d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Dec 4, 2019 at 3:00 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the feature tests which were failing after > the commit. The reason being, the span elements which was used to show > properties tab data is changed to input now as per accessibility > requirements. Also, there is no way now to check XSS of input because the > input tags returns the original value on extracting the value attribute and > not the escaped value. Previously, the value was HTML element under the > span tag. > Not to worry, input is escaped and is XSS free, handled in underscore > templates. > > On Tue, Dec 3, 2019 at 12:48 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Dec 3, 2019 at 11:39 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to add label and aria-label wherever applicable. >>> The patch also fixes few other accessibility related errors raised by >>> "WAVE" extension of Chrome. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000abe1d40598e03f3d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Dec 4, 2019 at 3:00 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the= patch to fix the feature tests which were failing after the commit. The re= ason being, the span elements which was used to show properties tab data is= changed to input now as per accessibility requirements. Also, there is no = way now to check XSS of input because the input tags returns the original v= alue on extracting the value attribute and not the escaped value. Previousl= y, the value was HTML element under the span tag.
Not to worry, input is es= caped and is XSS free, handled in underscore templates.

On Tue, Dec 3,= 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Th= anks, patch applied.

On Tue, Dec 3, 2019 at 11:39 AM Aditya Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the pat= ch to add label and aria-label wherever applicable. The patch also fixes fe= w other=C2=A0accessibility=C2=A0related errors raised by "WAVE" e= xtension of Chrome.

Kindly review.

--
=
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0= Pune
"Don't C= omplain about Heat, Plant a TREE"
=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000abe1d40598e03f3d--