Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glv6Z-0006S0-6P for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 12:24:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glv6X-0001AF-Vh for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 12:24:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glv6X-0001A8-IZ for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 12:24:33 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glv6U-0004YQ-Q6 for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 12:24:32 +0000 Received: by mail-qt1-x832.google.com with SMTP id t33so27258997qtt.4 for ; Tue, 22 Jan 2019 04:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4YbHQdQ2nAYmYIDHVMAfZjqjhUw1jM6M2EaanEkw3q0=; b=y1W4JWw+oNJwCf9p16Lk2ix2bCXq6E7LcoRYSvWSakCc/HKO5j9prD9Sdr0PmFj9zx 4xMltHae9E9A6vCIDOvM9jYFqTYQm8ovVAAtHf30BEua5ICWz7eKTkHK6aePsHwsGR3l BddJNF9x0M0DMxJ2Jr9DAuNioK7fzmZjvOe5vTLNtOBh1Y6gsYABESnKBG/tQjbf5mGp gicc5qnUcwjFk5kSt3edyL/uX+Wh29DOWXA4EapobzownqYui3e54Y8TJ4zkp70XJPux FOZrSS8wHlcGSUyJJLE7TYtpej/5AT2O7uDbVEHpiIP6Vln4qislsVyYO44z8ThXarHE lIrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4YbHQdQ2nAYmYIDHVMAfZjqjhUw1jM6M2EaanEkw3q0=; b=Zu8hPpw15sFjyJrqLHps21GfoiDpj0UkDJqQVu1lDbPoQtL1JQA+SpphwHS5WStCG/ 22DiHfGveWcnVcy4n1ZgKM060cdigN+DB85ONkVRq8Vp9rNzZUJ+kZElteyhgnV6ImN+ wY+WIrM/VZxU/DqMh3ZyQ2jiHJPZan0e3U+07oMyu5EX3wiepOXl9rJDnGM1PnObxyLz jM7ZFTjONQaKnR9I19mJ1SRHhdCk9GiC0d/eNdTSw4dyVdalh5j+ef1mZwDA1Dx42b4K 3dN78/wezbkqTApKS3tXSGbATpESwxnSPloEvr8l/mfzAGWkKh5AtcYtahCPGiq2/fqn ZtRg== X-Gm-Message-State: AJcUukfbMgm76mHNFPwa8rDZS9yoF7QLlrHF27OU/dA8TiqdZ/dBlvbX K3YCKFBGiEGD6tlftR+MQFYoZxNHHNsb2oIOQW/6uQ== X-Google-Smtp-Source: ALg8bN6mWKXNFem5LN/9hWkRKG0ziLH/y5nCW9GAGZ2fOCs6npL5JHElKy019xAsUbViouZBh3ISvLs+O41dmZ7fCWY= X-Received: by 2002:ac8:7201:: with SMTP id a1mr30983371qtp.291.1548159869502; Tue, 22 Jan 2019 04:24:29 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 22 Jan 2019 17:54:18 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "[" To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000013ddf105800b0fdd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000013ddf105800b0fdd Content-Type: text/plain; charset="UTF-8" Thanks patch applied On Tue, Jan 22, 2019 at 5:28 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Khushboo >> >> On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> Please find the attached updated patch. >>> >>> On Mon, Jan 21, 2019 at 2:57 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>> >>>> Can you please fix the following and send the patch again >>>> >>>> - PEP8 issue >>>> >>>> Fixed >>> >>>> >>>> - Test cases is failing with Python 3.5. >>>> >>>> I have tested with Python 3.7 and it is working fine. Please give me >>> the log to reproduce the issue. >>> >> >> I have tested it with Python 3.5 with PG10 and 11. Attached is the >> screenshot. >> >>> >>>> Fixed. > >> On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix the RM #3853 - Incorrect SQL >>>>> generated for create script of domain type interval with precision. ERROR: >>>>> syntax error at or near "[" >>>>> >>>>> The patch includes the fix as well as the API test case to verify the >>>>> reverse Engineered SQL. >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> >>>> >>>> Thanks, >>> Khushboo >>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000013ddf105800b0fdd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jan 22, 2019 at 5:28 PM Khushb= oo Vashi <khushboo.va= shi@enterprisedb.com> wrote:
Hi,

Plea= se find the attached updated patch.

On Tue, Jan = 22, 2019 at 4:17 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi=C2=A0Khushboo

On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:
Hi Akshay,

Ple= ase find the attached updated patch.

On Mon, Jan 21, 2019 at 2:57 PM A= kshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Khushboo

Can you please fix the following and send the patch again
    PEP8 issue
Fixed=C2=A0
  • T= est cases is failing with Python 3.5.
I have tested with Python 3.7 and it is working fine. Please give me the = log to reproduce the issue.

=C2=A0 =C2=A0 I have tested it with Python 3.5 with PG10 and 11. Attache= d is the screenshot.=C2=A0=C2=A0

=
Fixed.=C2=A0
On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <khushboo.vashi@enter= prisedb.com> wrote:
Hi,

Please find the attached= patch to fix the RM #3853 -=C2=A0Incorrect SQL generated for create script= of domain type interval with precision. ERROR: syntax error at or near &qu= ot;["

The patch includes the fix as well as the AP= I test case to verify the reverse Engineered SQL.

Thanks,
Khushboo


Thank= s,
Khushboo=C2=A0
--
Akshay Joshi<= /font>
Sr. = Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=


--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--00000000000013ddf105800b0fdd--