Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzFrq-00015q-KW for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 09:21:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzFrn-0002bp-6V for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 09:21:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzFrn-0002Zx-0z for pgadmin-hackers@lists.postgresql.org; Tue, 12 Jan 2021 09:21:31 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kzFrh-0006TN-KA for pgadmin-hackers@postgresql.org; Tue, 12 Jan 2021 09:21:29 +0000 Received: by mail-io1-xd33.google.com with SMTP id p187so2562578iod.4 for ; Tue, 12 Jan 2021 01:21:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iySM3UZTMsdKINmPcJsgdby9b9Gmqjn6L0QxBEZ9jew=; b=GTm+GJImzee6H8Y9GxzsosYjtj17Nk8ffo1y0UIAo1A1IV3e9rZl4IlokKQp4BjQcI ZWSKt8l3JgjxAvkPqxDC/6+PlLXcuoozSb2vKhh4R/J3Kyj4pjzR3bDhq/lfJtxB7EGB hNSMm3xEBkLqfl/6h9u6EJ0anLVljH7sYAtsGWtRiyVs3vOZw8yhdqRAZOhsJViUbm4K OlA1rOjHAS8ii38MwnGwWZ17MMRdfyFjJdJ91QC7hkOwuJzy3H6l9gntOSUgCOUi/O+C wmHhOkQbYmB9E463bWrnG6cytf2htHodlA/g6CB95FwuTVrTdVXhlTUaa2hT0pJCNswK boIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iySM3UZTMsdKINmPcJsgdby9b9Gmqjn6L0QxBEZ9jew=; b=DW6UcXRfkCXPIhcMCg5y5oaMX9cn/K7wYruznQxf+bcpZMS+qNojVfA8/OVFQsAQML Guk2ecipN4EYtwAem7MwlxrLyOJHfM+lsM3FWn2SeoreMzZ1UCYbtpaxpFX4s6nWSt+M mvciQRMcFA3OWJ2gCLnHliUaTvsaxiYCiCwGoULKaeWgwgWYYBHbOS7pspfaH5MPeXUe 3CuOHMTn9aPzbVoQP9HRr2OGrbsOTJQh1SO0S0NIjfVbfX+Y94Uqfnwl9ld26CnXtQi0 UbE7djMnqFrETvGc746RGnAHf9UL1y1TllBoM8/w4ECAnIHeuzUIcawSxf3GGLDvCwKA Nfgg== X-Gm-Message-State: AOAM533mIIPuQtd3mv+B8zFXRevUdXm3OjB4ZaXIZL581eEf8OlA7bEw AbMeBwcVjNu5ZRpB3kPynBbhBrMRnDc89OX3fLwsLACfyGDoh0CAcBV7l0WsdC/+fHuz1jXxblb CH8v6AUv+t6McgUMKQTWTaAMsaZrfjaTwJ6hUgVjpDNXVnCmkOxXxabN7F2IKIN2kWee8eOrLiW vsZtoKIXWp66/FTfaaM/9jHeaD3p46GZ4zNO1LrMTkjGzIX10qi+eKF5Xiog== X-Google-Smtp-Source: ABdhPJzuGk39x8doB3kUpbSLGzKJ2Ew7ENl9Bls8GSQrjIb6mUcYn8IPzxeo9ocnXPvkCHGPxotoOhvauB3yKO87+IE= X-Received: by 2002:a02:690e:: with SMTP id e14mr36384jac.7.1610443284421; Tue, 12 Jan 2021 01:21:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 12 Jan 2021 14:51:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e636fd05b8b08b35" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e636fd05b8b08b35 Content-Type: text/plain; charset="UTF-8" Hi Aditya Code looks good to me. Below are the review comments: - Copy and Paste not working in the popup. - Documentation needs to be updated. On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch improves the way explain plan details tooltip for a node is > shown. With the change, popup with details will be shown upon clicking a > node, and it will remain open until explicitly closed. > > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000e636fd05b8b08b35 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

Code looks good to me. B= elow are the review comments:
  • Copy and Paste not working = in the popup.
  • Documentation needs to be updated.

On = Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb= .com> wrote:
Hi Hackers,

Attached patch improves the way explain pl= an details tooltip for a node is shown. With the change, popup with details= will be shown upon clicking a node, and it will remain=C2=A0open until=C2= =A0explicitly closed.

Please review.

--
Thanks,
Aditya Toshni= wal
pgAdmin hacker=C2=A0| Sr. Software Engineer | = edbpostgres.com
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--000000000000e636fd05b8b08b35--