Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpBLi-0000MF-C2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 12:21:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gpBLh-0007fd-3q for pgadmin-hackers@arkaria.postgresql.org; Thu, 31 Jan 2019 12:21:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpBLg-0007fW-Sz for pgadmin-hackers@lists.postgresql.org; Thu, 31 Jan 2019 12:21:40 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpBLa-0005kN-Kn for pgadmin-hackers@postgresql.org; Thu, 31 Jan 2019 12:21:40 +0000 Received: by mail-qk1-x72b.google.com with SMTP id o125so1729951qkf.3 for ; Thu, 31 Jan 2019 04:21:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X6/zoLMWNHDDh27aNevOhvSQ6J+8dQXtgZslMcYVzNA=; b=MXPvQzIWAOf7o8h7SRvbizA0h8w1w8fgK7uKIcwYbp93oyqSKvu93kAjlnmfiv4rqZ 1WtN9QHuHd4hKk/djC+0ieD9Lt5UByqU6C/jA0IdtOurk9dsyBvoSMVH1z48zQ7D4+4C Xww21xch9wD3rMLI5gfirmVBlG+iS5gp3J+CFSylsdXR6m1fSPCXGcAUztS0SSadWKMz 6ge4bXI6m5NSCILCEhUrBm213R1/lXATTQlm2EwLenM1zCe5EioZrmwiGs0xm9bt50/N IzZHdgoxjgDodoBegxCOZJwLYkAdq/PoRgnK/ukHPzUXu+jJ/nKvrewtuqt484G5oejU V2QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X6/zoLMWNHDDh27aNevOhvSQ6J+8dQXtgZslMcYVzNA=; b=GpNOmNPYC/mYN0KAAFo2jmVyk51+xnbvWciC1bKSXMCop/xfaqAX79vO9FHp9NAxSL Sy6FLq+9qqglDc22vSLgGh1pJkIsnQRHsiXTmeiLH9G4rsbncUqu4HY6O9+GExYAN/hH vhC+b8US1gEoS1/yFwXO9D09W4Ua3CKLatqq2vdsrHLEcp+5jex1O5uMUfMBi3LPCuqL 0UVBWDYA4ItzJmbWo47nWZiQ1I/apROp3hME9wOZo4PxMG0P2sngq9YT92v/ITz2SS4I hmdhs3Ao/hsJYmfh1UeRZrGSsLpPs7clRBcroNW9qIc1hlnt9sZskVSf7xQmfyvzGUsy 4X9w== X-Gm-Message-State: AJcUukegw3sPRRgnP+0npKH934OC8Yy42lKhC37VeuW/uRuThRLgjVDb NrEjmcYVklyNhKT90a6D1It1jXDzCLxLt1B9otaXzA== X-Google-Smtp-Source: ALg8bN7mV/0bO6T7zlbNUJni3hC3VEvmy71vOCQuHDeN/O0jVYA8ryJJlu+4Gmgao0kH0iXBBF3RgYp52RjMjrQNGyE= X-Received: by 2002:a37:7b01:: with SMTP id w1mr31526629qkc.122.1548937292336; Thu, 31 Jan 2019 04:21:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 31 Jan 2019 17:51:21 +0530 Message-ID: Subject: Re: Remove hacky way to open/close the dropdown-submenu To: Aditya Toshniwal Cc: Ashesh Vashi , "khushboo.vashi" , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000016e9280580c011f5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000016e9280580c011f5 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Thu, Jan 31, 2019 at 4:05 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Ashesh, > > The patch looks good to me. > > On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Ashesh, >>> >>> All works good, except one small change. Submenus should be closed if I >>> press Esc and then reopen the menu. >>> >> Please find the updated patch to resolve the review comments. >> >> -- Thanks, Ashesh >> >>> >>> On Thu, Jan 31, 2019 at 11:32 AM Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Aditya, >>>> >>>> On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Ashesh, >>>>> >>>>> I am getting a syntax error on bundle. >>>>> After fixing that, please look into this scenario: >>>>> Using keyboard shortcuts open object menu, for eg on table node. Go to >>>>> any submenu using keyboard and go to any submenu and press enter. >>>>> Now open object menu again using keyboard shortcut, the submenu >>>>> remains open. It should be closed. >>>>> >>>> Please find the updated patch with all comments fixed. >>>> Now - whenever the callback for the menu is called (menu toggling), it >>>> will close the existing submenu(s) too. >>>> >>>> Please review it, and let me know. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi >>>> * >>>> >>>> >>>>> >>>>> Everything looks fine to me except the above. >>>>> >>>>> >>>>> On Tue, Jan 22, 2019 at 10:07 AM Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Any update? >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Jan 17, 2019 at 7:39 PM Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Aditya/Khushboo, >>>>>>> >>>>>>> I can see a hacky way to open/close the dropdown-submenu in the >>>>>>> menu.js file. >>>>>>> I've followed a more general way to open/close any submenu in the >>>>>>> dropdown list, instead of just 'Objects' menu. >>>>>>> >>>>>>> Can you please review it, and let me know your thoughts? >>>>>>> Let me know if you have any other better approach. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>> "Don't Complain about Heat, Plant a tree" >>>>> >>>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000016e9280580c011f5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Thu, Jan 31, 2019 at 4:05 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Ashesh,

The patch looks good= to me.

On Thu, Jan 31, 2019 at 3:34 PM Ashesh Vashi <ashesh.vashi@enterpri= sedb.com> wrote:

On Thu, Jan 31, 2019 at 2:38 PM Aditya Toshniwal <aditya.toshniw= al@enterprisedb.com> wrote:

Hi=C2= =A0Ashesh,

All works good, except one small= change. Submenus should be closed if I press Esc and then reopen the menu.=
Please find the updated patch to resolve the = review comments.

-- Thanks, Ashesh=C2=A0

On Thu, Jan 31, 2019 at 11:32 AM As= hesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Ad= itya,

On Tue, Jan 22, 2019 at 10:25 AM Aditya Toshniwal = <= aditya.toshniwal@enterprisedb.com> wrote:
Hi Ashesh,

I am getting a syntax error on bundle.=C2=A0
After fixing that,=C2=A0 please= look=C2=A0into this scenario:
Using keyboard shortcuts open object menu, for eg on table node. Go = to any submenu using keyboard and go to any submenu and press enter.
<= div style=3D"font-family:verdana,sans-serif">Now open object menu again usi= ng keyboard shortcut, the submenu remains open. It should be closed.
<= /div>
Please find the updated patch with all comments fixe= d.
Now - whenever the callback for the menu is called (menu toggl= ing), it will close the existing submenu(s) too.

P= lease review it, and let me know.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi<= /i>

=C2=A0

Everything looks fine to me except the above.


On Tue, Jan 22, 2019= at 10:07 AM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Any upd= ate?

--=

Thanks & Regards= ,

Ashesh Vashi
EnterpriseDB INDIA: = Enterprise Postgr= eSQL Company


http://www.linkedin.com/in/asheshvashi



On Thu, Jan 17, 2019 = at 7:39 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi Aditya= /Khushboo,

I can see a hacky way to open/close the dropd= own-submenu in the menu.js file.
I've followed a more general= way to open/close any submenu in the dropdown list, instead of just 'O= bjects' menu.

Can you please review it, and le= t me know your thoughts?
Let me know if you have any other better= approach.
=C2=A0
=

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks and Regards,
= Aditya Toshniwal<= /div>
Software Engineer |= =C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't = Complain about Heat, Plant a tree"


--
Thanks an= d Regards,
Aditya To= shniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don't Complain about Heat, Plant a tree"


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--00000000000016e9280580c011f5--