Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo6Bp-0005xc-Ln for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Jun 2021 15:20:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lo6Bo-0007Ri-Kp for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Jun 2021 15:20:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lo6Bo-0007Ra-BD for pgadmin-hackers@lists.postgresql.org; Tue, 01 Jun 2021 15:20:20 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lo6Bm-0007I0-0r for pgadmin-hackers@postgresql.org; Tue, 01 Jun 2021 15:20:19 +0000 Received: by mail-il1-x131.google.com with SMTP id x18so7729361ila.10 for ; Tue, 01 Jun 2021 08:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0qy4+b0vhbfJLf3XBO3N3RMFNz66oCyB/Eh+w73tpgE=; b=n83TW7FM7vnuAj3HT7TJMIr1v43FX+Z0LKzluI/moTM3KS5H+eWmI2gnt1ncQfi8u/ lvQacO2UaF2jBgbzWVWtNoEn3CZttGUTXUzqAE7pxGTuZDIX1tiFEFiwCa6gSQnDaz5b ZaQDoWMyBwZteAvgATFGuYZwy8bfBMqlNC5YQWMEWgsJc5HNB8TDFvPVpEiqkEe4K1nH FKixyLgeFMryvZk8D+JbJeWMBftig7FJlKZUaXhjcMKk2oQCq/h+Ky/+zp5jmWBwPOSx cW4ZSU34/Ii3eVMAAz2yTVUDIOuAx+HSwDDGCO/GbjVPITjJs7/6VAeLeYns8zRt4mXv awWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0qy4+b0vhbfJLf3XBO3N3RMFNz66oCyB/Eh+w73tpgE=; b=Q2GhHulGvXh/YHtuyR8Qw0zsoTyywc9H5+g2xYbYuRcBugZ+EzqwmFGXJptILwO/F6 Cry3FIj4Fse4Oy8UBSr7ZCz3c6lph8sWu1vIWrc59AxFsJHZwVSoNVk8RYm3IklEu4ef fNtc0WiTr1SHsuw8R3LG32tPsdutujp5mEq5ARgLlP/OfVkZVxbPRWpb4+7C+5MnTEdN Rip7C7qed0unv4ohYUiFdqGzzJxv+z6E9zgEicIC3/QvGlTgSGuCpeSv2LYsz6nKNAwr kmoaeyBuKU5fTHisyng10IySoVo6qnoL95ByGUu9qdqjK62WSbLexYlIzhxiVoGBjOKO LDIg== X-Gm-Message-State: AOAM533llc0m8yHp0DPsMQqF1tHsNLXReYj1mx5KempYDEA7YN+8c0ff +WzIhYLJWqR38AYYT+oYqYVysrXI+3rVkhEAH9+N8UUNfleGaGUTb/Fk95il7LBPmcY8Pg5libp r1xceNRvCYUkRZYG6BHc/AUpty7qRBbmyy5L/8T/Y3NWcbLPl+lSgueXceFD7xj4GHkYPsjBp9p nI8vA5u0Fw9tF5WiSK8S6uiqY2e1nz+rfp7UGFXvC4NZHZqz5xks0U4pcykRkJjbhGfg== X-Google-Smtp-Source: ABdhPJydAe+ilZGClsv4o/TMnz1egsxMcSc0+2cOycNMVrVrxcpLAz0K6/0ySEfxF+T/X00aNyGn+UCVejt94iPlfaY= X-Received: by 2002:a05:6e02:46:: with SMTP id i6mr22051270ilr.252.1622560817049; Tue, 01 Jun 2021 08:20:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 1 Jun 2021 20:50:06 +0530 Message-ID: Subject: Re: [Patch][pgAdmin] RM4203 Rename Database by another user To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000208e1305c3b5e16c" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000208e1305c3b5e16c Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Hi Akshay, > > On Thu, May 27, 2021 at 12:19 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >> - Why you have changed the order of the toolbar button on the browser >> tree? It should not. >> >> Changes were related to the wcDocker issue showing reverse > order buttons, so had to change in the pgAdmin app to reflect it correctly. > >> >> - *sqleditor.js (check_db_name_change function)* >> - var declaration should be comma-separated instead of writing var, >> again and again. >> >> Done. > >> >> - Add proper comments. >> >> This too is taken care of. > >> >> - Remove dots from the string "Database moved/renamed.." >> >> Done. > >> >> - "Please note that the database you are working on has been moved or >> renamed to ${data.actual_db_name}. Refresh databases in browser panel or >> click OK to continue.." should be changed to "Current database has been >> moved or renamed to ${data.actual_db_name}. Click on the OK button to >> refresh the database name." >> >> Done. > Also have done some code refactoring. > >> >> >> On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which resolves the issue of renaming the >>> database by another user. >>> >>> A minor issue of navigation button alignment is also fixed in this patch. >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000208e1305c3b5e16c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Sun, May 30, 2021 at 12:0= 3 AM Rahul Shirsat <ra= hul.shirsat@enterprisedb.com> wrote:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Changes were rela= ted to the wcDocker issue showing reverse order buttons, so had to change i= n the pgAdmin app to=C2=A0reflect it correctly.
    • = Add proper comments.
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 This too is taken care of.=C2=A0
    • Remove dots from the = string "Database moved/renamed.."
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 Done.=C2=A0
    • "Please note th= at the database you are working on has been moved or renamed to ${data.actu= al_db_name}. Refresh databases in browser panel or click OK to continue..&q= uot; should be changed to "Current database has been moved or renamed = to=C2=A0${data.actual_db_name}. Click on the OK button to refresh the datab= ase name."=C2=A0
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 Done.=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Also have done s= ome code refactoring.


On Wed, May 26, 2021 at 2:07 PM Rahul Shi= rsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming t= he database by another user.

A minor issue of navi= gation button alignment is also fixed in this patch.
=
--
Rahul Shirsat
Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corpora= tion.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000208e1305c3b5e16c--