Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msjoa-0000zc-SC for pgadmin-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 10:59:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1msjoZ-0007Z6-Pm for pgadmin-hackers@arkaria.postgresql.org; Thu, 02 Dec 2021 10:59:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msjoZ-0007WH-74 for pgadmin-hackers@lists.postgresql.org; Thu, 02 Dec 2021 10:59:47 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1msjoW-000235-8f for pgadmin-hackers@postgresql.org; Thu, 02 Dec 2021 10:59:46 +0000 Received: by mail-il1-x12f.google.com with SMTP id t8so28495281ilu.8 for ; Thu, 02 Dec 2021 02:59:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AqNPebcsK+qvJOcZ97aVRVQP8cGr8w0SY0MkMtMpN6Y=; b=YoqDzenNuk7yj3tOoJFhpIlwtuNTuJ8mI/msoe2jM1PcNeGrC51lzNKP1rpnjCu1jV JWut3ZV4KXiPUldPEs33Ny7TEa+zPWY/tS5yRUvM5rXj+ocK5Tf1cEByEivDWIyS3LpZ KXxpDfez+t49liZBa4bgzohJeykoipfxa0v6Fz6pm1Sm2412zn/PkPn5HM2n4ARNPB1f ddTvSa/Rz0kP2IkAlL1WtIJOe8RJ5obc+fpY+jxJ/DF/SE7vyeqnv6mpLYRYOdWltn7/ ypM+arLwl+EaNdsdvJg8/rFQMMUCasAAaiHdkWrJ5m2grBHI8PNJZczkPNWZNV3jceif OuVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AqNPebcsK+qvJOcZ97aVRVQP8cGr8w0SY0MkMtMpN6Y=; b=2bYeSVV0Qxrf39wQBBCblA3AGN7pJPDMA/4mkmpxZcSlb1olzp1kQLlnxVqUv/sDpW rfZ3RfuXmDFAw5vd1J3kzkyeBiydwjmac892oM9EmOUVZNAipld3C0Zn83McZmIgotzB 5aK8n88zYKNLkE2jeq3U7ZQnSwQCbZGKELnl4BheXKfHWbr8RLdTZMJCy+WUa41rK+FX SdZ23coc930TS0ONOEC0a5GIU7yNOdcCSg2RBmZNVAyN6JKt0NpQiN6sOZ+Q11ZGDe5t UFn3RZ4J/oVZMe6LRUI9jcpAAOdw+qb16BcwbGDIER8tVStNlw8voJPxa3WGH8pPyKVc LOCA== X-Gm-Message-State: AOAM530QHGUz8qlVZePqDF0PjTW4JfaGKqNVOJJHrt+IiHxUFwojw3qh rEX3LPEaxiPZnBWOjEd3GWtlAul/zzx/GtKp7wqufHzaLB1HwCZdNI8oQGTCzoYKyO/Lnfpw3+O vJTle/ycBTNkf+UC/SAE9gk9jddsuf84gDxXLUHxGQpPiGASZFedAKPBDtmLIC8lxhBvy4bqsui 0VNDNE6vz42HGV49SY9J7RXPMvyZXk5WxkdMwNR7LxKrhxfKXOF+n7+7Eqjw== X-Google-Smtp-Source: ABdhPJz07CApCpU3TTWEMT900Q5Q13QEwlKzwX92RlhjesyypgGBfI6xfTMHshw4o86GF1dzOm50uVNcoigxbL9JcB8= X-Received: by 2002:a05:6e02:1e02:: with SMTP id g2mr15282433ila.290.1638442781655; Thu, 02 Dec 2021 02:59:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 2 Dec 2021 16:29:30 +0530 Message-ID: Subject: Re: [pgAdmin][RM7031]: Database definition wrong To: Pradip Parkale Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000fc615a05d227aff0" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000fc615a05d227aff0 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Thu, Dec 2, 2021 at 3:09 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. > > On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Pradip, >> >> You did not include the server_old table for query_history. >> > Fixed. > >> Please also remove the commented code: >> + # db.engine.execute("PRAGMA foreign_keys=ON") >> + >> + # db.session.commit() >> + >> + # db.engine.execute("PRAGMA foreign_keys=ON") >> + >> > Fixed. > >> >> >> >> On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, the patch applied. >>> >>> On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached for #7031 Database definition wrong. >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> Software Engineer | EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin Hacker | Software Architect | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000fc615a05d227aff0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Thu, Dec 2, 2021 at 3:09 PM P= radip Parkale <pradip= .parkale@enterprisedb.com> wrote:
Hi Akshay/Aditya= ,

Please find the updated patch.

On Wed, Dec 1, 202= 1 at 5:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
Hi Pradip,

You did not include the server_old table for query_histo= ry.
Fixed.=C2=A0
Please also remove the commented code:
+=C2=A0=C2=A0=C2=A0=C2=A0#=C2=A0db.engine.e= xecute("PRAGMA=C2=A0foreign_keys=3DON")
+
+=C2=A0= =C2=A0=C2=A0=C2=A0#=C2=A0db.session.commit()
+
+=C2=A0=C2=A0= =C2=A0=C2=A0#=C2=A0db.engine.execute("PRAGMA=C2=A0foreign_keys=3DON&qu= ot;)
+
Fixed.=C2=A0
=C2=A0


On Wed, Dec 1, 20= 21 at 5:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks= , the patch applied.

On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <pradip.park= ale@enterprisedb.com> wrote:
Hi Hackers,

Please = find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pr= adip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin Hacker=C2=A0| Software Architect=C2=A0| = edbpostgres.com
=
&q= uot;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000fc615a05d227aff0--