Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i4lJK-0000fE-K5 for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Sep 2019 12:19:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i4lJI-0004sA-T9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 02 Sep 2019 12:19:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i4lJI-0004s3-8G for pgadmin-hackers@lists.postgresql.org; Mon, 02 Sep 2019 12:19:52 +0000 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i4lJE-0006bw-BY for pgadmin-hackers@postgresql.org; Mon, 02 Sep 2019 12:19:51 +0000 Received: by mail-qk1-x72d.google.com with SMTP id f10so12316003qkg.7 for ; Mon, 02 Sep 2019 05:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j4d9ty/C/iU3fVM+9p+3Cx8lB1h9V58eW85ndg8M1BY=; b=OBJxhLDKg2+ln9Yz2Jx+fuzF/RJ7Orek9C52yd4cg5XOf4v5L+2Guk3ayTdEwSf49a KyQVp8WEjJ6xQqbTzT7z10+wiB/kMDvyYhfq1jenlGz+bWUxsmJljBXkixuq6ICOFcvI OM2gLbmnSTZlnA3EVmAzjJtfmrKlHpFTvmnnPboC2UHCEecpYrc3f9P1VuChqkFdVF0p G8nHlIc9bxDO77XYMCOH/zYgiHiVO3h8Bx5E7wAR/HnPzcVDRBR/auklbSnJ3vbS5Qap mnMWqcJ7ECev//K7elNxGOQd9T5IupWLyIZYuNAPMd3y6ok6Y9EPfpx57gc7kmRwiL4B XZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j4d9ty/C/iU3fVM+9p+3Cx8lB1h9V58eW85ndg8M1BY=; b=Lbq7a+evBjqFRmdA/7DI2XeXgjOtwXzmADVZzfHnYtVOtkQh6hDI5EEfka9vfr2f2k 5Yih0srtYj7xExKtNOQqB6Ywt4KAumHIxJP40RjUAbPSAyrJIKtZieFomPNX2mZWNkGO /ihUZNPFr1+dnSnJR2gUiU5PtVtvnJaOgqy+R5csxmTRI02hDgwYKcVFFKFL+Q2EFIBs u6IjN1+yJudqiyx/Nz+6Ou2ap/33GJs7UDkRGrE/91V1gVK4gLnzSEBdDcZsuHhSV/Mk OonVhCcVd172lUDyXRmep+/UYrMAiER1CI7PuJQao6OE3ielzoHBOCtestQihyM3od/w gkTg== X-Gm-Message-State: APjAAAW4zJAb6zKN/nWwQGOBsIt60wVzScO4LMzDHYNTTZ9XHtSxTTxY aYelfiK/yCZF+uBkmwdFnG7NtjIRg3vjioIS3W/VYg== X-Google-Smtp-Source: APXvYqzBJWTpUdQ2GhlPzXsXw6ayhzsAsdlECp0gIZfAkZ5N7Z8k4tj8k3ii0EyE4PiDQ4RVWou55iRsLJBnZAMWZWQ= X-Received: by 2002:a05:620a:103a:: with SMTP id a26mr25812546qkk.332.1567426412969; Mon, 02 Sep 2019 05:13:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 2 Sep 2019 17:43:21 +0530 Message-ID: Subject: Re: RE-SQL tests patch for packages node To: navnath gadakh Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008e92b8059190e6ff" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008e92b8059190e6ff Content-Type: text/plain; charset="UTF-8" Hi Navnath Following are the review comments: - GRANT statement is not visible in RE-SQL for create and alter both. (May be bug in Packages please fix that too) - Delete packages is missing in json file. - Add test cases to revoke privileges(delete all the privileges). Check Languages node for reference. On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh < navnath.gadakh@enterprisedb.com> wrote: > Hi Dave, > Please find the patch for M-SQL test cases for *Packages* module. > > Thanks! > > On Fri, Jul 12, 2019 at 4:02 PM Dave Page > wrote: > >> Thanks, applied. >> >> On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh < >> navnath.gadakh@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Please find the modified patch for packages as test cases were >>> failing on some servers. >>> Thanks! >>> >>> >>> On Thu, Jul 11, 2019 at 1:53 PM Dave Page >>> wrote: >>> >>>> Thanks, applied. >>>> >>>> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Navnath >>>>> >>>>> I have tested the patch and it is not working for EPAS 9.4, 9.5 and >>>>> 9.6. Attached is the modified patch which fix the issue. >>>>> Please work on child node (functions, procedure and variables) of >>>>> Packages on top of modified patch. >>>>> >>>>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh < >>>>> navnath.gadakh@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> I have attached the patch for RE-SQL test cases for *Packages* >>>>>> node. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> -- >>>>>> *Regards,* >>>>>> *Navnath Gadakh* >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >>> -- >>> *Regards,* >>> *Navnath Gadakh* >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > -- > *Regards,* > *Navnath Gadakh* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000008e92b8059190e6ff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Navnath

Following are the revie= w comments:
  • GRANT statement is not visible in RE-SQL for = create and alter both. (May be bug in Packages please fix that too)
    • Delete packages is missing in json file.
  • Add test cases to revoke = privileges(delete all the privileges). Check Languages node for reference.<= /li>

On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh <navnath.gadakh@enterprisedb.com= > wrote:
=
Hi Dave,
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0Please find the patch for=C2=A0M-SQL test cases for Packag= es module.

Thanks!
On Fri, = Jul 12, 2019 at 4:02 PM Dave Page <dave.page@enterprisedb.com> wrote:
Thank= s, applied.

On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh <navnath.gadakh@ent= erprisedb.com> wrote:
Hi Dave,

=C2=A0 =C2=A0 =C2=A0Please find the modified patch for packa= ges as test cases were failing on some servers.=C2=A0
Than= ks!


On Thu, Jul 11, 2019 at 1:53 PM Dave Page &l= t;dave.page= @enterprisedb.com> wrote:
Thanks, applied.

On Thu, Jul 11, 2019 at 8= :07 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Navna= th

I have tested the patch and it is not working for EPA= S 9.4, 9.5 and 9.6. Attached is the modified patch which fix the issue.=C2= =A0
Please work on child node (functions, procedure and variables= ) of Packages on top of modified patch.=C2=A0=C2=A0

On Wed, Jul 10, 20= 19 at 8:25 PM navnath gadakh <navnath.gadakh@enterprisedb.com> wrote:
=
Hi Dave,

=C2=A0 =C2=A0 I= have attached the patch for RE-SQL test cases for Packages node.
=C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
Thanks!

--
= Regards,
Navnath Gadakh
=


--
Thanks & Regards
Akshay Joshi
Sr. Soft= ware Architect
Enterpri= seDB Software India Private Limited
Mobile: +91 976-788-8= 246


--
Dave Page
= VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake


--
<= div dir=3D"ltr">
Regards,
Navnath Gadakh
=


--
Dave Page
VP, Chief Architect, Tools & Installers
Enterpr= iseDB: http://www= .enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake


--
Regards,
= Navnath Gadakh


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000008e92b8059190e6ff--