MIME-Version: 1.0
References: 
 <CAJ9T6Ss--gC0W-uRKj0BTr2+CWQYMGT3KB4iYv22yijSANdjmg@mail.gmail.com>
In-Reply-To: 
 <CAJ9T6Ss--gC0W-uRKj0BTr2+CWQYMGT3KB4iYv22yijSANdjmg@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 4 Feb 2021 11:54:26 +0530
Message-ID: 
 <CANxoLDedjgukXi-nEooKGF-MW5WidaEYBWmHKz2o+092GCKPkw@mail.gmail.com>
Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in
 Schema Diff.
To: Pradip Parkale <pradip.parkale@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000006ffd105ba7cc29b"
Precedence: bulk

--00000000000006ffd105ba7cc29b
Content-Type: text/plain; charset="UTF-8"

Hi Pradip

I haven't started reviewing your patch but seems you haven't written test
cases for schema diff. Please add and then submit the patch again.

On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale <
pradip.parkale@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for publication and subscription support in
> Schema Diff.
>
> Also, added the dependencies for publication and subscription.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--00000000000006ffd105ba7cc29b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Pradip<div><br></div><div>I haven&#39;t started re=
viewing your patch but seems you haven&#39;t written test cases for schema =
diff. Please add and then submit the patch again.</div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb 3, 2021 =
at 9:51 PM Pradip Parkale &lt;<a href=3D"mailto:pradip.parkale@enterprisedb=
.com">pradip.parkale@enterprisedb.com</a>&gt; wrote:<br></div><blockquote c=
lass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px soli=
d rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br><=
/div><div>Please find the attached patch for publication and subscription s=
upport in Schema Diff.</div><div><br></div><div>Also, added the dependencie=
s for publication and subscription.<br clear=3D"all"><div><br></div>-- <br>=
<div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-size:12.8px">Thanks &a=
mp; Regards,<br></div><div style=3D"font-size:12.8px">Pradip Parkale<br>Sof=
tware Engineer | EnterpriseDB Corporation</div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"lt=
r"><div dir=3D"ltr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span =
style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;borde=
r-collapse:collapse">Thanks &amp; Regards</span></b></font></div><div><font=
 color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,san=
s-serif;font-size:13px;border-collapse:collapse">Akshay Joshi</span></b></f=
ont></div><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);f=
ont-family:arial,sans-serif;font-size:13px;border-collapse:collapse">pgAdmi=
n Hacker | Principal Software Architect</span></b></font></div><font color=
=3D"#000000" face=3D"arial, sans-serif"><b><a href=3D"http://edbpostgres.co=
m" target=3D"_blank">EDB Postgres</a></b></font><br><div><b style=3D"color:=
rgb(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246<br></sp=
an></b><br></div></div></div></div></div></div></div>

--00000000000006ffd105ba7cc29b--