Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRx2S-0003xn-GQ for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 12:34:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kRx2R-0005uO-G8 for pgadmin-hackers@arkaria.postgresql.org; Mon, 12 Oct 2020 12:34:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRx2R-0005qy-53 for pgadmin-hackers@lists.postgresql.org; Mon, 12 Oct 2020 12:34:51 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kRx2N-0001tg-Rm for pgadmin-hackers@postgresql.org; Mon, 12 Oct 2020 12:34:50 +0000 Received: by mail-io1-xd34.google.com with SMTP id g7so17396690iov.13 for ; Mon, 12 Oct 2020 05:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TqP5Y+Z3yVDQB1Uq94u9F/6hAUBq2KQzhzycAkeUAE4=; b=A5Lr2iIem5azVPNSm3IoJ2CJd4K7ot4IlyCEm09VT5J/SfwLmGo4JlATCKJepMf3lR QHTI3R0Gt8wAhnlnCHEEOnExAy0uCZ+ZPYwWgpYwCStx4HK8FVn2s3fO/ZfIl/f2U9TU 7NsCGxtIv6sFnk5U+qZ0Vh3VqNZhOIIHVHEUQnFJnZTQKp8H6WITIp6TUFkt6y7viNF+ gJiHYNW3ojBsalgFarhckHAtx4L7uWJ27Wre7h5LArbT8roO79bB7CwkhWGLxbllrTlt YMTyFxGkvUrYsRY91CX65WZ0Q2BXamQTk0tRZl4ceuIOhtlt1gDpTap6Ge+S0GYmt0hW hPwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TqP5Y+Z3yVDQB1Uq94u9F/6hAUBq2KQzhzycAkeUAE4=; b=Vsjoi+ta4kDf5LfdgS2/icP4Ps4os5an8dj566UVhwm6zPmHmX6bozBaU881rf4S3O LSizips7YsVVkczkTPELeiqb02//yeolt3UA2rGaTsbf4qMADb9AWZWmALvxSjATPX81 Zbft3IwSjbFp2YHFyLTBZNRQRcFxZ2/X8v0B8yweJFxscyntadNvzBT+feiIfRux8kmv SIo5ZtfyMoTogbrbwe5cwxkrknowvNWq0nJxvGnMPTWwp2KisZY52Sat6W93sR7B8qaB UhQbu5UPmPdF3kySDfI+AtVah7FQjRALxLUDlTPrh+LJOmaY8950jXE5vObqTLTxd9AX vJeQ== X-Gm-Message-State: AOAM532d43FOd7yUdUAtdPVIXSxWOkN5fGbx0/0fHVm8uolow0pYiQig pZy38QB7W9porqfzohF0nv71/tR/hY91beAwRKAElIw9ht5FpRtsSwcNgE1le0aHtmTUwJg62DS W3p0XHV/waF1fqHwlORZ1xIbNv/kWSbqWcBH+xHJkFJZpJuQyhQej7AD+pPF929mK3ivalZgvwB mA4b5Z43j5+HrNZT6fx0litsVjxyKb6eLMlPmr8p8fBkNJa8kKzdBgEFseBA== X-Google-Smtp-Source: ABdhPJzaBeGvxZQ3qQUzADvuFcGuGUSL76pr1R/4WeKiDCJrHXbJs8Ava8MK6m1D6TOuQ9g1JTV6Ial8eZ40cmD6NOM= X-Received: by 2002:a05:6638:20a:: with SMTP id e10mr19952678jaq.20.1602506086039; Mon, 12 Oct 2020 05:34:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 12 Oct 2020 18:04:35 +0530 Message-ID: Subject: Re: [pgAdmin][RM4855] Renaming a file removes the file extension To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000002ea2005b1788631" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000002ea2005b1788631 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Oct 12, 2020 at 5:55 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to improve this further. It will skip adding the > extension if the file already has the extension selected from the format > dropdown. > Please review. > > On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Attached patch will add the .sql when saving a file and and format -> >>> sql selected, no matter what the file name is. >>> Please review. >>> >>> On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch to fix a bug where extension file extension is >>>>> stripped on renaming a file. >>>>> Pleasure review. >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Sr. Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000002ea2005b1788631 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Oct 12, 2020 at 5:55 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is a patc= h to improve this further. It will skip adding the extension if the file al= ready has the extension selected from the format dropdown.
Please review.<= /div>

On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
=
Thanks, patch applied.

On Thu, Oct 8, 2020 at 6:34 PM Adity= a Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,
=
=
Attached patch will add the .sql when saving a file and and f= ormat -> sql selected, no matter what the file name is.
Ple= ase review.

On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Thanks, patch applied.

On Mon, Sep 28, 20= 20 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wr= ote:
Hi Hackers,

Attached is the patch to fix a bug where extension file e= xtension is stripped on renaming a file.
Pleasure=C2=A0review.
--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0= | Sr. = Software Engineer | edbpostgres.co= m
"Don't Complain about Heat, Plant a TRE= E"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--00000000000002ea2005b1788631--