Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j51CD-0002Qt-P2 for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Feb 2020 05:49:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j51CC-0003ke-Hu for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Feb 2020 05:49:52 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j51CC-0003kU-3I for pgadmin-hackers@lists.postgresql.org; Fri, 21 Feb 2020 05:49:52 +0000 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j51C9-0005Nq-AJ for pgadmin-hackers@postgresql.org; Fri, 21 Feb 2020 05:49:50 +0000 Received: by mail-il1-x12a.google.com with SMTP id f10so708851ils.8 for ; Thu, 20 Feb 2020 21:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s+y6GpYP6KO0hgqUoSqpb/JPWGUeU0hGE9Zknef3UQU=; b=mj6TLffrIUzF5rVEAYvcILOiIlgVYrd4FNcAeQHQOWSiH9PiIk1t+O8c6xeZMMd2Me rdsEVNJ/fu+dpJocER61d8JL+yGPSywrUnADRTbpt8lyIkU1RmKz3A+IFe53CvgdK8ea pzE805hjZ8Ei1/BbjSDnnmiS+Sp5vOcKnd3IU7hirCbYglai42HPu+ncSpS6LhFCpthM nrLelNGvRkNThFLIeOYdYr2llhfZgZ8JiKV5cgYBNsDVrTl8vWzl0OghrXRa5tb8KXFq UWoq+yLn23oBNesR2VjuZmdAS3Xa65hPEG3+ZxjIaK6RaiVW+oCJgeaxvYvYIVrMeOcK Kflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s+y6GpYP6KO0hgqUoSqpb/JPWGUeU0hGE9Zknef3UQU=; b=bTqA8OWLZ7yPE0bj8uAI097Mlcd3ptr0PwPOD2HT5hCo4WDZlkGk/ZbRn2krzvr3Zy /9A0nz1jhsFwGTJR8O96kozKdQW+shmWZLH/fgTFSJf5JbOeUAXrMgC+y0lVOr2BuF3x 3eb3lSeBdGG1tS2faEHOIf9bP1AmuwoGnByORLLTnYOqSIedrx1SdauboikPDHXSu9eo AoVx4FmFPIpDjSF8y04+aY4/5tYPnoMHL01hAMailbcTVH2tI2WoDnNvoGTvOF+d5yAo fSfi/Jv4tM2G5x3jfES6eyBKlo/6ZKBpdi2e/9F8MddlAub6oa/LflL2jZPV14TSE9yM RsSA== X-Gm-Message-State: APjAAAXEXxHdV834ChtD2MRR74UnuYH+CulBkrpSdBnhPv89TVC/LNty p1wc3RtBbs3zF0sj+9NaNlbKTQ4mcBNx0PnC48i6ghcIgndJ2kUwCTNTw3eepgMkqBv63g2UnQ0 5LexQxczihe1faFu7oOQDOQFVOrUtmBMR6GTZYB+hLU05m+Sd/8FPgEUBDvyzGERuaNWaT9MkQl iVu9T5/FamvMNEfi3tnPDeq/8VJ7WpeGk3n2UrqgFf2ggKxWQXNew= X-Google-Smtp-Source: APXvYqyHZkUX0Enags3lGVsHnpsUdUMGB5fp5wRapWMpcqZ+QwL6muyQH4BJXC+PMRpnbb7d5ejtloGTD7uVFIMwrhc= X-Received: by 2002:a92:5845:: with SMTP id m66mr34562580ilb.257.1582264188360; Thu, 20 Feb 2020 21:49:48 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Fri, 21 Feb 2020 11:19:37 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Aditya Toshniwal Cc: Ashesh Vashi , pgadmin-hackers , Pradip Parkale Content-Type: multipart/alternative; boundary="000000000000e3756b059f0f96d0" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e3756b059f0f96d0 Content-Type: text/plain; charset="UTF-8" Hi Aditya Can you please review this patch. On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Please find the attached patch. > > On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Forgot to attach the patch? >> >> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch for accessibility issue related Alertifyjs. >>> >>> 1. Added hidden label to satisfy accessibility. >>> 2. Added label with sr-only class. >>> 3. Added tabindex to move the mouse control to the maximize button >>> using the tab key. >>> >>> >>> Please note that this patch also includes the fix for the >>> RM-5143 Accessibility issue to maximize the panel for backup and restore >>> windows and all other places. >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> -- >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000e3756b059f0f96d0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya

Can you please review this pa= tch.

On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <pradip.parkale@enterprisedb.com>= ; wrote:
Please find the attached patch.

On Wed, Feb 19, 2020 at 5:02 PM As= hesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Forgot to attach= the patch?

On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <pradip.par= kale@enterprisedb.com> wrote:
Hi Hackers,

Atta= ched=C2=A0is a patch=C2=A0for accessibility issue related Alertifyjs.
=
  1. Added hidden label to satisfy accessibility.
  2. Added= label with sr-only class.
  3. Added tabindex to move the mouse con= trol to the maximize button using the tab key.

=
Please note that this patch also includes the fix for the RM-514= 3=C2=A0Accessibility issue to maximize the panel for backup and restore win= dows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corp= oration
--

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000e3756b059f0f96d0--