public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Libor M. <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: pgAdmin 4 - next gettext usage fixes
Date: Wed, 15 Apr 2020 16:47:04 +0530
Message-ID: <CANxoLDeezR6piQbCMXw7QChLJXROQ0FFQpu9+1zyZTc1O03wNQ@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_mMS=oe0WzeU49Ox2utU_n2Nr4BXe0_2RkXt01acLQQUg@mail.gmail.com>
References: <CAMavuw0OE=bo6a3Pf+cXUTa0UDrFSyQxsffUrf5uXcvLnTSajg@mail.gmail.com>
<CANxoLDcg=Jpkj5+16KNgAG171mz1bSF-+oFLRb_B4KAEO8Lb4w@mail.gmail.com>
<CAM9w-_kyiCB-FFtkXpvUNYKsz2iauZcm-vDs30dgW7rXDdDD-A@mail.gmail.com>
<CANxoLDdedErpGjjAs0GgywptNGpn8DzeL7v6=CsYDG+Wt59cPw@mail.gmail.com>
<CAM9w-_mMS=oe0WzeU49Ox2utU_n2Nr4BXe0_2RkXt01acLQQUg@mail.gmail.com>
Thanks, patch applied.
On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi,
>
> Please find the updated patch.
>
> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Aditya
>>
>> I think the fix is incorrect. .format method should be applied after
>> gettext() like gettext().format(). Please check for other places too and
>> send the updated patch.
>>
>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers/Libor,
>>>
>>> The changes like below are incorrect. Try "Count rows" from a table's
>>> context menu.
>>>
>>> - info=gettext("Table rows counted: %s" % count),
>>>
>>> + info=gettext("Table rows counted: %s") % count,
>>>
>>> Attached is the patch to fix all such changes in pgAdmin, to use
>>> format() instead.
>>> Please review.
>>>
>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Libor
>>>>
>>>> Thanks, patch applied. Please make sure to run the PEP8 checks before
>>>> sending the patch.
>>>> I have fixed and committed the code.
>>>>
>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. <[email protected]> wrote:
>>>>
>>>>> Hello,
>>>>> I fixed next gettext usage:
>>>>>
>>>>> - fixed gettext usage with .format() only for original text with %s
>>>>> - fixed typos
>>>>> - fixed translation yes/no buttons in dialog
>>>>> - improved translating sentences without "connecting" words (eg. see
>>>>> web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' needs to
>>>>> be translated in Czech language as 'zrušit' but in another sentence as
>>>>> 'zrušení')
>>>>> - added gettext for text translations
>>>>>
>>>>> Diff file is attached.
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Libor M.
>>>>>
>>>>> E-mail: [email protected]
>>>>> GitHub: https://github.com/liborm85
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>>
>>>> *Sr. Software Architect*
>>>> *EnterpriseDB Software India Private Limited*
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgAdmin 4 - next gettext usage fixes
In-Reply-To: <CANxoLDeezR6piQbCMXw7QChLJXROQ0FFQpu9+1zyZTc1O03wNQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox