Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt0Y-0007EX-Se for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Feb 2019 05:10:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gqt0X-0004KI-6X for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Feb 2019 05:10:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt0W-0004KA-Fc for pgadmin-hackers@lists.postgresql.org; Tue, 05 Feb 2019 05:10:52 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqt0N-0002GU-JJ for pgadmin-hackers@postgresql.org; Tue, 05 Feb 2019 05:10:50 +0000 Received: by mail-qk1-x742.google.com with SMTP id q1so1356658qkf.13 for ; Mon, 04 Feb 2019 21:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9DrnMthPAxerCL5upTWc/eP7C3HMOX1Xw24UaYQ4JFw=; b=TtHqw8qzDZNwp/TJPI6YWnw5an/WLKq2tGcVRvBXcV2Opc4bsTevep+u4/JjlITRio wsZoSrvRPSyrWiWa7hL2H3UoOEw//Zm6FAYLOQE6U5NB1R5YcdDSsJisXe4Ixm31dhfX JyJ0JWquQnU0pdwjVDuy/cGAMCMs1GOMosYc0cXW6TVY8AsZ55lGfTu2+mzmUqtnkBtH ULycyuqHxqpn/1cf8Ac/fLWOtK3ytA2GZKB7+BopfyiV/GQRvxJCWobbwcycGXFoaSWC LB/NPwj0yi2xSXnmYAOZknJ3E4RsxhMDlI0KjIwcdrZcowH96ecOSxH0YtSX2RgwjPRe XGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9DrnMthPAxerCL5upTWc/eP7C3HMOX1Xw24UaYQ4JFw=; b=nSfXr0P3wyHN8d+/p9fuIs9ZJqdMVa3BGOOtitdIkZ5I4nCnt551f6kmrOaR+/HJMv 7gIqkFIchU+3T/ABsstXiey2YMi1NINMaVgbJJIWfW8hm+Cxhceo1WBdYLejqY6FAM+4 CHsHKZVzdJ4M8VZlyMwzaRIBGfTymHQqjkFJ0grJk2kAi5fv1BE6uNMud/KDkisv6wwz uooepwHd88z+vmNDw7VfNxpcmiv/VtP7a9R8zk9r0oX/np1eiUWI44MX+FMXvUVnZBYO byTNXuDAEleMJ8wM6rNpXbaCJUhG6OxQUPQmZCgbBoTC+a0sU83nN+LniCdc9UdgCaEY ztcw== X-Gm-Message-State: AHQUAubxO7r8EndHNZy2Tb3xE/OamNhg1AOeYIXgjfTZGzAz+N/cH/lW u0C+Ccy/Dk4hWK/dNFuGCJzo++ywNAyEsZVRE26/2y4n X-Google-Smtp-Source: AHgI3Ia1QeLeiQiSGowu37i5Uj37jTk1jErVla9pA14hbtVvztmUcy516Zw2wVLWtfcBb6lSh/iwC2qIcwRcLTVxDQw= X-Received: by 2002:a37:a42:: with SMTP id 63mr2141515qkk.269.1549343441160; Mon, 04 Feb 2019 21:10:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 5 Feb 2019 10:40:30 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3936] Feature tests failing intermittently for SQL editor related test cases To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000072235405811ea1be" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000072235405811ea1be Content-Type: text/plain; charset="UTF-8" Hi Aditya On Mon, Feb 4, 2019 at 2:18 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Akshay, > > I tried to simulate, but no luck. It works on my system :( > I have tried and Feature test are failing randomly for each run. I have verified it on OSX and Ubuntu both. > > On Wed, Jan 30, 2019 at 7:15 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> I have applied your patch but following test cases are failing >> consistently: >> >> - CopySelectedQueryResultsFeatureTest >> - QueryToolAutoCompleteFeatureTest >> >> I have verified your patch on Mac OSX and Ubuntu. Chrome Version >> 71.0.3578.98 >> >> On Tue, Jan 29, 2019 at 7:38 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, 29 Jan 2019, 19:09 Dave Page >> >>>> Akshay, can you look at this please? >>>> >>> >>> Sure. >>> >>>> >>>> On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal >>>> wrote: >>>> > >>>> > Hi Hackers, >>>> > >>>> > Attached is the updated patch. I have changed >>>> fill_input_by_field_name function to use javascript to set values of text >>>> boxes and the selector is changed from xpath to CSS with a :not(:disabled) >>>> clause. With this, test case will fail if tried to set the value of a >>>> disabled input. >>>> > >>>> > Kindly review. >>>> > >>>> > >>>> > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >> >>>> >> >>>> >> >>>> >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page wrote: >>>> >>> >>>> >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal >>>> >>> wrote: >>>> >>> > >>>> >>> > Hi Dave, >>>> >>> > >>>> >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page >>>> wrote: >>>> >>> >> >>>> >>> >> Hi >>>> >>> >> >>>> >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal >>>> >>> >> wrote: >>>> >>> >> > >>>> >>> >> > Hi Hackers, >>>> >>> >> > >>>> >>> >> > Attached is the patch to fix failing SQL editor related >>>> feature tests. >>>> >>> >> > The failure is occurring mostly because of send_keys function >>>> of selenium which sometimes does not input the complete text. The change >>>> will use Codemirror javascript object to set the text. >>>> >>> >> > >>>> >>> >> > I have also added new args flag "--modules" which can be used >>>> after --pkg where you can test a specific module file under the pkg. This >>>> is not so useful for build but definitely helpful for the developers. >>>> >>> >> >>>> >>> >> One of the most common failures I see is failure to fill in the >>>> >>> >> details on the Add Server dialogue (it might type half of an >>>> entry, >>>> >>> >> then just hang). Should we get rid of all uses of send_keys? >>>> >>> > >>>> >>> > Setting the text using javascript executor can be done. send_keys >>>> simulate an actual person, so if you try to set a disabled text box using >>>> send_keys, it won't. Places where disabled fields doesn't matter, send_keys >>>> can be removed. >>>> >>> >>>> >>> Can't we just do something like: >>>> >>> >>>> >>> if input.disabled == false: >>>> >>> input.value = 'Foo'; >>>> >>> else: >>>> >>> raise exception .... >>>> >> >>>> >> I'll check if this can be done. Will get back. >>>> >>> >>>> >>> >>>> >>> -- >>>> >>> Dave Page >>>> >>> Blog: http://pgsnake.blogspot.com >>>> >>> Twitter: @pgsnake >>>> >>> >>>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>>> >>> The Enterprise PostgreSQL Company >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Thanks and Regards, >>>> >> Aditya Toshniwal >>>> >> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> >> "Don't Complain about Heat, Plant a tree" >>>> > >>>> > >>>> > >>>> > -- >>>> > Thanks and Regards, >>>> > Aditya Toshniwal >>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>> > "Don't Complain about Heat, Plant a tree" >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000072235405811ea1be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

On Mon, Feb 4, 2019 at 2:18= PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

I tried = to simulate, but no luck. It works on my system :(
=

=C2=A0 =C2=A0I have tried and Feature test are failing = randomly for each run. I have verified it on OSX and Ubuntu both.=C2=A0=C2= =A0

On Wed, Jan 30, 2019= at 7:15 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
=
Hi=C2=A0Aditya

I have applied = your patch but following test cases are failing consistently:
  • CopySelectedQueryResultsFeatureTest
  • QueryToolAutoCompleteFeatu= reTest
    • I have verified your patch on Mac OSX and Ubuntu. Chrom= e=C2=A0Version 71.0.3578.98
    =
    On Tue= , Jan 29, 2019 at 7:38 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wr= ote:


    On Tue, 29 = Jan 2019, 19:09 Dave Page <dpage@pgadmin.org wrote:
    Akshay, can you look at this please?

    =C2=A0 =C2=A0 = Sure.

    On Tue, Jan 29, 2019 at 1:36 PM Aditya Toshniwal
    <aditya.toshniwal@enterprisedb.com> wrote:
    >
    > Hi Hackers,
    >
    > Attached is the updated patch. I have changed fill_input_by_field_name= function to use javascript to set values of text boxes and the selector is= changed from xpath to CSS with a :not(:disabled) clause. With this, test c= ase will fail if tried to set the value of a disabled input.
    >
    > Kindly review.
    >
    >
    > On Mon, Jan 28, 2019 at 5:44 PM Aditya Toshniwal <ad= itya.toshniwal@enterprisedb.com> wrote:
    >>
    >>
    >>
    >> On Mon, Jan 28, 2019 at 5:39 PM Dave Page <dpage@pgadmin.org= > wrote:
    >>>
    >>> On Mon, Jan 28, 2019 at 12:05 PM Aditya Toshniwal
    >>> <aditya.toshniwal@enterprisedb.com>= wrote:
    >>> >
    >>> > Hi Dave,
    >>> >
    >>> > On Mon, Jan 28, 2019 at 5:01 PM Dave Page <dpage@pgadmi= n.org> wrote:
    >>> >>
    >>> >> Hi
    >>> >>
    >>> >> On Mon, Jan 28, 2019 at 7:00 AM Aditya Toshniwal
    >>> >> <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
    >>> >> >
    >>> >> > Hi Hackers,
    >>> >> >
    >>> >> > Attached is the patch to fix failing SQL editor = related feature tests.
    >>> >> > The failure is occurring mostly because of send_= keys function of selenium which sometimes does not input the complete text.= The change will use Codemirror javascript object to set the text.
    >>> >> >
    >>> >> > I have also added new args flag "--modules&= quot; which can be used after --pkg where you can test a specific module fi= le under the pkg. This is not so useful for build but definitely helpful fo= r the developers.
    >>> >>
    >>> >> One of the most common failures I see is failure to f= ill in the
    >>> >> details on the Add Server dialogue (it might type hal= f of an entry,
    >>> >> then just hang). Should we get rid of all uses of sen= d_keys?
    >>> >
    >>> > Setting the text using javascript executor can be done. s= end_keys simulate an actual person,=C2=A0 so if you try to set a disabled t= ext box using send_keys, it won't. Places where disabled fields doesn&#= 39;t matter, send_keys can be removed.
    >>>
    >>> Can't we just do something like:
    >>>
    >>> if input.disabled =3D=3D false:
    >>>=C2=A0 =C2=A0input.value =3D 'Foo';
    >>> else:
    >>>=C2=A0 =C2=A0raise exception ....
    >>
    >> I'll check if this can be done. Will get back.
    >>>
    >>>
    >>> --
    >>> Dave Page
    >>> Blog:     http://pgsnake.blogspot.com
    >>> Twitter: @pgsnake
    >>>
    >>> EnterpriseDB UK: http://www.enterprisedb.com
    >>> The Enterprise PostgreSQL Company
    >>
    >>
    >>
    >> --
    >> Thanks and Regards,
    >> Aditya Toshniwal
    >> Software Engineer | EnterpriseDB Software Solutions | Pune
    >> "Don't Complain about Heat, Plant a tree"
    >
    >
    >
    > --
    > Thanks and Regards,
    > Aditya Toshniwal
    > Software Engineer | EnterpriseDB Software Solutions | Pune
    > "Don't Complain about Heat, Plant a tree"



    --
    Dave Page
    Blog:     http://pgsnake.blogspot.com
    Twitter: @pgsnake

    EnterpriseDB UK: http://www.enterprisedb.com
    The Enterprise PostgreSQL Company


    --
    Akshay Joshi
    Sr. Software Architect <= br>


    =
    Pho= ne: +91 20-3058-9517
    Mobile: +91 976-788-8246


    --
    Thanks and Regards,
    Aditya Toshniwal
    Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
    "Don't Complain about Heat, Plant a tr= ee"


    --
    Akshay Joshi
    Sr. S= oftware Architect
    =

    Phone: +91 20-3058-9517
    Mobile: +91 976-788-8246    =
    --00000000000072235405811ea1be--