Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiZnG-00045S-1j for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 07:35:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiZnE-0007Hg-TW for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 07:35:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiZnE-0007Az-D9 for pgadmin-hackers@lists.postgresql.org; Wed, 03 Jul 2019 07:35:04 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiZnB-0001Ho-I5 for pgadmin-hackers@postgresql.org; Wed, 03 Jul 2019 07:35:03 +0000 Received: by mail-qk1-x741.google.com with SMTP id m14so1349033qka.10 for ; Wed, 03 Jul 2019 00:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ST1pre3aQggKZ/KApYrlcN+e2MvNYSN+hvKtCxBMC/I=; b=Jci1RehVKKn/gBmfAsWrGPz07wEQQMzdvdsaJGUzzg0thLxmqJJlfzN0H4aiNiAr5+ C7AVMYmnA+8xHgJBsb/3RG/8ptLQsDgaxpc8fA4XOrsukRx1l9ObHDw6PDatcjjHWon2 49Rsal+0dMirT4ne/5T0xWQKU0iyiRBou/NugFafFDL68fkzs9bqg/05Xak6u5jgG3dX nYjoD2AwUe4DvZTZ8YkjHzbf+tLqdS6m5X89LgamUlmfLteJ216+DHUp4Aw5Val9basA W321V5FnYa5TjIDYKZSfhn9c3Mo9blnoesD9DXMyhlx/yoHNAK/IQNRqLsJWyOaI0C8d 231A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ST1pre3aQggKZ/KApYrlcN+e2MvNYSN+hvKtCxBMC/I=; b=XOfff67L1dwlrWzpPaAJpuC7UWkUixQoFvs7HeC1saclUQvb/9cOys09bgACJnoqb4 vWD2PXLADkYtNxzMRVEDCA/lfyZfTvwCzR5gsTF4ciLxynM1ss2KJdEm+qT9fj8cwbq0 IhZGWwXpZRBLBlSgymZe4VBKMZ6D/fTbxZ/heWzUR8arUzNwG9La861S7DFsvBnbN2r4 7UJydPgg9OoOAuNVXWIh2nNsJVWZ0Q7Am7kx4ZP11qkhjxn9678L3Rb8KtF0wHuESxCd /co4p5SUMYVztR6z8JPs89B9LvOs9eMyVzSXUZ+oWJk6fQrLMVzWe+PH5dEcJS/0anNu +pRA== X-Gm-Message-State: APjAAAWindmlrHEF7U2GukbVg2QQe/hxddkTJohXBTPXTqaHO1VhA9xU InYU7vIhIqnk1DTn7tdTo+IydOOWVczVKhWfZ7EfSA== X-Google-Smtp-Source: APXvYqyE2C5l6fxpiBQV9AmSjc9axQl059QLYeN7JkmAEKl1ghmwH9Bnt1PoZEuq3o3ISc+R2nSeg/kBxuwJliBE8z8= X-Received: by 2002:ae9:e30d:: with SMTP id v13mr28834246qkf.148.1562139299667; Wed, 03 Jul 2019 00:34:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 3 Jul 2019 13:04:48 +0530 Message-ID: Subject: Re: RE-SQL tests for Roles & Resource Group nodes To: Murtuza Zabuawala Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000bff50058cc1e6b0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000bff50058cc1e6b0 Content-Type: text/plain; charset="UTF-8" Hi Murtuza I have tested the patch and I think below string should be modified: Server(Type: #ppas) is not supported for the Resource Groups module - Skipped Server version(120000) is not supported for the Resource Groups module - Skipped It misleads, that server type 'ppas' is not supported for the Resource Group, it should be changed to "Resource groups are not supported by PG - Skipped". Similarly for version string should be ''Resource groups are not supported by PPAS server less/greater than " Apart from the above code looks good to me. On Wed, Jul 3, 2019 at 9:23 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > Please note that our framework considers test cases from all the modules > as one single test case, If we need module wise detailed summary report for > the reverse engineered SQL tests then we may have to change the framework. > > > Regards, > Murtuza > > > On Tue, Jul 2, 2019 at 5:52 PM Dave Page wrote: > >> Hi >> >> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> ++ Attaching patch >>> >>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find the updated patch, >>>> >>>> - Added a mechanism to check for supported minimum/maximum version and >>>> a server type in the framework. >>>> >>> >> There's still a problem with this I'm afraid - it says in the summary >> that the re_sql test cases were all skipped, which is not the case. I think >> we should just skip the irrelevant tests in the re_sql module, but not mark >> the entire module as being skipped: >> > >> =============Running the test cases for 'Regression - PG 11'============= >> >> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >> >> Reverse Engineered SQL Test Cases >> >> >> Create IMPLICIT Cast >> >> Alter IMPLICIT Cast >> >> Drop IMPLICIT Cast >> >> Create EXPLICIT Cast >> >> Alter EXPLICIT Cast >> >> Drop EXPLICIT Cast >> >> ... skipped 'Server(Type: #ppas) is not supported for the Resource >> Groups module' >> >> >> ---------------------------------------------------------------------- >> >> Ran 1 test in 0.480s >> >> >> OK (skipped=1) >> >> >> ====================================================================== >> >> Test Result Summary >> >> ====================================================================== >> >> >> Regression - PG 11: >> >> >> 0 tests passed >> >> 0 tests failed >> >> 1 test skipped: >> >> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >> >> >> ====================================================================== >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000000bff50058cc1e6b0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Murtuza

I have tested the patch= and I think below string should be modified:
Server(Type: #= ppas) is not supported for the Resource Groups module - Skipped
Se= rver version(120000) is not supported for the Resource Groups module - Skip= ped

It misleads, that server type 'ppas= 9; is not supported for the Resource Group, it should be changed to "R= esource groups are not supported by PG - Skipped". Similarly for versi= on string should be ''Resource groups are not supported by PPAS ser= ver less/greater than <server version>"

Apart from the above code looks good to me.

On Wed, Jul 3, 2019 at 9:= 23 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:<= br>
Hi Dave,

PFA updated patch.

Please note that our framework considers test cases from all the modules a= s one single test case, If we need module wise detailed=C2=A0summary report= for the reverse engineered SQL tests then we may have to change the framew= ork.


Regards,
Murtuza


On Tue, Jul 2, 2019 at 5= :52 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, Jul 2, 2019 at 8:17 AM Mu= rtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
++ Attaching patch

On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabua= wala <murtuza.zabuawala@enterprisedb.com> wrote:
<= div style=3D"font-family:verdana,sans-serif;color:rgb(68,68,68)">Hi Dave,

<= /div>
Plea= se find the updated patch,

- Added a mechanism to check for supported mini= mum/maximum version and a server type in the framework.

There's still a= problem with this I'm afraid - it says in the summary that the re_sql = test cases were all skipped, which is not the case. I think we should just = skip the irrelevant tests in the re_sql module, but not mark the entire mod= ule as being skipped:
=

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunn= ing the test cases for 'Regression - PG 11'=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D

runTest (regression.re_sql.tests.test_resql= .ReverseEngineeredSQLTestCases)

Reverse Engineered SQL Test Cases


Create IMPLICIT Cast

Alter IMPLICIT Cast

Drop IMPLICIT Cast

Create EXPLICIT Cast

Alter EXPLICIT Cast

Drop EXPLICIT Cast

=C2=A0... skipped= 'Server(Type: #ppas) is not supported for the Resource Groups module&#= 39;


-------------------------------------------= ---------------------------

Ran 1 test in 0.480s


OK (skipped=3D1)


=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D

Test Result Summary

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D


Regression - PG 11:


= 0 tests passed

= 0 tests failed

= 1 test skipped:

= ReverseEngineere= dSQLTestCases (Reverse Engineered SQL Test Cases)


Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company


--
=
Thanks & Reg= ards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited=
Mobile: +91 976-788-8246
--0000000000000bff50058cc1e6b0--