Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZpYfq-0004lN-JU for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Oct 2015 09:30:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZpYfo-0004Dj-Qj for pgadmin-hackers@arkaria.postgresql.org; Fri, 23 Oct 2015 09:30:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZpYfm-0004Cs-Tx for pgadmin-hackers@postgresql.org; Fri, 23 Oct 2015 09:30:07 +0000 Received: from mail-ob0-x234.google.com ([2607:f8b0:4003:c01::234]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZpYfh-0007gh-Hx for pgadmin-hackers@postgresql.org; Fri, 23 Oct 2015 09:30:04 +0000 Received: by obbwb3 with SMTP id wb3so89431584obb.0 for ; Fri, 23 Oct 2015 02:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=W8cijalv11w159wGmSJzqJTCmiBhIerfH4zM0CDMFbA=; b=f3QnRrOlA7+4b0dJIrQpvEd3gQLEKS6R206wHAOIg4cNNFzLgcPACymY1Fde1kLL6j lG/gAp3Nmp/xndETqdpHwvLYf5IB6xH7tEA/j7UNSC5TkuxBlOf/Pr5K38nxyZGE5NgA dNnAVIUnWoqpelQbqBIM7Lkfjgn2gx/w6b7WovizaNyALdD6j9YScm0agPoxjAhC6cFp OvFiW3xo1Bs6C3c0T40hwGi1OHjyzstf9xzwwwCjuKD2Ug4Zlx7edY6L3lMGSejtZuDf KNCkeGlmm0B3iESN+237aJ8+5c1iIAEeJLhkEzNC8rN7bmZOQxOJSnx2ULYyuIFaGDx+ sbgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=W8cijalv11w159wGmSJzqJTCmiBhIerfH4zM0CDMFbA=; b=mNFPh2FqpKknDMcbwcY5c/gX2Q8l3f/q+hMeUR63dt3uFFHCCT+tlQ1njR2YqlsKTv MFAReOTau1HdFN90Q38lv4h/T5JEMRhWqmKT8Zzy5g4jYBHIG1i0O0a2PZQal5tHAXgR 13+JXCOz1I19sFgKrbIYWPf8GMwnvTae5Z0Z15zVIRmoHWgvQSiA6N0F+O0GABh/+zPN IsQutvqSADkyqOZt7+8IGcvZQ42LtzyQ+LaYddIX8oLEe+qPczOVo9H/qd1R3OIXY0se IF7VrItSeQu4YjGwm44q0CEg49XXUDcGa6wIw84WnQOUCZ1VbFiZXeJtXtXao5GH5ZU1 xb8w== X-Gm-Message-State: ALoCoQkrXM23RBTh9YOLC5OKx6/eLeN76jeQ8aCXW/fxHel+JEEiypSAjnm4dTi0SXYlbZKmMR8I MIME-Version: 1.0 X-Received: by 10.60.125.8 with SMTP id mm8mr14788316oeb.73.1445592599453; Fri, 23 Oct 2015 02:29:59 -0700 (PDT) Received: by 10.202.73.150 with HTTP; Fri, 23 Oct 2015 02:29:59 -0700 (PDT) In-Reply-To: References: <1444887919111-5870044.post@n5.nabble.com> Date: Fri, 23 Oct 2015 14:59:59 +0530 Message-ID: Subject: Re: [pgadmin-support] Error about inherited table of column in pgadmin1.20.0 From: Akshay Joshi To: Ashesh Vashi Cc: pgadmin-support , JasmineLiu , pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b339b21617fdb0522c2419f X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b339b21617fdb0522c2419f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ashesh On Fri, Oct 23, 2015 at 1:27 PM, Ashesh Vashi wrote: > On Fri, Oct 16, 2015 at 5:40 PM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Ashesh >> > Hi Akshay, > > I've modified the patch a little bit for betterment. > Can you please review and test it? > Patch looks good to me. I have tested it, works fine. > > -- > Thanks & Regards, > Ashesh Vashi > >> >> >> On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi > .com> wrote: >> >>> On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu >>> wrote: >>> >>>> Hi, all ! >>>> >>>> This is Liu Yuanyuan. >>>> I find the inherited table of column shown in pgadmin 1.20.0, sometime= s >>>> isn=E2=80=99t right. That should be a bug. >>>> Hope someone to do something about this problem! >>>> Here is my example: >>>> >>>> First I execute the following sql in pgadmin 1.20.0 by query tool: >>>> create schema test; >>>> create table test.a1(id int); >>>> create table test.a2(id int, name varchar); >>>> create table test.a3(age int); >>>> create table test.aa() inherits(test.a1,test.a2,test.a3); >>>> >>>> >>>> Then in main view of pgadmin 1.20.0=EF=BC=9A >>>> It shows the column age is inherited from table test.a2, this is not >>>> right. >>>> >>>> >>>> >>> Looks like a bug to me. >>> >>> Akshay, >>> >>> Can you please take a look at it? >>> >> >> I have fixed the issue, attached is the patch file. Can you please >> review it and if it looks good can you please commit the code. >> >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> >>>> >>>> I also check the code of pgadmin 1.20.0, I think the method to specify >>>> the >>>> inherited table of columns is not correct,especially when the inherite= d >>>> tables have same column. >>>> >>>> Thanks and hope to hear from you soon! >>>> >>>> Best wishes! >>>> Liu Yuanyuan >>>> >>>> >>>> >>>> >>>> -- >>>> View this message in context: >>>> http://postgresql.nabble.com/Error-about-inherited-table-of-column-in-= pgadmin1-20-0-tp5870044.html >>>> Sent from the PostgreSQL - pgadmin support mailing list archive at >>>> Nabble.com. >>>> >>>> >>>> -- >>>> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-support >>>> >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > --=20 *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --047d7b339b21617fdb0522c2419f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Ashesh

On Fri, Oct 23, 2015 at 1:27 PM, Ashesh Vashi &l= t;ashesh= .vashi@enterprisedb.com> wrote:
On Fri, Oct 16, 2015 at 5:40 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Ashesh
<= div>Hi Akshay,

I've modified the patch a little bit f= or betterment.
Can you please review and test it?

=C2=A0 =C2=A0Patch looks g= ood to me. I have tested it, works fine.

--
Thanks & Regards,
Ashesh Vashi


On Thu, Oct 15, 2015 at 1:51 PM, Ashesh V= ashi <ashesh.vashi@ente= rprisedb.com> wrote:
On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu <liuyuanyuangogo@gmail.com> wrote:
Hi, all !

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn=E2=80=99t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0=EF=BC=9A
It shows the column age is inherited from table test.a2, this is not right.=
<http://postgresql.nabble.com/file/n5870044/1.jpg= >
<http://postgresql.nabble.com/file/n5870044/2.jpg= >
Looks like a bug to me.

A= kshay,

Can you please take a look at it?
<= /div>

=C2=A0 =C2=A0I have fixed the = issue, attached is the patch file. Can you please review it and if it looks= good can you please commit the code.=C2=A0
<= div class=3D"gmail_quote">

--

Thanks & Regards,

= Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL= Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi

= =C2=A0

I also check the code of pgadmin 1.20.0, I think the method to specify the<= br> inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inheri= ted-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.c= om.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support=




--
Akshay Joshi


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246




--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--047d7b339b21617fdb0522c2419f--