Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gbFoi-0006JB-BK for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Dec 2018 02:18:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gbFog-00048i-MM for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Dec 2018 02:18:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gbFof-00042W-OZ for pgadmin-hackers@lists.postgresql.org; Mon, 24 Dec 2018 02:18:02 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gbFoW-00085B-Ci for pgadmin-hackers@postgresql.org; Mon, 24 Dec 2018 02:17:59 +0000 Received: by mail-qt1-x844.google.com with SMTP id n32so11897519qte.11 for ; Sun, 23 Dec 2018 18:17:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5lwdmxhZm8B1QzsdSRXWrZZCxdZvcLYeb4xqG8fh5o=; b=Pefuhchz5kY/j+WKLpXPazjQnNOnpblCp1ENab/Pc06x1740l2rhb6MY2+nK52iuuc o7EMvYKRkMdc271b5x5TOzBGcYAJ6R4f6TFAAm7qAuhUcG/bU3VCRUeK77eHeURYzG+Q ydeKI6+WGnlTdVIeLG48/GcUgmCd/2Y2IbvRywcfaqIF8zRF8f1s7tGI7YPPDW3RHesa 2FsJp00SJnJ23ZTxffan7DUbqUfG+VKlo29qzDdcY4BEy2ADk6s02C+w7NynROhz4zx9 sIM5oL8ixLpSnnlcJPSz1tf1z6aX1INe6WtgSbF56YUD/5xs1HEqKlUaFZW4J+cUSFhJ QUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5lwdmxhZm8B1QzsdSRXWrZZCxdZvcLYeb4xqG8fh5o=; b=OCiVvVA7IaftAdAzZlTQESmI5PUeiPVW5n/56DU99XLmprCgz6LtkvWiw4JYaqAzRV KSYmnFNHxVAc5GZ/bNMpnM/yItAh9fTrkjEGpTIDzWW6mNqZ8oGVU8x4MNUsdunuLupL nwA14nZvjCfyw0sA9RP1KTPjxOcErZiNQlFj1+dwnby8hmXMhCXCHeADyevQHsMV+GwF qVI7TCwccT5ADuRCnH9evRDIMsIi/FnxKdIovioCyjDc1zSz5hidms6u/eujHINyUUxZ 8p4m6Dvysmzhp1fL0pABioEAefMSNvCHolrtccbYp6VsbpWN8wZoVHoK5PvIHMgNhAK7 kCrw== X-Gm-Message-State: AA+aEWZ8qWCw09Wz25Wi0TVTVPzIaMB8eB+xSpnwJiOnMsjXX7SelSUK CcxS7SGx3Zs91bFjjCL+yiKtOr4VESPOn/WWV8MENg== X-Google-Smtp-Source: AFSGD/XhmGz9MOFwQ6wQciQ1d5wdPEdcORBkyWR55SIH1LblRDpngb7hQZyqpOrEtPHeSLSJVG+2SIiJACcItL5h9FE= X-Received: by 2002:ac8:3618:: with SMTP id m24mr10427780qtb.210.1545617870909; Sun, 23 Dec 2018 18:17:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 24 Dec 2018 07:47:37 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000278777057dbb34ab" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000278777057dbb34ab Content-Type: text/plain; charset="UTF-8" On Fri, 21 Dec 2018, 19:45 Dave Page > > On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >> >> On Fri, 21 Dec 2018, 18:52 Dave Page > >>> Hi >>> >>> Looks good - I just found one issue; please go ahead and commit (with a >>> release notes update) when fixed. >>> >>> - If I set the NULL replacement value to an empty string, it defaults >>> back to NULL. It's therefore not possible to replace null values with an >>> empty value. >>> >> >> If you remember this is the default behaviour of the Preferences >> dialog. It sets the default value again if you set the blank value. Fahar >> has raised the same issue before and we have rejected that. If you think we >> can create the new RM for that behaviour and will commit the current patch. >> > > Well, we rejected it for a specific case. In this specific case, it makes > sense to be able to enter a blank value. > > Maybe we just need an "allow blank" flag on the preference object, that > does nothing except allow you to remove the default (or any other) value > without it being replaced again? Obviously the default still needs to work > until a value is written to the config DB. > Ok. If i understand correctly this new parameter works for all the preference parameter if set to true. By default it's value is False and if user wants to enter blank value they will ser the flag. > > >> >>> Thanks! >>> >>> On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Dave >>>> >>>> I have modified the condition, it won't through any exception. Attached >>>> is the updated patch, please review it. >>>> >>>> On Fri, Dec 21, 2018 at 4:22 AM Dave Page wrote: >>>> >>>>> Sorry! Here is is. >>>>> >>>>> On Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave >>>>>> >>>>>> Can you please attached the updated patch with your changes. I'll try >>>>>> to fix the exception. >>>>>> >>>>>> On Fri, Dec 21, 2018 at 3:57 AM Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> Here's an updated patch as I've tweaked some of the wording. The >>>>>>> screenshot probably isn't the right resolution, but as we're replacing them >>>>>>> anyway it doesn't seem overly important. Feel free to fix if you like :-) >>>>>>> >>>>>>> With quoting set to either All or Strings, everything looks good. >>>>>>> With it set to None, I still get an exception (below). The query I'm using >>>>>>> is this: >>>>>>> >>>>>>> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text >>>>>>> >>>>>>> Field separator: , >>>>>>> Quote character: " >>>>>>> Replace null's with: NULL >>>>>>> >>>>>>> Steps: >>>>>>> >>>>>>> 1) Run pgAdmin in Desktop mode. I'm running from within PyuCharms, >>>>>>> using the venv detailed below. >>>>>>> 2) Open the Query Tool on a PostgreSQL 9.6.10 database, running on >>>>>>> MacOS 10.14.1 >>>>>>> 3) Run the above query, wit quoting set to All and check the result >>>>>>> in the grid. >>>>>>> 4) Download the CSV file and check. >>>>>>> 5) Open Preferences and set quoting to Strings. >>>>>>> 6) Download the CSV file and check. >>>>>>> 7) Open Preferences and set quoting to None. >>>>>>> 8) Download the CSV file *exception occurs*. >>>>>>> >>>>>>> >>>>>>> System info: >>>>>>> >>>>>>> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ python --version >>>>>>> >>>>>>> Python 3.6.7 >>>>>>> >>>>>>> (pgadmin4) dpage@hal:*~/git/pgadmin4*$ pip freeze >>>>>>> >>>>>>> alabaster==0.7.11 >>>>>>> >>>>>>> alembic==1.0.0 >>>>>>> >>>>>>> asn1crypto==0.24.0 >>>>>>> >>>>>>> Babel==2.6.0 >>>>>>> >>>>>>> bcrypt==3.1.4 >>>>>>> >>>>>>> blinker==1.4 >>>>>>> >>>>>>> certifi==2018.8.24 >>>>>>> >>>>>>> cffi==1.11.5 >>>>>>> >>>>>>> chardet==3.0.4 >>>>>>> >>>>>>> chromedriver-installer==0.0.6 >>>>>>> >>>>>>> click==6.7 >>>>>>> >>>>>>> cryptography==2.3 >>>>>>> >>>>>>> docutils==0.14 >>>>>>> >>>>>>> extras==1.0.0 >>>>>>> >>>>>>> fixtures==3.0.0 >>>>>>> >>>>>>> Flask==0.12.4 >>>>>>> >>>>>>> Flask-BabelEx==0.9.3 >>>>>>> >>>>>>> Flask-Gravatar==0.5.0 >>>>>>> >>>>>>> Flask-HTMLmin==1.3.2 >>>>>>> >>>>>>> Flask-Login==0.3.2 >>>>>>> >>>>>>> Flask-Mail==0.9.1 >>>>>>> >>>>>>> Flask-Migrate==2.1.1 >>>>>>> >>>>>>> Flask-Paranoid==0.2.0 >>>>>>> >>>>>>> Flask-Principal==0.4.0 >>>>>>> >>>>>>> Flask-Security==3.0.0 >>>>>>> >>>>>>> Flask-SQLAlchemy==2.3.2 >>>>>>> >>>>>>> Flask-WTF==0.14.2 >>>>>>> >>>>>>> html5lib==1.0.1 >>>>>>> >>>>>>> htmlmin==0.1.12 >>>>>>> >>>>>>> idna==2.7 >>>>>>> >>>>>>> imagesize==1.1.0 >>>>>>> >>>>>>> itsdangerous==0.24 >>>>>>> >>>>>>> Jinja2==2.10 >>>>>>> >>>>>>> linecache2==1.0.0 >>>>>>> >>>>>>> Mako==1.0.7 >>>>>>> >>>>>>> MarkupSafe==1.0 >>>>>>> >>>>>>> packaging==18.0 >>>>>>> >>>>>>> paramiko==2.4.1 >>>>>>> >>>>>>> passlib==1.7.1 >>>>>>> >>>>>>> pbr==3.1.1 >>>>>>> >>>>>>> psutil==5.4.8 >>>>>>> >>>>>>> psycopg2==2.7.5 >>>>>>> >>>>>>> pyasn1==0.4.4 >>>>>>> >>>>>>> pycodestyle==2.3.1 >>>>>>> >>>>>>> pycparser==2.18 >>>>>>> >>>>>>> pycrypto==2.6.1 >>>>>>> >>>>>>> Pygments==2.2.0 >>>>>>> >>>>>>> PyNaCl==1.2.1 >>>>>>> >>>>>>> pyparsing==2.2.2 >>>>>>> >>>>>>> pyperclip==1.6.4 >>>>>>> >>>>>>> pyrsistent==0.14.2 >>>>>>> >>>>>>> python-dateutil==2.7.3 >>>>>>> >>>>>>> python-editor==1.0.3 >>>>>>> >>>>>>> python-mimeparse==1.6.0 >>>>>>> >>>>>>> pytz==2018.3 >>>>>>> >>>>>>> requests==2.19.1 >>>>>>> >>>>>>> selenium==3.14.1 >>>>>>> >>>>>>> simplejson==3.13.2 >>>>>>> >>>>>>> six==1.11.0 >>>>>>> >>>>>>> snowballstemmer==1.2.1 >>>>>>> >>>>>>> speaklater==1.3 >>>>>>> >>>>>>> Sphinx==1.8.2 >>>>>>> >>>>>>> sphinxcontrib-websupport==1.1.0 >>>>>>> >>>>>>> SQLAlchemy==1.2.10 >>>>>>> >>>>>>> sqlparse==0.2.4 >>>>>>> >>>>>>> sshtunnel==0.1.4 >>>>>>> >>>>>>> testscenarios==0.5.0 >>>>>>> >>>>>>> testtools==2.3.0 >>>>>>> >>>>>>> traceback2==1.4.0 >>>>>>> >>>>>>> unittest2==1.1.0 >>>>>>> >>>>>>> urllib3==1.23 >>>>>>> >>>>>>> webencodings==0.5.1 >>>>>>> >>>>>>> Werkzeug==0.14.1 >>>>>>> >>>>>>> WTForms==2.1 >>>>>>> >>>>>>> Exception: >>>>>>> >>>>>>> 2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) >>>>>>> for server #2 - CONN:8760231 (Query-id: 8649354): >>>>>>> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text >>>>>>> 2018-12-21 11:47:29,001: INFO werkzeug: 127.0.0.1 - - [21/Dec/2018 >>>>>>> 11:47:29] "GET >>>>>>> /sqleditor/query_tool/download/2133388?query=SELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=data-1545392848979.csv >>>>>>> HTTP/1.1" 500 - >>>>>>> 2018-12-21 11:47:29,003: ERROR werkzeug: Error on request: >>>>>>> Traceback (most recent call last): >>>>>>> File >>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >>>>>>> line 270, in run_wsgi >>>>>>> execute(self.server.app) >>>>>>> File >>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >>>>>>> line 260, in execute >>>>>>> for data in application_iter: >>>>>>> File >>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py", >>>>>>> line 870, in __next__ >>>>>>> return self._next() >>>>>>> File >>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wrappers.py", >>>>>>> line 82, in _iter_encoded >>>>>>> for item in iterable: >>>>>>> File >>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py", >>>>>>> line 848, in gen >>>>>>> csv_writer.writerows(results) >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line >>>>>>> 761, in writerows >>>>>>> return self.writer.writerows(map(self._dict_to_list, rowdicts)) >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line >>>>>>> 268, in writerows >>>>>>> self.writerow(row) >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line >>>>>>> 261, in writerow >>>>>>> row = [self.strategy.prepare(field, only=only) for field in row] >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line >>>>>>> 261, in >>>>>>> row = [self.strategy.prepare(field, only=only) for field in row] >>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line >>>>>>> 142, in prepare >>>>>>> raise Error('No escapechar is set') >>>>>>> _csv.Error: No escapechar is set >>>>>>> >>>>>>> On Thu, Dec 20, 2018 at 1:05 PM Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave >>>>>>>> >>>>>>>> On Thu, Dec 20, 2018 at 5:12 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Dec 20, 2018 at 4:48 PM Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Thu, Dec 20, 2018 at 10:09 AM Akshay Joshi < >>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Dave >>>>>>>>>>> >>>>>>>>>>> On Thu, Dec 20, 2018 at 3:08 PM Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi >>>>>>>>>>>> >>>>>>>>>>>> When testing with quoting set to None, quote = " and delimiter >>>>>>>>>>>> = , I get the following exception when I try to download: >>>>>>>>>>>> >>>>>>>>>>>> 2018-12-20 09:34:02,547: SQL pgadmin: Execute (with server >>>>>>>>>>>> cursor) for server #2 - CONN:354106 (Query-id: 4121147): >>>>>>>>>>>> SELECT NULL::text, 1234::int, 'Foo bar'::text, E'Foo\nBar'::text >>>>>>>>>>>> 2018-12-20 09:34:02,570: INFO werkzeug: 127.0.0.1 - - >>>>>>>>>>>> [20/Dec/2018 09:34:02] "GET >>>>>>>>>>>> /sqleditor/query_tool/download/5610522?query=SELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=data-1545298442530.csv >>>>>>>>>>>> HTTP/1.1" 500 - >>>>>>>>>>>> 2018-12-20 09:34:02,572: ERROR werkzeug: Error on request: >>>>>>>>>>>> Traceback (most recent call last): >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >>>>>>>>>>>> line 270, in run_wsgi >>>>>>>>>>>> execute(self.server.app) >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", >>>>>>>>>>>> line 260, in execute >>>>>>>>>>>> for data in application_iter: >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py", >>>>>>>>>>>> line 870, in __next__ >>>>>>>>>>>> return self._next() >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wrappers.py", >>>>>>>>>>>> line 82, in _iter_encoded >>>>>>>>>>>> for item in iterable: >>>>>>>>>>>> File >>>>>>>>>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py", >>>>>>>>>>>> line 820, in gen >>>>>>>>>>>> csv_writer.writerows(results) >>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", >>>>>>>>>>>> line 748, in writerows >>>>>>>>>>>> return self.writer.writerows(map(self._dict_to_list, >>>>>>>>>>>> rowdicts)) >>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", >>>>>>>>>>>> line 256, in writerows >>>>>>>>>>>> self.writerow(row) >>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", >>>>>>>>>>>> line 249, in writerow >>>>>>>>>>>> row = [self.strategy.prepare(field, only=only) for field in >>>>>>>>>>>> row] >>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", >>>>>>>>>>>> line 249, in >>>>>>>>>>>> row = [self.strategy.prepare(field, only=only) for field in >>>>>>>>>>>> row] >>>>>>>>>>>> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", >>>>>>>>>>>> line 136, in prepare >>>>>>>>>>>> raise Error('No escapechar is set') >>>>>>>>>>>> _csv.Error: No escapechar is set >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Not able to reproduce the above issue. I have tested it with >>>>>>>>>>> the same setting as you mentioned. Please refer all the attached >>>>>>>>>>> screenshots. Please specify the steps if they are different. >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> When I have quoting set to All, the first column is returned as >>>>>>>>>>>> "" >>>>>>>>>>>> >>>>>>>>>>>> dpage@hal:*~/Downloads*$ more data-1545298598112.csv >>>>>>>>>>>> >>>>>>>>>>>> "text","int4","text-2","text-3" >>>>>>>>>>>> >>>>>>>>>>>> "","1234","Foo bar","Foo >>>>>>>>>>>> >>>>>>>>>>>> Bar" >>>>>>>>>>>> >>>>>>>>>>>> Isn't the point for it to be NULL? >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> while quoting is set to ALL, all the data types has been >>>>>>>>>>> quoted, so I thought null values should be replaced by "" instead of blank. >>>>>>>>>>> But if you think null values shouldn't be quoted even if user select quote >>>>>>>>>>> ALL, I'll fix it and resend the patch. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> So how would you distinguish NULL from an empty string? Isn't >>>>>>>>>> that exactly what the bug is about? >>>>>>>>>> >>>>>>>>>> I still think we need a "Replace NULLs with" config option, and >>>>>>>>>> regardless of quoting settings we always replace NULL values with whatever >>>>>>>>>> that is set to - for which the user could then choose options like: >>>>>>>>>> >>>>>>>>>> NULL >>>>>>>>>> "NULL" >>>>>>>>>> "" >>>>>>>>>> '' >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> We would never quote the NULL replacement value - if the user >>>>>>>>>> wanted it to be quoted, they would include the quotes in the configured >>>>>>>>>> string. >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> OK, Will work on it and send the modified patch again. >>>>>>>>> >>>>>>>> >>>>>>>> Attached is the modified patch as per your suggestion. >>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On Tue, Dec 18, 2018 at 11:13 AM Akshay Joshi < >>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Dave >>>>>>>>>>>>> >>>>>>>>>>>>> Attached is the modified patch to fix review comments. >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Dec 18, 2018 at 3:00 PM Akshay Joshi < >>>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, Dec 18, 2018 at 2:49 PM Dave Page >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi < >>>>>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Hackers, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Attached is the patch to fix RM #3780 pgAdmin4 lacks >>>>>>>>>>>>>>>> ability to specify NULL values in CSV export. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Please review it. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> A few points; >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - You've included code from backports.csv, but per the >>>>>>>>>>>>>>> licence you need to include a description of the changes made. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Sure. In that case I'll copy the complete file and will >>>>>>>>>>>>>> do my changes which is of two lines only. With my patch I have remove all >>>>>>>>>>>>>> the unwanted code from backport.csv. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Shouldn't backports.csv be removed from requirements.txt, >>>>>>>>>>>>>>> or is it used elsewhere? >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Yes. Will do that. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - If the previous point is true, then I'm fairly sure there >>>>>>>>>>>>>>> is code in one or more of the many package build scripts that adds an >>>>>>>>>>>>>>> __init__.py file to backports.csv in the venv that's created. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> I'll remove that code as well. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Dave Page >>>>>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>>> >>>>>>>>>>>>>> *Sr. Software Architect * >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>> >>>>>>>>>>>>> *Sr. Software Architect * >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Dave Page >>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>> >>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>> >>>>>>>>>>> *Sr. Software Architect * >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Akshay Joshi* >>>>>>>>> >>>>>>>>> *Sr. Software Architect * >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Akshay Joshi* >>>>>>>> >>>>>>>> *Sr. Software Architect * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect * >>>>>> >>>>>> >>>>>> >>>>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --000000000000278777057dbb34ab Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Fri, 21 Dec 2018, 19:45 Dave Page <dpage@pgadmin.org wrote:


On Fri, Dec 21, 2018 at 2:08 PM Akshay Joshi <a= kshay.joshi@enterprisedb.com> wrote:


On Fri, 21 Dec 2018, 18:52 Dave Page <dpage@p= gadmin.org wrote:
Hi

Looks good - I just found one = issue; please go ahead and commit (with a release notes update) when fixed.=

- If I set the NULL replacement value to an empty= string, it defaults back to NULL. It's therefore not possible to repla= ce null values with an empty value.

=C2=A0 =C2=A0 If you remember th= is is the default behaviour of the Preferences dialog. It sets the default = value again if you set the blank value. Fahar has raised the same issue bef= ore and we have rejected that. If you think we can create the new RM for th= at behaviour and will commit the current patch.

Well, we rejected it for a specific case. In this specific= case, it makes sense to be able to enter a blank value.

Maybe we just need an "allow blank" flag on the preference= object, that does nothing except allow you to remove the default (or any o= ther) value without it being replaced again? Obviously the default still ne= eds to work until a value is written to the config DB.=C2=A0

= =C2=A0 =C2=A0 Ok. If i understand correctly this new parameter works for al= l the preference parameter if set to true. By default it's value is Fal= se and if user wants to enter blank value they will ser the flag.
=C2=A0

Thanks!

On Fri, Dec 21, 2018 at 12:57 PM Akshay Joshi <= akshay.joshi@enterprisedb.com> wrote:
Hi= Dave

I have modified the condition, it won't = through any exception. Attached is the updated patch, please review it.

On Fri, Dec 21= , 2018 at 4:22 AM Dave Page <dpage@pgadmin.org> wrote:<= br>
Sorry! Here is is.

On= Fri, Dec 21, 2018 at 12:12 PM Akshay Joshi <aksha= y.joshi@enterprisedb.com> wrote:
Hi Dave

Can you please attached the updated patch with your changes. I'= ;ll try to fix the exception.

On Fri, Dec 21, 2018 at 3:57 AM Dave Page <d= page@pgadmin.org> wrote:
Hi

Here's an updated patch as I've twea= ked some of the wording. The screenshot probably isn't the right resolu= tion, but as we're replacing them anyway it doesn't seem overly imp= ortant. Feel free to fix if you like :-)

With quot= ing set to either All or Strings, everything looks good. With it set to Non= e, I still get an exception (below). The query I'm using is this:
=

SELECT NULL::text, 1234::int, 'Foo bar'::text, = E'Foo\nBar'::text

Field separator: ,
Quote character: "
Replace null's with: NULL

Steps:

1) Run pgAdmin in De= sktop mode. I'm running from within PyuCharms, using the venv detailed = below.
2) Open the Query Tool on a PostgreSQL 9.6.10 database, ru= nning on MacOS 10.14.1
3) Run the above query, wit quoting set to= All and check the result in the grid.
4) Download the CSV file a= nd check.
5) Open Preferences and set quoting to Strings.
6) Download the CSV file and check.
7) Open Preferences and se= t quoting to None.
8) Download the CSV file *exception occurs*.


System info:

(pga= dmin4) dpag= e@hal:~/git/pgadmin4$ python --version

Pyth= on 3.6.7

(pga= dmin4) dpag= e@hal:~/git/pgadmin4$ pip freeze

alab= aster=3D=3D0.7.11

alem= bic=3D=3D1.0.0

asn1= crypto=3D=3D0.24.0

Babe= l=3D=3D2.6.0

bcry= pt=3D=3D3.1.4

blin= ker=3D=3D1.4

cert= ifi=3D=3D2018.8.24

cffi= =3D=3D1.11.5

char= det=3D=3D3.0.4

chro= medriver-installer=3D=3D0.0.6

clic= k=3D=3D6.7

cryp= tography=3D=3D2.3

docu= tils=3D=3D0.14

extr= as=3D=3D1.0.0

fixt= ures=3D=3D3.0.0

Flas= k=3D=3D0.12.4

Flas= k-BabelEx=3D=3D0.9.3

Flas= k-Gravatar=3D=3D0.5.0

Flas= k-HTMLmin=3D=3D1.3.2

Flas= k-Login=3D=3D0.3.2

Flas= k-Mail=3D=3D0.9.1

Flas= k-Migrate=3D=3D2.1.1

Flas= k-Paranoid=3D=3D0.2.0

Flas= k-Principal=3D=3D0.4.0

Flas= k-Security=3D=3D3.0.0

Flas= k-SQLAlchemy=3D=3D2.3.2

Flas= k-WTF=3D=3D0.14.2

html= 5lib=3D=3D1.0.1

html= min=3D=3D0.1.12

idna= =3D=3D2.7

imag= esize=3D=3D1.1.0

itsd= angerous=3D=3D0.24

Jinj= a2=3D=3D2.10

line= cache2=3D=3D1.0.0

Mako= =3D=3D1.0.7

Mark= upSafe=3D=3D1.0

pack= aging=3D=3D18.0

para= miko=3D=3D2.4.1

pass= lib=3D=3D1.7.1

pbr= =3D=3D3.1.1

psut= il=3D=3D5.4.8

psyc= opg2=3D=3D2.7.5

pyas= n1=3D=3D0.4.4

pyco= destyle=3D=3D2.3.1

pycp= arser=3D=3D2.18

pycr= ypto=3D=3D2.6.1

Pygm= ents=3D=3D2.2.0

PyNa= Cl=3D=3D1.2.1

pypa= rsing=3D=3D2.2.2

pype= rclip=3D=3D1.6.4

pyrs= istent=3D=3D0.14.2

pyth= on-dateutil=3D=3D2.7.3

pyth= on-editor=3D=3D1.0.3

pyth= on-mimeparse=3D=3D1.6.0

pytz= =3D=3D2018.3

requ= ests=3D=3D2.19.1

sele= nium=3D=3D3.14.1

simp= lejson=3D=3D3.13.2

six= =3D=3D1.11.0

snow= ballstemmer=3D=3D1.2.1

spea= klater=3D=3D1.3

Sphi= nx=3D=3D1.8.2

sphi= nxcontrib-websupport=3D=3D1.1.0

SQLA= lchemy=3D=3D1.2.10

sqlp= arse=3D=3D0.2.4

ssht= unnel=3D=3D0.1.4

test= scenarios=3D=3D0.5.0

test= tools=3D=3D2.3.0

trac= eback2=3D=3D1.4.0

unit= test2=3D=3D1.1.0

urll= ib3=3D=3D1.23

webe= ncodings=3D=3D0.5.1

Werk= zeug=3D=3D0.14.1

WTFo= rms=3D=3D2.1


Exception:

2018-12-21 11:47:28,995: SQL pgadmin: Execute (with server cursor) for server #2 - CONN:8760231 (Query-id: 864= 9354):
SELECT NULL::text, 1234::int, 'Foo bar'::text, E&#= 39;Foo\nBar'::text
2018-12-21 11:47:29,001: INFO werkzeug: 127.0.0.1 - - [21/Dec/2018 11:47:29] "GET /sqleditor/quer= y_tool/download/2133388?query=3DSELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%= 2C%20%27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filenam= e=3Ddata-1545392848979.csv HTTP/1.1" 500 -
2018-12-21 11:47:= 29,003: ERROR werkzeug: Error on request:
Traceback = (most recent call last):
=C2=A0 File "/Users/dpage/.virtuale= nvs/pgadmin4/lib/python3.6/site-packages/werkzeug/serving.py", line 27= 0, in run_wsgi
=C2=A0 =C2=A0 execute(self.server.app)
= =C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-pac= kages/werkzeug/serving.py", line 260, in execute
=C2=A0 =C2= =A0 for data in application_iter:
=C2=A0 File "/Users/dpage/= .virtualenvs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py", l= ine 870, in __next__
=C2=A0 =C2=A0 return self._next()
= =C2=A0 File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-pac= kages/werkzeug/wrappers.py", line 82, in _iter_encoded
=C2= =A0 =C2=A0 for item in iterable:
=C2=A0 File "/Users/dpage/g= it/pgadmin4/web/pgadmin/utils/driver/psycopg2/connection.py", line 848= , in gen
=C2=A0 =C2=A0 csv_writer.writerows(results)
= =C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py",= line 761, in writerows
=C2=A0 =C2=A0 return self.writer.writerow= s(map(self._dict_to_list, rowdicts))
=C2=A0 File "/Users/dpa= ge/git/pgadmin4/web/pgadmin/utils/csv.py", line 268, in writerows
=C2=A0 =C2=A0 self.writerow(row)
=C2=A0 File "/Users/d= page/git/pgadmin4/web/pgadmin/utils/csv.py", line 261, in writerow
=C2=A0 =C2=A0 row =3D [self.strategy.prepare(field, only=3Donly) for= field in row]
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pg= admin/utils/csv.py", line 261, in <listcomp>
=C2=A0 = =C2=A0 row =3D [self.strategy.prepare(field, only=3Donly) for field in row]=
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/cs= v.py", line 142, in prepare
=C2=A0 =C2=A0 raise Error('N= o escapechar is set')
_csv.Error: No escapechar is set
<= /div>
On Thu, Dec 20, 2018 a= t 1:05 PM Akshay Joshi <akshay.joshi@enterprisedb.= com> wrote:
Hi=C2=A0Dave

On Thu, Dec 20, 2018 at 5:12 PM Akshay Joshi &l= t;akshay.joshi@enterprisedb.com> wrote:


On Th= u, Dec 20, 2018 at 4:48 PM Dave Page <dpage@pgadmin.org>= ; wrote:
Hi

On Thu, Dec= 20, 2018 at 10:09 AM Akshay Joshi <akshay.joshi@e= nterprisedb.com> wrote:
Hi Dave

On Thu, Dec 20, 2018 at 3:08 PM Dave Pag= e <dpage@pgadmin.org> wrote:
Hi
<= br>
When testing with quoting set to None, quote =3D " and d= elimiter =3D , I get the following exception when I try to download:
<= div>
2018-12-20 09:34:02,547: SQL pgadmin: = Execute (with server cursor) for server #2 - CONN:354106 (Query-id: 4121147= ):
SELECT NULL::text, 1234::int, 'Foo bar'::text, E'F= oo\nBar'::text
2018-12-20 09:34:02,570: INFO werkzeug: = 127.0.0.1 - - [20/Dec/2018 09:34:02] "GET /sqleditor/query_tool= /download/5610522?query=3DSELECT%20NULL%3A%3Atext%2C%201234%3A%3Aint%2C%20%= 27Foo%20bar%27%3A%3Atext%2C%20E%27Foo%5CnBar%27%3A%3Atext&filename=3Dda= ta-1545298442530.csv HTTP/1.1" 500 -
2018-12-20 09:34:02,572= : ERROR werkzeug: Error on request:
Traceback (most = recent call last):
=C2=A0 File "/Users/dpage/.virtualenvs/pg= admin4/lib/python3.6/site-packages/werkzeug/serving.py", line 270, in = run_wsgi
=C2=A0 =C2=A0 execute(self.server.app)
=C2=A0 = File "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/w= erkzeug/serving.py", line 260, in execute
=C2=A0 =C2=A0 for = data in application_iter:
=C2=A0 File "/Users/dpage/.virtual= envs/pgadmin4/lib/python3.6/site-packages/werkzeug/wsgi.py", line 870,= in __next__
=C2=A0 =C2=A0 return self._next()
=C2=A0 F= ile "/Users/dpage/.virtualenvs/pgadmin4/lib/python3.6/site-packages/we= rkzeug/wrappers.py", line 82, in _iter_encoded
=C2=A0 =C2=A0= for item in iterable:
=C2=A0 File "/Users/dpage/git/pgadmin= 4/web/pgadmin/utils/driver/psycopg2/connection.py", line 820, in gen
=C2=A0 =C2=A0 csv_writer.writerows(results)
=C2=A0 File = "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py", line 748, i= n writerows
=C2=A0 =C2=A0 return self.writer.writerows(map(self._= dict_to_list, rowdicts))
=C2=A0 File "/Users/dpage/git/pgadm= in4/web/pgadmin/utils/csv.py", line 256, in writerows
=C2=A0= =C2=A0 self.writerow(row)
=C2=A0 File "/Users/dpage/git/pga= dmin4/web/pgadmin/utils/csv.py", line 249, in writerow
=C2= =A0 =C2=A0 row =3D [self.strategy.prepare(field, only=3Donly) for field in = row]
=C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/util= s/csv.py", line 249, in <listcomp>
=C2=A0 =C2=A0 row = =3D [self.strategy.prepare(field, only=3Donly) for field in row]
= =C2=A0 File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/csv.py",= line 136, in prepare
=C2=A0 =C2=A0 raise Error('No escapecha= r is set')
_csv.Error: No escapechar is set
=

=C2=A0 =C2=A0 Not able to reproduce = the above issue. I have tested it with the same setting as you mentioned. P= lease refer all the attached screenshots. Please specify the steps if they = are different.

When I have quoting s= et to All, the first column is returned as ""

dpage@hal:~/Downloads= $ more data-1545298598112.csv=C2=A0

"text","int4&qu= ot;,"text-2","text-3"

"","1234",= "Foo bar","Foo

Bar"


Isn't the point = for it to be NULL?

=C2=A0 =C2=A0 while quoting is set to ALL, all the data types has bee= n quoted, so I thought null values should be replaced by "" inste= ad of blank. But if you think null values shouldn't be quoted even if u= ser select quote ALL, I'll fix it and resend the patch.

So how would you distinguish NULL from a= n empty string? Isn't that exactly what the bug is about?
I still think we need a "Replace NULLs with" config o= ption, and regardless of quoting settings we always replace NULL values wit= h whatever that is set to=C2=A0 - for which the user could then choose opti= ons like:

NULL
"NULL"
""
''
<empty string>

We would never quote the NULL replacement value - if the u= ser wanted it to be quoted, they would include the quotes in the configured= string.


= =C2=A0 =C2=A0OK, Will work on it and send the modified patch again.=C2=A0

=C2=A0 =C2=A0 =C2=A0 Attac= hed is the modified patch as per your suggestion.=C2=A0
=C2=A0
<= div class=3D"gmail_quote">

On Tu= e, Dec 18, 2018 at 11:13 AM Akshay Joshi <akshay.j= oshi@enterprisedb.com> wrote:
Hi=C2=A0Dave

Attac= hed is the modified patch to fix review comments.

On Tue, Dec 18, 2018 at 3:00 PM Akshay Jo= shi <akshay.joshi@enterprisedb.com> wrote:<= br>


On Tue, Dec 18, 2018 at 2:49 PM Dave Page <dpage@pgadmin.org<= /a>> wrote:
<= div dir=3D"ltr">Hi

Hi Hackers,

<= /div>
Attached is the patch to fix RM #3780=C2=A0pgAdmin4 lacks ability= to specify NULL values in CSV export.

Pleas= e review it.

A few points= ;

- You've included code from backports.csv, b= ut per the licence you need to include a description of the changes made.

=C2=A0 =C2=A0 =C2=A0 Sure.= In that case I'll copy the complete file and will do my changes which = is of two lines only. With my patch I have remove all the unwanted code fro= m backport.csv.=C2=A0 =C2=A0 =C2=A0=C2=A0

=
- Shouldn't backports.csv be removed from requirements.txt, = or is it used elsewhere?

= =C2=A0 =C2=A0 =C2=A0Yes. Will do that.=C2=A0
<= br>
- If the previous point is true, then I'm fairly sure the= re is code in one or more of the many package build scripts that adds an __= init__.py file to backports.csv in the venv that's created.
=

=C2=A0 =C2=A0 I'll remove that c= ode as well.=C2=A0=C2=A0
=C2=A0
-- =
Da= ve Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Akshay Joshi
Sr. Sof= tware Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246<= /b>


--
Akshay Joshi
Sr. Software Architect

<= font color=3D"#3333FF">
=
Phone: +91= 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company


--
Akshay Joshi
Sr. Software= Architect

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Pag= e
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnak= e

EnterpriseDB UK: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company


--
Akshay Joshi<= /span>
Sr. Software Architect


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246


--
Akshay Joshi
Sr. Software Archite= ct

=


--
Dave Page
Blo= g: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enter= prise PostgreSQL Company


--
Akshay Joshi
Sr. Software= Architect

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.c= om
The Enterprise PostgreSQL Company


--
Akshay Joshi=
Sr. Software Architect


<= b>Phone: +91 20-3058-9517
Mobile: +91 976-788= -8246


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http:= //pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company
--000000000000278777057dbb34ab--