Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gk2Z6-0004Yn-5q for pgadmin-hackers@arkaria.postgresql.org; Thu, 17 Jan 2019 07:58:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gk2Z4-0003Kw-8S for pgadmin-hackers@arkaria.postgresql.org; Thu, 17 Jan 2019 07:58:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gk2Z3-0003Kp-Sm for pgadmin-hackers@lists.postgresql.org; Thu, 17 Jan 2019 07:58:14 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gk2Z1-00005i-Iy for pgadmin-hackers@lists.postgresql.org; Thu, 17 Jan 2019 07:58:13 +0000 Received: by mail-qk1-x744.google.com with SMTP id o125so5508115qkf.3 for ; Wed, 16 Jan 2019 23:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5kw7GDq7WnCCVin3WLezIOJ9UpIDiPUZifFzBSdzzX4=; b=ri6u5z/SeXX0MbX+2Fw/DjX1Q3NInrCmJGvYWQQEk382q0lg4Ne/VsmGbq2B1Pag4/ WwHgS7YLxRgSGhsJQgS1f4k79+m0P/5QdHcXKhkNBfKKh7Q45fQYX663GcXcgXL4p1D9 Dx2KFUneVuNuNVWE72Woa2hT5Q9qA7z/q4LxL2PNygusG/R3EkQuk2FHXfZOO3VFi+/c n6/+dM9gUW5pKflO9RO/urBqwOZ+ybP7g9Cw7bhXW1o8mQ6C/vUvukAKAodOdw3d/VOF RCkCTQgz/FoPvMLzK6ENaZiarsNYPGiLFeOpqkt7nAT+yw6cHY384VAvKx4bOZ4qpKbV H8oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5kw7GDq7WnCCVin3WLezIOJ9UpIDiPUZifFzBSdzzX4=; b=awYopztpp14N8r1Y9SqQJhxTz5P+i533UcYk8lQLrpCKMZj/MVZ2j+3pDA7DpaAzMO DKm4/HNWtuLQLaHyd5SZ+8gkS+cCzmNUidYspnk+yFHSB6QOf1wXoKY4jEc9BZ0DqNIP W99lccexgpa8s/dR0SagGtWDAsU5UOFU8oIXFGp8mbCUWOKT+iKwoL5+Adjqw2n1ZNwl ygAYDbl7n9fygO6eSjAsBZFc5/vp8AbBwo0VgcHcPdE4B0St0PMf+x3VWSkkRuQAZ7GJ Njb8Myeh2z1wFIH8Z6+kjVwkdQbkf2FFT3kkEedcDQbBuAHSs5ha7TSsxtIpLL6TLkzZ GCTQ== X-Gm-Message-State: AJcUukeRhhfahcofADK/yQYvdx5A7EfBF/N0oQLh5vvR6DB8NelJVJPv YJdSfVKEWsyZN/NoFjxOlZrxcIbq7HGDmx5JuxOwDQ== X-Google-Smtp-Source: ALg8bN7i2OQmThodi7YlcHa+Qz32bmaNZF/YoW/rBZlxWea2FI5fFhP6W+jJKWgFn3mKnvwGojk2A1FB4De2238x+oM= X-Received: by 2002:a37:8307:: with SMTP id f7mr9709554qkd.4.1547711889472; Wed, 16 Jan 2019 23:58:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 17 Jan 2019 13:27:58 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Improvement in the look and feel of the whole applica To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000631b89057fa2c1a9" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000631b89057fa2c1a9 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Thu, Jan 17, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the small patch (and probably the final for this mail chain) > to accommodate the changes suggested in previous mail. > > Kindly review. > > On Wed, Jan 16, 2019 at 8:30 PM Dave Page > wrote: > >> >> >> On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks patch applied without Tree Changes. >>> >>> On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal >> enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for further design improvements: >>>> - Process watcher made fixed width with header changes, time details >>>> rounded to 2 decimals >>>> - Query history will show "No query history" if no query fired. Query >>>> editor default size increased. >>>> - Tree improvements - right bold border removed completely. Now click >>>> anywhere on a tree item to perform actions. Please note, single click on >>>> the tiny tree arrow button will not work with this. Clicking anywhere is >>>> more useful than this. >>>> >>> @Dave Should we proceed with this behaviour, I haven't commit it. >>> >> >> I like the blue bit, so that should come back. >> >> I would say that a single-click on the arrow should open/close the node, >> whilst a double-click on the icon or label should open/close it. >> >> >>> - Fixed a bug where New folder create button not working when in List >>>> mode and No files/folder present. >>>> - Other minor improvements. >>>> >>>> Kindly review. >>>> >>>> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch for few more changes: >>>>> - New Folder button was not working in file dialogue. Fixed that. >>>>> - Color, icon changes in file dialogue >>>>> - Also replaced the splash screen image (which is used on main >>>>> dashboard also). It works fine on dashboard. However, I'm not sure of the >>>>> splash screen as the new image is SVG and older was PNG. I have made >>>>> changes for that in runtime code but I'm not able to test (evnvironment >>>>> issue) runtime code :(. It would be helpful if someone else can try it once. >>>>> >>>>> Kindly review. >>>>> >>>>> >>>>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page wrote: >>>>> >>>>>> Thanks - applied! >>>>>> >>>>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal >>>>>> wrote: >>>>>> > >>>>>> > Hi Hackers, >>>>>> > >>>>>> > Attached is the patch to incorporate the changes discussed in >>>>>> trailing mail(s). >>>>>> > >>>>>> > Kindly review. >>>>>> > >>>>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page wrote: >>>>>> >> >>>>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >>>>>> >> wrote: >>>>>> >> > >>>>>> >> > Hi, >>>>>> >> > >>>>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page >>>>>> wrote: >>>>>> >> >> >>>>>> >> >> Hi >>>>>> >> >> >>>>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >> >>> >>>>>> >> >>> Hi Dave, >>>>>> >> >>> >>>>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page >>>>>> wrote: >>>>>> >> >>>> >>>>>> >> >>>> >>>>>> >> >>>> A few other things that I noticed (or have been bugging me): >>>>>> >> >>>> >>>>>> >> >>>> - The menu bar seems a little cramped. Taking pg-navbar from >>>>>> 32 to 40px and setting the font-weight to normal on the menu options (but >>>>>> not the product name) seems much better to me (and adjusting everything >>>>>> else as required of course). >>>>>> >> >>> >>>>>> >> >>> Giving too much space for the navbar will reduce the usable >>>>>> space for other things. It is good enough(32) to be used easily, and is >>>>>> equal to all the other headers in app (including tabs) giving a feel of >>>>>> native desktop application. You'll find even smaller menu heights in native >>>>>> desktop application. We can make font weight to normal and may be slightly >>>>>> increase horizontal spacing between the menu links. >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> 8 pixels isn't going to make a noticeable difference to the >>>>>> workspace for users, and would leave the bar smaller than the 50px it's >>>>>> been for the last couple of years (iirc). I think it needs it to avoid >>>>>> looking cramped - please make the change. >>>>>> >> > >>>>>> >> > Will do. >>>>>> >> > One more doubt regarding bold headers, should I remove bold >>>>>> headers in dashboard graph header, subnode headers (eg.table->columns), >>>>>> properties tab accrordian headers ? >>>>>> >> >>>>>> >> No, please don't. I left them bold and the styling seemed like it >>>>>> >> worked. We can tweak again if others disagree later. >>>>>> >> >>>>>> >> Thanks! >>>>>> >> >>>>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as >>>>>> well. >>>>>> >> >>>>>> >> >>>> >>>>>> >> >>>> - In the file dialogue, the column headers don't line up with >>>>>> the columns in the rows. >>>>>> >> >>> >>>>>> >> >>> I could not see this on my machine (screenshot attached). >>>>>> Could you please share the screenshot. >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >>>>>> >> >> >>>>>> >> >> -- >>>>>> >> >> Dave Page >>>>>> >> >> Blog: http://pgsnake.blogspot.com >>>>>> >> >> Twitter: @pgsnake >>>>>> >> >> >>>>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> >> >> The Enterprise PostgreSQL Company >>>>>> >> > >>>>>> >> > >>>>>> >> > >>>>>> >> > -- >>>>>> >> > Thanks and Regards, >>>>>> >> > Aditya Toshniwal >>>>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> >> > "Don't Complain about Heat, Plant a tree" >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> -- >>>>>> >> Dave Page >>>>>> >> Blog: http://pgsnake.blogspot.com >>>>>> >> Twitter: @pgsnake >>>>>> >> >>>>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> >> The Enterprise PostgreSQL Company >>>>>> > >>>>>> > >>>>>> > >>>>>> > -- >>>>>> > Thanks and Regards, >>>>>> > Aditya Toshniwal >>>>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> > "Don't Complain about Heat, Plant a tree" >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>> "Don't Complain about Heat, Plant a tree" >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --000000000000631b89057fa2c1a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Thu, Jan 17, 2019 at 11:59 AM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the sm= all patch (and probably the final for this mail chain) to accommodate the c= hanges suggested in previous mail.

Kindly review.

On Wed, Jan 16, 2019 at 8:30 PM Dav= e Page <= dave.page@enterprisedb.com> wrote:


<= div class=3D"gmail_quote">
On Wed, Jan 16, 2019 at 6:29 AM = Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks patch ap= plied without Tree Changes.

On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Atta= ched is the patch for further design improvements:
- Process watcher made fixed width with header c= hanges, time details rounded to 2 decimals
- Query history will show "No query history" i= f no query fired. Query editor default size increased.
- Tree improvements - right bold border remo= ved completely. Now click anywhere on a tree item to perform actions. Pleas= e note, single click on the tiny tree arrow button will not work with this.= Clicking anywhere is more useful than this.
= =C2=A0@Dave=C2=A0=C2=A0Should we proceed with this behaviour, I haven't= commit it.=C2=A0

I like = the blue bit, so that should come back.

I would sa= y that a single-click on the arrow should open/close the node, whilst a dou= ble-click on the icon or label should open/close it.
=C2=A0
=
- Fixed a bug wher= e New folder create button not working when in List mode and No files/folde= r present.
- Other minor= improvements.

Kindly review.
On Mon, Jan 7, 2019 at 3:17 P= M Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for few more changes:
- New Folder button was not working in file di= alogue. Fixed that.
- Co= lor, icon changes in file dialogue
- Also replaced the splash screen image (which is used on main d= ashboard also). It works fine on dashboard. However, I'm not sure of th= e splash screen as the new image is SVG and older was PNG. I have made chan= ges for that in runtime code but I'm not able to test (evnvironment iss= ue) runtime code :(. It would be helpful if someone else can try it once.

Kindly review.


On Mon, Jan 7, 2019 at 2:25 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks - applied!

On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
> Hi Hackers,
>
> Attached is the patch to incorporate the changes discussed in trailing= mail(s).
>
> Kindly review.
>
> On Fri, Jan 4, 2019 at 3:31 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Hi,
>> >
>> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dpage@pgadmin.org> wrote:
>> >>
>> >> Hi
>> >>
>> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
>> >>>
>> >>> Hi Dave,
>> >>>
>> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <dpage@pgadmin.org> w= rote:
>> >>>>
>> >>>>
>> >>>> A few other things that I noticed (or have been b= ugging me):
>> >>>>
>> >>>> - The menu bar seems a little cramped. Taking pg-= navbar from 32 to 40px and setting the font-weight to normal on the menu op= tions (but not the product name) seems much better to me (and adjusting eve= rything else as required of course).
>> >>>
>> >>> Giving too much space for the navbar will reduce the = usable space for other things. It is good enough(32) to be used easily, and= is equal to all the other headers in app (including tabs) giving a feel of= native desktop application. You'll find even smaller menu heights in n= ative desktop application. We can make font weight to normal and may be sli= ghtly increase horizontal spacing between the menu links.
>> >>
>> >>
>> >> 8 pixels isn't going to make a noticeable difference = to the workspace for users, and would leave the bar smaller than the 50px i= t's been for the last couple of years (iirc). I think it needs it to av= oid looking cramped - please make the change.
>> >
>> > Will do.
>> > One more doubt regarding bold headers, should I remove bold h= eaders in dashboard graph header, subnode headers (eg.table->columns), p= roperties tab accrordian headers ?
>>
>> No, please don't. I left them bold and the styling seemed like= it
>> worked. We can tweak again if others disagree later.
>>
>> Thanks!
>>
>> BTW - Chrome 71 shows the offset headers in the file dialogue as w= ell.
>>
>> >>>>
>> >>>> - In the file dialogue, the column headers don= 9;t line up with the columns in the rows.
>> >>>
>> >>> I could not see this on my machine (screenshot attach= ed). Could you please share the screenshot.
>> >>
>> >>
>> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS.=
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB = Software Solutions |=C2=A0Pune
"Don't Complain about Heat= , Plant a tree"


--
Thanks and Regards,Aditya Toshniwal
Software Enginee= r |=C2=A0EnterpriseDB Software Solutions |=C2=A0Pune
"Don&#= 39;t Complain about Heat, Plant a tree"


--
<= div>Akshay Joshi
Sr= . Software Architect

<= /span>

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Dave Page
VP, Chief Architect, Tools & Installers
Enterpri= seDB: http://www.= enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogsp= ot.com
Twitter: @pgsnake


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--000000000000631b89057fa2c1a9--