public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["
Date: Tue, 22 Jan 2019 16:17:23 +0530
Message-ID: <CANxoLDeora2r22qMDUpDkH9B5wcBcZ93iYKEfUaUryTENUN-6A@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELcmBf+D=T-3mcjc2RYJiNFjLdat6W2RVhkz=19y9uAnew@mail.gmail.com>
References: <CAFOhELeOFhg9izkcnWgmpXBy4nc3vCj6XNnMaJYx8Cx+c0nT8g@mail.gmail.com>
<CANxoLDcxvRCXg_eDiaRBc+b_kT7nyJBFJFvdELm+3B5qgiRixQ@mail.gmail.com>
<CAFOhELcmBf+D=T-3mcjc2RYJiNFjLdat6W2RVhkz=19y9uAnew@mail.gmail.com>
Hi Khushboo
On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi <
[email protected]> wrote:
> Hi Akshay,
>
> Please find the attached updated patch.
>
> On Mon, Jan 21, 2019 at 2:57 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Hi Khushboo
>>
>> Can you please fix the following and send the patch again
>>
>> - PEP8 issue
>>
>> Fixed
>
>>
>> - Test cases is failing with Python 3.5.
>>
>> I have tested with Python 3.7 and it is working fine. Please give me the
> log to reproduce the issue.
>
I have tested it with Python 3.5 with PG10 and 11. Attached is the
screenshot.
>
>> On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix the RM #3853 - Incorrect SQL
>>> generated for create script of domain type interval with precision. ERROR:
>>> syntax error at or near "["
>>>
>>> The patch includes the fix as well as the API test case to verify the
>>> reverse Engineered SQL.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>
>>
>> Thanks,
> Khushboo
>
>> --
>> *Akshay Joshi*
>>
>> *Sr. Software Architect *
>>
>>
>>
>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachments:
[image/png] TestCase_Error.png (279.6K, 3-TestCase_Error.png)
download | view image
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["
In-Reply-To: <CANxoLDeora2r22qMDUpDkH9B5wcBcZ93iYKEfUaUryTENUN-6A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox