Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go4nQ-0001Fx-FV for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 11:09:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1go4mP-0001c8-Jj for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 11:08:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go4mP-0001by-4h for pgadmin-hackers@lists.postgresql.org; Mon, 28 Jan 2019 11:08:41 +0000 Received: from mail-qt1-x82d.google.com ([2607:f8b0:4864:20::82d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go4mI-0000pV-EY for pgadmin-hackers@postgresql.org; Mon, 28 Jan 2019 11:08:39 +0000 Received: by mail-qt1-x82d.google.com with SMTP id v11so17744958qtc.2 for ; Mon, 28 Jan 2019 03:08:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gxd21Ts36BopL2KTFO1xo1nSeQmj/k78iHeIIjG/geM=; b=iYKWI7LJDzLqg8D1bzpIoxn9yafK/EO3C8yn6yUzaMQZvkZG7awE+jBGjFmxTGGLTK l+y26llxBY8Fhsm6T0iFvG3MXTvmrkS7+OmVHHeUuvgctJ8BzW41FytT5ELF9uDHUGFO 3F8N14f5NUQRlKYcz/vYnr8M/0Tf+3Urre7t2NaaoCtk5CmoAStycr2ctS7BRZT4b5Sq NEIZGmc+CXJ4Nl3kFgcgCW/Ph2Yt0iKGvgNC78X4+zjPCLD1Ku+uS1pAzQzCOn4ViZjd ZFPyGMXRt04GvO+q6SzjLUZzRLFr2+ljYDxdV63NrQK8AA0ykkpYuKOCI5+9+iEoXRFc 1nfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gxd21Ts36BopL2KTFO1xo1nSeQmj/k78iHeIIjG/geM=; b=ccNbKhCpsvTn+SgW9Az7Zl/OHmSAMWjpCHuzKr+sSwIAT1sm/gGn6GMIRrqsLVC/dj kp97Vir+Diu62hgtE4B5W118El3jK+yh5npfIjA8Hu7tbkELxQ1QWrSFcKWpUc0HfO69 mVKuootJaWE8IN3Q/kRQ2cmCPaFnE1eSQfqyZMZpLLMgWeApBFtGcHl3x5Ti1qzU/o0r eiMZhsxhbHEUSOQqsDCP1isuiiW3BdljK9jjexzPr+R03xI5N5s8SY9c9SyAUew1hB8j +7Yie9IGPmrgE06MPbzVkHIUp3I8uavFC21bJ9B9scZonx1EQpnrsEQ+/JMDS+fR3F7Y 74YA== X-Gm-Message-State: AJcUukePRjZC2m5CXvPD2y5c54T+jW2IfqaPZPDypLrjk18ucXtW4Uvj vJL0BnEFld8qnr6rM6WjunKs/qQnwIWRuX3VR4K/cA== X-Google-Smtp-Source: ALg8bN5+EnHox7Dw7uVV2l1fbG5nTxf5ANVMfh0KFU/p5Ftu51tThOpHbH2MBZ2y0XWosyrF5pjcbYUaIsiR8IIeGug= X-Received: by 2002:a0c:fc09:: with SMTP id z9mr20345939qvo.157.1548673713201; Mon, 28 Jan 2019 03:08:33 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 28 Jan 2019 16:38:22 +0530 Message-ID: Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008c7b50058082b2f8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008c7b50058082b2f8 Content-Type: text/plain; charset="UTF-8" Hi Murtuza Here are my review comments: - Exact error should be logged in the log file and on GUI we should show message like "Unable to fetch object". - Message should be shown in the status bar. - If there is an error to fetch one kind of object, we should show other objects. On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch, To display an error on UI when there is a backend error > for the grant wizard request. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the issue where EPAS DB instance running with >>> *no-redwood-compat* mode fails to list down functions objects in grant >>> wizard due to 'char' -> 'int' type cast error. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --0000000000008c7b50058082b2f8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Murtuza

Here are my review comm= ents:
  • Exact error should be logged in the log file and on= GUI we should show message like "Unable to fetch <function/table&g= t; object".
  • Message should be shown in the status bar.
    • If there is an error to fetch one kind of object, we should show other obj= ects.

On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala <= murtuza.zabuawala@ent= erprisedb.com> wrote:
Hi,

PFA minor patch, To display an error on UI when there is= a backend error for the grant=C2=A0wizard request.
Ple= ase review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http= ://www.enterprisedb.com
The Enterprise PostgreSQL Company

=


On Mon, = Jan 28, 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wro= te:
Thanks patch applied.

On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala <murtuza.zabuawala= @enterprisedb.com> wrote:
Hi,
=

PFA patch to fix the issue where EP= AS DB=C2=A0instance running with no-redwood-compat=C2=A0mode fails to list down functions objects i= n grant wizard due to 'char' -> 'int' type cast=C2=A0err= or.


<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company



--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--0000000000008c7b50058082b2f8--