Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dBHsN-0004bW-4J for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:37:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dBHsM-0004zs-LI for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 May 2017 09:37:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dBHs7-0004b7-Uo for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:37:28 +0000 Received: from mail-pg0-x230.google.com ([2607:f8b0:400e:c05::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dBHs0-0000aP-CK for pgadmin-hackers@postgresql.org; Thu, 18 May 2017 09:37:26 +0000 Received: by mail-pg0-x230.google.com with SMTP id u187so20315216pgb.0 for ; Thu, 18 May 2017 02:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=od8YwInNmOAzd5QjqONp9igRGCk5yYVAhy0BevQ1VbE=; b=TSFXkr0vMxsKjtCggZ4ZXqe82mGH+TqcpJ8fPZXB0sVR8elQb79hWMZ8iBd4nCm2nw UCoVc4oLC3qgyoJyXADyPXfUMDK1+sL5xNcWHoJV/E7INIil834c9TFjQsCXTmymxHZO Afr0Dr1mjrbX+A4vJD4FbcDX1uzRFs6W+W57hC3mohK2BKxMQorlUQ3PjO8tua7/5gTq bamyx0YzMGiMtR7P1pT70NPtqHkjjZRm5B4CS9/6JOvSFE9VK8t2lKNgoo75HDG/gpzJ ATGQ/veJFPJdF0SqkLKsfKlSA7eCZ28iq0HGj8lvdyEsl4HJggqoQfF9JV0Tm9499jOt 5nnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=od8YwInNmOAzd5QjqONp9igRGCk5yYVAhy0BevQ1VbE=; b=eRQvokAB1PgI3yUIoUdHIK9Dnz8xoVZu4yTJNyDvS+hjTY87dVuCRg0nysh+TgOFdI viHTrkCzaVkdQe/ESihDTrRMxK9DA5FWdZgmcpUug9sQaCsgy+VVakfbA5izO77uU/rC TDLdGzNqeMAQ+0FMTUmPR24361rcNpzoMwLUIlPQhwPlLx6UXgV3lPISk/EMO/kHmBsb nVfA6H2n/EFqcmkDk3WqIEczK3no3/XtL++R83lLqv3C4l8wk49CJhnqWZV58spOWRX7 gzZ91MTndJT16gJB64aBLUaJUJUL0hGaemYoq+tq7/TBk16zeLTUfk/jW8pvYNnylMCV Y0bQ== X-Gm-Message-State: AODbwcDdA7H865n1BKvOaem74lsBAr1u3P0mthhOgniXzQkKr4HUAGSL B0VXmcT9aqZ2BB9M4BhHMiuQBoDqyYAA X-Received: by 10.98.8.142 with SMTP id 14mr3489962pfi.35.1495100239049; Thu, 18 May 2017 02:37:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.170.75 with HTTP; Thu, 18 May 2017 02:37:18 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Thu, 18 May 2017 15:07:18 +0530 Message-ID: Subject: Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1143d388a70f8c054fc92621" X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143d388a70f8c054fc92621 Content-Type: text/plain; charset="UTF-8" On Thu, May 18, 2017 at 3:00 PM, Dave Page wrote: > Hi > > Please see the discussion here: https://redmine.postgresql.org/issues/2308 > > Would moving to the client-side translation mechanism help here? We need > to do that anyway - and it's been added since the previous discussion. > OK, at least we should checked-in code for showing title of the confirmation dialog for "Truncate". > > On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi All >> >> I have found one issue where table name is not displaying in the confirmation >> dialog when user click on "Reset Statistics" and "Truncate/Truncate >> cascade". Confirmation dialog shows below message: >> >> - Are you sure you want to truncate table {}? >> - Are you sure you want to reset the statistics for table {}? >> >> Also header is missing for "Truncate/Truncate cascade" confirmation >> dialog. Attached is the patch file to fix that above. Please review it. >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a1143d388a70f8c054fc92621 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, May 18, 2017 at 3:00 PM, Dave Page <dpage@pgadmin.org><= /span> wrote:
Hi
Please see the discussion here:=C2=A0https://redmine.postgresql.org/issues/2308

Would moving to the client= -side translation mechanism help here? We need to do that anyway - and it&#= 39;s been added since the previous discussion.

=C2=A0 =C2=A0OK, at least we should checked-in code for sho= wing title of the confirmation dialog for "Truncate".=C2=A0
=

On Thu, May 18, 2= 017 at 10:17 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
<= div class=3D"m_6589834993030314752m_2433991302380042676gmail_signature" dat= a-smartmail=3D"gmail_signature">Dave Page
Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgr= eSQL Company



--
Akshay Joshi
Principal Software Engineer=C2=A0<= /div>

=

Phone: +91 20-3058-9517Mobile: +91 976-788-8246
--001a1143d388a70f8c054fc92621--