Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXHp1-0004zM-Dj for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Oct 2020 05:47:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kXHp0-0001iu-C7 for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Oct 2020 05:47:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXHp0-0001in-6y for pgadmin-hackers@lists.postgresql.org; Tue, 27 Oct 2020 05:47:02 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kXHox-00055q-QZ for pgadmin-hackers@postgresql.org; Tue, 27 Oct 2020 05:47:01 +0000 Received: by mail-io1-xd41.google.com with SMTP id z17so224147iog.11 for ; Mon, 26 Oct 2020 22:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MrwxIClgcjDrk9d/QfgNuEd7W/P+gPjM+2Tz9nzkkf4=; b=sNsH6fAJwwjh0sE7eTqMgdvp8HodWdfu1+U7HhKp6Bthnw3i3wumJtwkDlso/rzIII CVVlf69yME7ap5QnuksahaU40VxIiA45WH3A5Y9UcUxklZnQmRbM2QhpJ+Stq5Ivobsc GiOI+O26dGZSw7jeu7D70AXausld1RRGlwOeNf2C7BksqKvvss9YXFIEfDUIDCVi2mLM LVfCJkc9iqn5wbKoUKb6Rtg9pUxvKdEvVAW/3khQi6Yil9DxU84cjMGZ+ib0RedpdRhM vQa4c3ARkJQLznBAxKqQLtK5sLus91iDySnT8i2Q+kdr/JgaBEmGQ12WWV/cbRqs+xIm YTUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MrwxIClgcjDrk9d/QfgNuEd7W/P+gPjM+2Tz9nzkkf4=; b=gglSieuvtqzdyhPQ+c2ghsbtD/zUsSaMsfapQX/FYjuLlONSIfQtvgDmO3oGWat8tz kx7k5WexfFu1S15HJ+YtblQ8xzlgKQBu5IWVhs18h8lHI+kiC6fZm+MicqSXce9ovBQn 3+d7GJ12b7uGFYq4WPc0W89ePNVdkKtGgGTGUMRdU8oCCj7bH4psKPb4RjwRMYdfN5gP 2m6jgayKlcHwbqC/Wv3gFxcA2/x8gB6eoB33lqgaxPuUuYdUJqWJULDhz2nE8JmWlsX5 bKogPCSEtadrT2heqjjxjgoS3RQ1belY8V+oxBdm7JsUkei5LnoXdRFeTC+SGeToWEB/ V+PA== X-Gm-Message-State: AOAM532KfnYnCAzB79wo6IjlB1WINaa8cj6bkJTsiwTqvdMSK3VOGLoE fXjKZOm7wXQ0MP5lGRGssxY+LM2g/6ZUemMeJ7ALZhvrggnwrveCL8NqPoV9zeIa/RRDZXJyNl4 0wU0AMHctM/lUSDMFTRz+dcBh7oQGAlAH34+LYD1DVR9r2lWYwWnDjn2Chh6w0Gt4tIeDhq7z2N CPqOwRjyAq1OqHV6mQmPkZmLaMXV097L8grmsD447x14vOGTTXtyerI+aG4g== X-Google-Smtp-Source: ABdhPJwQb8Hth30VlHSbelF3yT3Nfm0/bMgJF3a1Y5vBqlcCUM3GdrUE8oG7TQWjLjMw+kx94aryX7cSBOI1i3DG3Ic= X-Received: by 2002:a05:6638:20a:: with SMTP id e10mr710191jaq.20.1603777618646; Mon, 26 Oct 2020 22:46:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 27 Oct 2020 11:16:47 +0530 Message-ID: Subject: Re: [pgAdmin][RM-4230]: Resolved issues in Rename tab To: Nikhil Mohite Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000042402105b2a09334" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000042402105b2a09334 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Oct 26, 2020 at 6:18 PM Nikhil Mohite < nikhil.mohite@enterprisedb.com> wrote: > Hi Team, > > I am sending a common patch RM-4232 and RM-4230 > Resolved the issues found in the testing. > > *RM-4232:* > 1. If the user adds a percentage (other than for placeholders) then it is > stripped off. > 2. Backslash is getting removed in the connection string if we provide the > backslash(\) in placeholders or the database name contains it. > 3. If the user added only spaces( )in placeholders it is not getting reset > to default values. > > *RM-4230:* > 1. Rename panel option is not working in the debugger. > 2. Added Rename panel for schema diff. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Software Engineer.* > *EDB Postgres* > *Mob.No: +91-7798364578.* > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000042402105b2a09334 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Oct 26, 2020 at 6:18 PM = Nikhil Mohite <nikhil.= mohite@enterprisedb.com> wrote:
Hi Team,

I am se= nding a common patch RM-4232 and RM-4230
Resolved the issues foun= d in the testing.

RM-4232:
1.=C2= =A0If the user adds a percentage (other than for placeholders) then = it is stripped off.
2. Backslash is getting remov= ed in the connection string if we provide the backslash(\) in placeholders = or the database name contains it.
3. If th= e user added only spaces( )in placeholders it is not getting reset to defau= lt values.

RM-4230:
1. Rename panel opt= ion is not working in the debugger.
2. Add= ed Rename panel for schema diff.

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.N= o: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246
=
--00000000000042402105b2a09334--