Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ioOjs-0003pE-LA for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Jan 2020 09:31:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ioOjr-0000Ef-CI for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Jan 2020 09:31:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ioOjq-0000EW-TR for pgadmin-hackers@lists.postgresql.org; Mon, 06 Jan 2020 09:31:55 +0000 Received: from mail-io1-xd32.google.com ([2607:f8b0:4864:20::d32]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ioOjh-0004DC-Ry for pgadmin-hackers@postgresql.org; Mon, 06 Jan 2020 09:31:53 +0000 Received: by mail-io1-xd32.google.com with SMTP id b10so47917224iof.11 for ; Mon, 06 Jan 2020 01:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=43F052BcbTA8KFRwAmmLTRTlQMQKv082UqcunD7K7hg=; b=BU0jc/NnP9yhalgW4Unt7bKcvzPy0LWXtnMpup++aWEQk/piJYHFhxbZ0t4MId2/Xc dTac3Fyv3rolOl5JBXSwGbQEED5SnYlNLdS4RW4ZYum0kgwFd77ILUop9VhcHjO7cMhK vRWsDQRClcw1LZrlm6gvz5eewLT/CqXyBTcNR+2jj4EaN/HQyQlV2kQ3dc/jjiiMDR33 cTDNBui5B6C8COax7BVVbfHyabQz+yfxOE7Kld/ubCS+8RTOyfmQsPCw0oLqFhAroHyn 2NdKmYr1+qOrS2QpegCRyn8KRG4lCMUg//SifXZOwNceEPELy4q63mdFaskPdzBJkyJq hzYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=43F052BcbTA8KFRwAmmLTRTlQMQKv082UqcunD7K7hg=; b=cieWFlwaT3AI3+IHSiNyT6cqiU42mXWHyjTt23hh5auDhoeRoUWXyJmIoDLB1c3gv5 HBD3d++C8OjMTRz/DM7EXvsJxPVwS3eWgyISdaKhEkF93xtXaNa9op+btIqmoKqvbTgt 5hXhxsU9/JmYbJxWNSi59zoAj73xnHAkBTgPkdFhnLn7cvUmCR5Ljf5XNzo4DYKSnXKZ Lo1fa5cyXO0hAUAv7J8quuOO7irEUd6ctN23gfGd3tBs/P/DDPciXWFAhTuppu7cj00N 4qNNq6DDXKVQ4REmttIb3B4Gx2aKfXVNMKp08f1tVX+e2j1Z7h2HqDfam8fPs8dkCBhG rtXg== X-Gm-Message-State: APjAAAUtbUaw/ZXRLZdsCZ4W3CkoSnQdmXs0j2opAQPZ7MkKSrwdpOu2 +WpleZQabjhTsxx1L1EqSxKcTnStxAs9mUW3L8A6iR72XOTdbgzbfm9CZgMTriYy4LeIfvp3m72 wDBU0Z2MtTpqGQj+XzoN7UxC0yKnT9MeaNZGJDEYL2dGq7tnxc7y4MsrF467wErnwkGNSkKaevm J24JyBtO06M+86tmedSiVzF2H0Z6YIw69GKh4Ln0Ndwlyd91jNhdc= X-Google-Smtp-Source: APXvYqzjNicV8upmO+bszM0Jc3pS9qkyUM0y5dU2Fns886pmr0u6CBx7qZdClrYIU+KFDngJKiY4Rs/wS+6Dhn7hFlw= X-Received: by 2002:a6b:f404:: with SMTP id i4mr66214293iog.252.1578303104796; Mon, 06 Jan 2020 01:31:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 6 Jan 2020 15:01:34 +0530 Message-ID: Subject: Re: [pgAdmin][RM4633] Bad view in partitioned tables To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e90d2b059b7553b0" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e90d2b059b7553b0 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 6, 2020 at 12:01 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Akshay, > > On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi > wrote: > >> Hi Hackers >> >> Attached is the patch to support the view part of the multilevel >> partitions. Users can perform all the operations except creating the >> partitions as a partitioned table. Users can create a partition table >> separately and attach it as a partition of another partition table. >> > Multilevel partitions are now manageable through the tree view except > creating a partition table of existing partition (which you already > mentioned). > One more problem that we already discussed that automatic tree refresh of > the multilevel partitions is not working due to our structure which is > going to be handled by the new RM. > New RM https://redmine.postgresql.org/issues/5064 has been created. > > Some of the minor review comments. > - _get_children_nodes name can be changed as it more like private method > but we are using it outside of the class itself. > Fixed. > - Stats of partition table is not displayed, but I think that is not > related to this patch, so can be fixed later. > I have verified/confirmed that in the case of the Partitioned table, Statistics is visible only for the child node. In the case of the multilevel partitioned table, Statistics will only be available of the last child node which we are showing, so it's not a bug. > > Thanks, > Khushboo > >> >> There are two problems mentioned in the RM. I have fixed the first one >> and we won't fix the second problem as by design we decided to show >> Partitions like Schema->Table->Partitions >> >> Please review it. >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000e90d2b059b7553b0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Jan 6, 2020 at 12:01 PM Khushboo = Vashi <khushboo.vashi= @enterprisedb.com> wrote:
Hi Akshay,

On Fri, Jan 3, 2020 at 4:5= 8 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers
=
Attached=C2=A0is the patch to support the view part of the m= ultilevel partitions. Users can perform all the operations except creating = the partitions as a partitioned table. Users can create a partition table s= eparately and attach it as a partition of another partition table.=C2=A0
Multilevel partitions ar= e now manageable through the tree view except creating a partition table of= existing partition (which you already mentioned).
One more problem that we already discussed that automatic = tree refresh of the multilevel partitions is not working due to our structu= re which is going to be handled by the new RM.

=C2=A0 =C2=A0 New RM=C2=A0https://redmine.postgresql.org/issues/50= 64=C2=A0has been created.

= Some of the minor review comments.
-=C2=A0_get_children_nodes name can be changed as it m= ore like private method but we are using it outside of the class itself.
=C2=A0 =C2=A0
=C2=A0 =C2= =A0 Fixed.=C2=A0
- Stats of partition table is not displayed, but I th= ink that is not related to this patch, so can be fixed later.
<= /div>

=C2=A0 =C2=A0I have verified/co= nfirmed that in the case of the Partitioned table, Statistics is visible on= ly for the child node. In the case of the multilevel partitioned table, Sta= tistics will only be available of the last child node which we are showing,= so it's not a bug.

Thanks,
Khushboo
There are two problems mentioned in the RM. I have fixed the fi= rst one and we won't fix the second problem as by design we decided to = show Partitions like Schema->Table->Partitions

Please review it.
--
=
Thanks & Reg= ards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited=
Mobile: +91 976-788-8246


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000e90d2b059b7553b0--