public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Fahar Abbas <[email protected]>
Subject: Re: RM4939 - Running in the container as non-root user
Date: Mon, 9 Dec 2019 11:10:48 +0530
Message-ID: <CANxoLDeuqVR+wzP4SnKPqXGxCmp-hR1+ZYQ75nehFEyfViXH5A@mail.gmail.com> (raw)
In-Reply-To: <CAJFwRrMA+FHaqhHeYVCzbm+MYt33Vg_DvwwTGinvXhMJfonazg@mail.gmail.com>
References: <CA+OCxoyhqSNoNzGA55qAb0HkjDr5v8vp78yWB-sLD2nYG-EpJQ@mail.gmail.com>
	<CANxoLDdmpYpdJrAG=f5KOoKVa=hOBt_QfaZTO+_KZexpm+ZxjA@mail.gmail.com>
	<CAJFwRrMA+FHaqhHeYVCzbm+MYt33Vg_DvwwTGinvXhMJfonazg@mail.gmail.com>

Thanks, patch applied.

On Mon, Dec 9, 2019 at 10:40 AM Fahar Abbas <[email protected]>
wrote:

> Hi,
>
> Verification has been completed, now you can commit this patch.
>
> On Wed, Dec 4, 2019 at 2:16 PM Akshay Joshi <[email protected]>
> wrote:
>
>> Hi Dave
>>
>> I have reviewed the code and tested the basic scenario. The code looks
>> good to me. I have verified that the user is pgadmin with user id 5050.
>>
>> With your patch                                        Without applying
>> your patch
>> [image: NonRootUser.png] [image: RootUser.png]
>>
>> @Fahar please test upgrades mostly when using mapped storage or session
>> data.
>>
>> On Wed, Dec 4, 2019 at 8:21 AM Dave Page <[email protected]> wrote:
>>
>>> The attached patch fixes $SUBJECT. I'm a little concerned about upgrades
>>> though, mostly when using mapped storage or session data. Fahar, can you
>>> test such scenarios please?
>>>
>>> Patch review is also needed please :-)
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Fahar Abbas
> QMG
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803
> Mobile: +92-333-5409707
> Skype ID: *live:fahar.abbas*
> Website: www.enterprisedb.com
>


-- 
*Thanks & Regards*
*Akshay Joshi*

*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*


Attachments:

  [image/png] NonRootUser.png (62.0K, 3-NonRootUser.png)
  download | view image

  [image/png] RootUser.png (104.9K, 4-RootUser.png)
  download | view image

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: RM4939 - Running in the container as non-root user
  In-Reply-To: <CANxoLDeuqVR+wzP4SnKPqXGxCmp-hR1+ZYQ75nehFEyfViXH5A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox