Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ic1a9-0001oj-EB for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Dec 2019 06:22:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ic1a8-0003AL-7i for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Dec 2019 06:22:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ic1a8-0003AE-0S for pgadmin-hackers@lists.postgresql.org; Tue, 03 Dec 2019 06:22:44 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ic1a5-0000Vr-78 for pgadmin-hackers@postgresql.org; Tue, 03 Dec 2019 06:22:43 +0000 Received: by mail-io1-xd2a.google.com with SMTP id f82so2365544ioa.9 for ; Mon, 02 Dec 2019 22:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=biVkasJxihpQcIhjAaFygMRJc0dJpIbpRoDvC/DDmj8=; b=BZ8WgHCAZpF1OSFA676okjYtS9ruBMxxvcpbMhuBnJcfbYzp7KHnlmnQisXwJLECuG gHDGLld8ic5aSghrMMXlUH9FD6ooqlbCmvvqmvxLKa9dYe6HyNQJ/s4ckLAGLodUThnk ucy/WWt2N+QmY6MpjB1hhCbjkqpyuYKf43U96T/XFcE+MhZKasqfqY/l6LAgfelZkhFA AoAhTzDscw/JOC0B2QCsRHRurDPYxs3WJSXfGRcY2UxGvRbPmvNkpuswW5lk9sC7sYNQ aBeKnPI/KtRcw5jys2Al54TvsO/C0BX23V9peETlbwTUg0gOj9mYO0HDtBWvPkmwuhto jYCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=biVkasJxihpQcIhjAaFygMRJc0dJpIbpRoDvC/DDmj8=; b=LjZkSb7jdKyvY6IwuMdyXf7QeLeJT4f1Z0UZ1DjkJS09z1xYHkzm4A6kPeqhoEbo5l lOYoMPp+Wc66kosVzZ0LB/cBlMGbx4lja98GV8mIXsN+ZYMQs+Fxol6Ii13bAlSQ6H75 RcuEGilxM/jq4p1KQ4+mGMYJjGzQUjXsbLWUZPulot75o/ckM/O8wS5I73a2v3H7H0sX gUl7KTSzeROwtmDKyjaOXSXDDCZcWNQDvk3XkAFq/NVqOvx8VyhcYk9Rzs7NA2oonAJA ghLZ+5YO/iwPyxB/2YPp0pBBLR9cxQd9n3ZabSGMnJ6aNsGLBITi0ByVFMVda3I5Ouaj XsMg== X-Gm-Message-State: APjAAAWVx0cgybNxT32TROP9C6QR5i7tQD4wvG0id7X3poAO6CTIUBO/ 1BAgxMNWDZVRglvzMSQ49kT/thEepvsrWXq9+1Ge0Ptx0Iqh29iLrYlU72KuYLTwypxUc18oW+I tBiDUT0V9SreUI50jDd5tO9nKr9I52eEX6/xEHY58B5lwNGohHsIW8EUIkGaDrWRLzUcXRa1kRP PVSiHhqe2ozWd4E3Xp8DsaLAf6nLzGJrWTGQGNZuVi7aTVd1Ibdlo= X-Google-Smtp-Source: APXvYqwcqweCv1/nQeCpgBe562ucoq+oWGeYKSwXhdelwaACTgRBfXugAiMBpHjbAHa/14pJEOoDd1P95/gVjjWew80= X-Received: by 2002:a6b:ec08:: with SMTP id c8mr1089714ioh.257.1575354158493; Mon, 02 Dec 2019 22:22:38 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 3 Dec 2019 11:52:26 +0530 Message-ID: Subject: Re: [pgAdmin 4][Patch] - RM #4923 - Enhancement for RM#3279 To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000003472a0598c6b933" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000003472a0598c6b933 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Dec 2, 2019 at 5:15 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #4923 - Enhancement for > RM#3279. > > Earlier we had *Delete/Drop* label in the context menu to remove the > server which was not appropriate, so we have changed it to *Remove Server*, > but the approach taken was not generic, which has been fixed in this patch. > Apart from that, the Server Group drop label has been changed to 'Remove > Server Group' in this patch as requested in the RM. > > Thanks, > Khushboo > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000003472a0598c6b933 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Dec 2, 2019 at 5:15 PM Khush= boo Vashi <khushboo.v= ashi@enterprisedb.com> wrote:
Hi,
Ple= ase find the attached patch to fix the RM #4923 -=C2=A0Enhancement for RM#3279= .

Earlier we had *Delete/Drop* label in the context menu= to remove the server which was not appropriate, so we have changed it to *= Remove Server*, but the approach taken was not generic, which has been fixe= d in this patch. Apart from that, the Server Group drop label=C2=A0has been= =C2=A0changed to 'Remove Server Group' in this patch as requested i= n the RM.

Thanks,
Khus= hboo


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000003472a0598c6b933--