Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwOB1-0008HH-52 for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 12:09:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lwOAz-00065b-KF for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jun 2021 12:09:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwOAz-00065T-8a for pgadmin-hackers@lists.postgresql.org; Thu, 24 Jun 2021 12:09:45 +0000 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lwOAv-0004S6-5Q for pgadmin-hackers@postgresql.org; Thu, 24 Jun 2021 12:09:44 +0000 Received: by mail-qk1-x734.google.com with SMTP id bm25so13960936qkb.0 for ; Thu, 24 Jun 2021 05:09:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=he6caBF5LMOnA834bhqnspK1NDx5ZTZxKEuUn1TDVgg=; b=Z5/qSoTbbkliZeCtaj5J8hTyh9Il0/b5UxZVMghKZQoHw3uFl1hlY2o7kVYt5Jr44W 2XtExEPRx2bmoHHiClZBxSKcLrstx+b0pJpGFRflVy69c0bK+Sc4yBoMUyy5p7zdaDYM fY3ecMxzeNsvrhHWTNsR9W+ooN4C6p/uDa21q5c1ce/zgIK3tVgr1lZmBL/rfa79GqJQ 36rajI54ZqtSyL6WkS8xCEJXLDbcRKQhh88XS2ymrmwG2GgHTozlGAthGiiAituI3xlP KZUNJDu5ySkdNhSMUfPMN820LMiK4PhNSPWYFbtJmgpZ/ZgR32fqOKX4Tzj8GhUhfD2p 8JNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=he6caBF5LMOnA834bhqnspK1NDx5ZTZxKEuUn1TDVgg=; b=V8gDi0arXfx+AO0AgJsxbBNnG0ZWohVvMeSkJdr3ULvBa61cgtRxxqbOzJK26kH7Jx v3eWbajl6A+cSfTZ5j1SDPPLXr4MoXc6xux7qWmtc58LMiL2kdIhguy7pDK6mYWLFUrA bc4Un36MJrgI9ESp3Al4e1Ms1OjbuJAuy38LN4Eqj6NmRbRUi/JUYoERWBcSmR3xVU/n Xz2+YkFHBwQC4bBHSKOKflB4SrrzH/slIvQ1yq3D/s5N1uhf67XG+DN0MFihiPV/y0iX cOWjVSzWmrdDJ4KCV7LpHbonp9tvqIZvdy4CKOISwL+Ix5rPW47n/HW1N88YCdZmWCG6 WfDg== X-Gm-Message-State: AOAM532RED/OWlf3pfSaIG8hphnwUy70t2KDxr7aZVPLrBTt5H1pYFyQ Fw4QQA5+Zt1pXKS6tZa/dkQ3BwfUOmJ3Q8tliDlomXa6zdNarB0oAFZzriNHRcOeXBa9GKSHuVU KPALv2cQYfP1dby5LShA64IuuwShJ8uTrtbZhb4lFRr+fkeyWOALlblEvBBTrlVQZbf/txmlMjx 1/fI07DW0vy0rvk2LoSK2NbUhRqOK9QyLyuOsBPWg1M50Ks0s3/p+vOzxNxg== X-Google-Smtp-Source: ABdhPJymgRyQQbmSZKZaLQU5MmC+U+iFTKE67/+jcmMM5QboDRR0bi8KONWlNGKiImk18OjnL5UX3xB5jp21ZXftFXs= X-Received: by 2002:a25:dbd4:: with SMTP id g203mr4443051ybf.78.1624536578125; Thu, 24 Jun 2021 05:09:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 24 Jun 2021 17:38:32 +0530 Message-ID: Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and port Server Group, Server and Database dialogs To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000aa05df05c581e5e8" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000aa05df05c581e5e8 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied in the "React_Porting" branch. On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Dave, > > On Thu, Jun 17, 2021 at 7:26 PM Dave Page wrote: > >> Hi >> >> On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached patch marks the beginning of migrating properties dialog/tab to >>> React based code, which is easy to maintain, performant and testable using >>> automation. >>> Patch includes: >>> - Framework for creating React based dynamic form view out of a >>> pre-defined UI schema. Previously, it was based on Backform/Backbone. >>> - The new framework and components will use MaterialUI as base. >>> Previously, Bootstrap/Backform/jQuery components were used. >>> - The new code uses JSS instead of CSS since material ui and most modern >>> React libraries also use JSS. In future, this will allow us to change >>> the theme in real-time without refresh. >>> - 90% code covered by 80-85 new jasmine test cases. >>> - Server group node UI Schema migration to new, with schema test cases. >>> - Server node UI Schema migration to new, with schema test cases. >>> - Database node UI Schema migration to new, with schema test cases. >>> - Few other UI changes. >>> >> >> Nice! >> >> >>> >>> PS: Until all the nodes are migrated, this will not go in the main >>> branch. >>> >> >> Yeah, how are we going to manage this? I agree with building it out in a >> branch until we have full coverage of the dialogues, but I'm concerned that >> it'll become a merge nightmare. Though, I guess we aren't touching the >> dialogues much for other things right now, so maybe not. >> > We'll right now work only on the dialogs. So merging should be manageable. > BTW, the patch can be merged in the main branch as well. It is backward > compatible, and it will work fine. Only the UI components would look > slightly different from the non-migrated dialogs. > >> >> -- >> Dave Page >> Blog: https://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: https://www.enterprisedb.com >> >> > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000aa05df05c581e5e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied in=C2=A0the "React_Porting&= quot; branch.

On Mon, Jun 21, 2021 at 9:35 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb= .com> wrote:
Hi Dave,

On Thu, Jun 17, 2021 at 7:26= PM Dave Page <dp= age@pgadmin.org> wrote:
Hi

On Thu, Jun 17, 2021 at 11:01 AM Adi= tya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch marks the beginning=C2=A0of migrating properties dialog= /tab to React based code, which is easy to maintain, performant and testabl= e using automation.
Patch includes:
- Frame= work for creating=C2=A0React based dynamic form view out of a pre-defined = UI schema. Previously, it was based on Backform/Backbone.
- The new framework and components will= use MaterialUI as base. Previously, Bootstrap/Backform/jQuery components w= ere used.
- The new = code uses JSS instead of CSS since material ui and most modern React librar= ies also use JSS. In future, this will=C2=A0allow us to change the=C2=A0the= me in real-time without refresh.
- 90% code covered by 80-85 new jasmine test cases.
- Server group node UI Schema migration to new, with schema t= est cases.
- Server node= UI Schema migration to new, with schema test cases.
- Database node UI Schema migration to new= , with schema test cases.
- Few other UI changes.

Nice!
=C2=A0
PS: Until=C2=A0all the= nodes are migrated, this will not go in the main branch.
=

Yeah, how are we going to manage this? I a= gree with building it out in a branch until we have full coverage of the di= alogues, but I'm concerned that it'll become a merge nightmare. Tho= ugh, I guess we aren't touching the dialogues much for other things rig= ht now, so maybe not.
We'll right now wo= rk only on the dialogs. So merging should be manageable.
<= span class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">BTW, = the patch can be merged in the main branch as well. It is backward compatib= le, and it will work fine. Only the UI components would look slightly diffe= rent from the non-migrated dialogs.
=C2= =A0
--
Dave Page
Blog: = https://pgsnake.= blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

<= /div>


--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000aa05df05c581e5e8--