Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jM4kV-0000Va-Vg for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Apr 2020 07:03:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jM4kU-0007ZF-TK for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Apr 2020 07:03:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jM4kU-0007Z8-IZ for pgadmin-hackers@lists.postgresql.org; Wed, 08 Apr 2020 07:03:46 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jM4kS-0004Om-1D for pgadmin-hackers@postgresql.org; Wed, 08 Apr 2020 07:03:45 +0000 Received: by mail-il1-x142.google.com with SMTP id r5so5751718ilq.6 for ; Wed, 08 Apr 2020 00:03:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ckcydp5mngzRlQZNUqDGeJKcy1Mq9C8BFKyXfA1yo1g=; b=0UEda40WtjPHw+vn7PWbMM3MNiSTMoLKCTnTqPXnlElCAu1JqtvBzdyn5bwsZK6LUH fugN7htmWukgulZQYczpivB0Oe/VS9VUCQPL32U3LUIC89dArKE49WyvaP2ARJSqeD3s 242yRX+X9YOsyvWrL7ug+31vmVilnkuFPLPrM+dtehxukT8/v2TdwbNGlwbXhVU1XRg4 6S6UMln7GxzGyB20zv922i8d/IXnm81H/9zCnaG+Y1ELMMAA41BARE33MRhg+MGBVxJn XQ4Kw5DZ7VgRlSJ9srzaZc7gXZTDnIK8bKHOIGocVrc/v++vPt1AiObRELRHtkchLOAp tMkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ckcydp5mngzRlQZNUqDGeJKcy1Mq9C8BFKyXfA1yo1g=; b=jbjLIKGUo5t4GtLrsMkNR6asMaZcEV1d4MW3iQVeLrabDuyqfpD2iK3g7JuL1YXsI4 lZbeWES2pj4uVRFy8bJg62vU0KwzUXO+eBqxPBip/Xb0u6C3Ucsn47BJOhn3Ni04k3Dr bHUIlGpgWQ3uKX8AaLKPMI7MRDmFIFQzfYoumL5NnQCz7SFummsBHWQRqvcP7SpgmPfi VOTLD5mc+XZNsSAVAamxvtSr9ZIEWviLA76vrNQDPGRCDIF9HEFJduqRrhcA9tWtHyUy 8VOyqdmL/0Juy9en/tmbDeV3LTxfme89+lGPqejSSYqtR49MibtlDV4aUyli8RO1oGXZ mBdg== X-Gm-Message-State: AGi0PuaHDQAXLW2cQnwQg+ImgSe+d+Fl/VIr6CeQWiTBYheI3LXCvvS5 Tmf+UwfjIOPyfW02s2HkJp6pJ/dDCRSqZYcD3WJTATh99Vm7dEiiZTfjEo9rvwSmYSo97wzF6/v 1b3/nsyWvAJZQSC6heHM00A9LRV/3KdiJjDW+aAfegmcXoC1r5gJSdLY27e9xWNg5Yu/eWyeqCQ W81K/Lxkq5SYc3Lz/zVt2uNqrWwPbpGOwWwP00u3rwMljhBYDFmwE= X-Google-Smtp-Source: APiQypKsjDGixeU3LhYQJUuk2PaglSqpPpjJJgYSbt6pkG1kt/SWXJTApZcGEjpsynQjzl1Bm9mvztMF/2iA9nMgEr0= X-Received: by 2002:a92:9fd0:: with SMTP id z77mr6524626ilk.257.1586329423141; Wed, 08 Apr 2020 00:03:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 8 Apr 2020 12:33:31 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID. To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000c376e405a2c219b6" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000c376e405a2c219b6 Content-Type: text/plain; charset="UTF-8" Hi Khushboo Schema Diff test cases are failing with this patch. Please fix and resend the patch. On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym > properties does not show OID. > > As per the current implementation, we completely ignored OID and instead > considered the name as the unique field, now with this patch OID will be > used as an unique id and also will display OID in the properties tab. > > Thanks, > Khushboo > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000c376e405a2c219b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Khushboo

Schema Diff test cases= are failing=C2=A0with this patch. Please fix and resend the patch.

On= Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
<= /div>
Hi,

Please find the attached patch to = fix the RM # 5270 -=C2=A0[EPAS] Synonym properties does not show OID.

As per th= e current implementation, we completely ignored OID and instead considered = the name as the unique field, now with this patch OID will be used as an un= ique id and also will display OID in the properties tab.
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif">
Thank= s,
Khushboo



--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000c376e405a2c219b6--