Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l40bL-0007Ow-9h for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jan 2021 12:04:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l40bK-0000iR-5x for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Jan 2021 12:04:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l40bJ-0000iE-Jp for pgadmin-hackers@lists.postgresql.org; Mon, 25 Jan 2021 12:04:10 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l40bG-00028Y-DL for pgadmin-hackers@postgresql.org; Mon, 25 Jan 2021 12:04:08 +0000 Received: by mail-io1-xd36.google.com with SMTP id e22so25962496iom.5 for ; Mon, 25 Jan 2021 04:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UQLu/LZ+WKHHLUtN5ViA28ht6C8lhy+lyiXzfPBUKpk=; b=cxnLha56uy2S5WLjjvoqA8jfj86ZMxF1Ar1VbtbvfwiHkr494eMPK4oIcfEWqzsAid cmLZ+3/DUtf6FYAUEeEq5yP6fWREMA6u9o4J40y/DjdE6+G2XW1Er3bwL2yrYbDyt8Wf 7HG1VJ3ihNhQ/Cnc8WPdk1AMhWOxYQsqBcojf302d5nGHR24EOPsycp7jRFPY/JgedSx L0ov5WzWiunMELvDKERX9DASR22LE3wNMEBuZCU9BmPY+3oQioxPgXeG7/b7YR/sCj5i C+jt15qmKwcfJunCy4CB7IhO/sgAfIgUnvFcRFGL5JaWIpMMEGDx4+42vpTa3r19W0qR R/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UQLu/LZ+WKHHLUtN5ViA28ht6C8lhy+lyiXzfPBUKpk=; b=N4hdrOPe0kwvN0cQ8+wltFM8gd5CwOHcA7fWB6xtjbThq9NRXbFuloWNiifsF/3qhp pYmgkvG+vqFmgmMTAqIaxytt/G1eMB/GBqTFWX6TgPXPm8Nt4IF0civrTznaZgVfd0Mj k4r4zKVCYjN8v26VGa1uhiYHrC8HzsdNS/GnN0vHT4qtVBePUFuPTBC1ktzSSnGTmWme 8CgCly+GxHhbx7kQR1Avtzzu16Vzga1H8L6OIvIog6JGYeLFD9+gITE33XY8kyjlU9qi FKzVVafE99yAaFPuuPJ0Iim4k1udiPPTwvn1hdzl8CI5O3MY1MgnsFUKazSSZAPFU5A7 2SvQ== X-Gm-Message-State: AOAM532FI0dAdes0Xofa2cKaWcFbMoQC5yaVgW1puzztH1+jaZJxNd+r ho1rt1OKTr6tuHb/PI539AGSQOMwVg4iN+N5zlb7CdWcUZwFuZY4WtHcv2P4YRubkDWfFKoDvxM r/3/AZAJIxvJ8Rp12/jeZzyLpSyZGhZMvosMhsTOt7i98EL9K4/iZAj3fqwUdxEMm1ogO04wsoR +F0KIWcW+RUSFANoMpFt00x0IfbfgX43z5BTY8xoiJePdVCVtzIeN4qmirIg== X-Google-Smtp-Source: ABdhPJyBdajtTjKSxrrnwJRE9ePdgGU7C0cDP+hqYWidm92+2u8ml7y8PjMgHf5YyadSU0lo1HC5AwAd+N6LGimXSJU= X-Received: by 2002:a02:68a:: with SMTP id 132mr215677jav.53.1611576245375; Mon, 25 Jan 2021 04:04:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 25 Jan 2021 17:33:54 +0530 Message-ID: Subject: Re: [pgAdmin][RM1802] ERD Tool (Beta) To: Aditya Toshniwal Cc: pgadmin-hackers , Khushboo Vashi , Dave Page Content-Type: multipart/alternative; boundary="000000000000a26c8605b9b8553b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a26c8605b9b8553b Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Jan 25, 2021 at 5:18 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > Please find the rebased patch from the latest pull. > > On Mon, Jan 25, 2021 at 5:12 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix below issues in ERD: >> >> 1. After opening an existing project, the first table is already >> selected but edit, clone, delete buttons are disable. Fixed. >> 2. ERD project title gets changed when 2 ERD projects are open & >> anyone of it edited. Fixed. >> 3. Closing ERD tab, does not ask for confirmation pop up. Added. >> 4. Shortcut for 'Show more/Fewer details' is missing. Added. >> 5. Deleting primary key does not delete associated links. Fixed. >> 6. Long table & schema name are getting out of box. Fixed. >> 7. Long table name in notes pop-up need re-alignment. Fixed. >> 8. Same table name present in ERD/canvas is allowed in Add Table >> dialogue. Added validation in the dialog. >> 9. Download image option is added, but it is not perfect yet. Image >> icons (table, schema, etc.) are not showing up. >> 10. Rename panel option should be disabled by default. It should be >> enabled for the tools which implement rename functionality. >> 11. The Toolbar is not visible in Safari for the ERD tool. Fixed. >> >> Please review. >> >> On Thu, Jan 21, 2021 at 4:32 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> >>> On Thu, Jan 21, 2021 at 3:08 PM Dave Page wrote: >>> >>>> >>>> >>>> On Thu, Jan 21, 2021 at 4:48 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Where's the Save Image button gone? I know Aditya was removing it >>>>>> whilst working on other things, but it's still required for phase 1 release. >>>>>> >>>>> It was not working 100% right. :( >>>>> So I've removed it for the time being. I'm still working on it. >>>>> >>>> >>>> OK, so that work will be completed in time for the build next week? >>>> >>> I'm trying my best to make it available before release. I'm struggling >>> to make it work perfectly. >>> >>>> >>>> >>>>> >>>>>> On Mon, Jan 18, 2021 at 11:45 AM Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> Thanks, patch applied. >>>>>>> >>>>>>> On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < >>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> OK, So the changes have worked. But still failing at one more place. >>>>>>>> Attached the patch fixes it. >>>>>>>> >>>>>>>> On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi < >>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Thanks, patch applied. >>>>>>>>> >>>>>>>>> On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < >>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> The jasmine test cases are working fine on my local machine. The >>>>>>>>>> test cases are successful on jenkins other than on linux, not sure why. >>>>>>>>>> I have made some fixes by looking at the log. Please review and >>>>>>>>>> try. >>>>>>>>>> >>>>>>>>>> On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi < >>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>> >>>>>>>>>>> Thanks, patch applied. >>>>>>>>>>> >>>>>>>>>>> On Mon, Jan 18, 2021 at 10:34 AM Aditya Toshniwal < >>>>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Akshay, >>>>>>>>>>>> >>>>>>>>>>>> I forgot to remove few of the dependencies which are not >>>>>>>>>>>> required as of now (may be in future). Attached patch removes those >>>>>>>>>>>> dependencies from package.json. >>>>>>>>>>>> >>>>>>>>>>>> On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi < >>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Thanks, patch applied. >>>>>>>>>>>>> >>>>>>>>>>>>> On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniwal < >>>>>>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I've fixed the issues. You can find the comments inline. >>>>>>>>>>>>>> I've also added PropTypes for the components for increased >>>>>>>>>>>>>> validation. >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi < >>>>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Aditya, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> The functionalities and the code looks good to me, however some of the comments as below: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Correct the comments at some places (3 occurrences found in /erd/__init__.py) which mention Schema diff instead of ERD. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Some comments in the JS/JSX file regarding components/functions (For example, IconButton (forwardRef), Bodywidget etc.) would >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> be great help as we all are new to React. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Done. Added comments to the components. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Remove the unused imports (for ex bad_request) in /erd/__init__.py >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Removed. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Remove commented code >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> # req_args = request.args >>>>>>>>>>>>>>> # if ('recreate' in req_args and >>>>>>>>>>>>>>> # req_args['recreate'] == '1'): >>>>>>>>>>>>>>> # connect = False >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Removed. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - TableNode.jsx, below two lines can be combined. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> import { PortModelAlignment, DefaultNodeModel } from >>>>>>>>>>>>>>> '@projectstorm/react-diagrams'; >>>>>>>>>>>>>>> import { PortWidget } from '@projectstorm/react-diagrams'; >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Done. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - onImageClick function in BodyWidget.jsx is no use I think, so it should be removed. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I wanted to keep the code as it will be used in future. >>>>>>>>>>>>>> Anyway, I've removed the code. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - I got some console errors while adding/editing tables. Refer to the attached screenshot. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I tried but I didn't get any. Looking at the screenshot, the >>>>>>>>>>>>>> error is from the underlying library. Can't do much in this. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - In the column Edit Mode, while deleting the primary key, it gives the error, which does not go away with any further modifications. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Fixed. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - While generating the SQL, if the server is disconnected, a proper error message should be thrown, right now some server side error is coming. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> It will show connection lost error now. Fixed. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Please remove ... from the menu title (New ERD Project(Beta)...) as it is not opening a dialog. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Done. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - For large data sets, generate ERD hangs. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> It shows the spinner and waits for the response to come from >>>>>>>>>>>>>> the back end. I've used the existing table fetching code which is used at >>>>>>>>>>>>>> other places. I'll create an RM to improve the back end code for fetching >>>>>>>>>>>>>> the tables data which will help the schema diff tool as well. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - Opening the ERD panel in a new window is not working, it opens in the same tab even if you have set the Preference "Open in new browser tab" to True. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Fixed. Added the setting in "Tab settings". >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - No shortcut is provided to open the ERD Tool. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> A shortcut is helpful if we are using it frequently. ERD >>>>>>>>>>>>>> tool won't be used that frequently. We already have a >>>>>>>>>>>>>> limited number of keys available for shortcuts. I think we should roll out >>>>>>>>>>>>>> without shortcut for now. If there is a user demand for it then we can >>>>>>>>>>>>>> think of adding it. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - SonarQube fixes required. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Fixed. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> - >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> *Suggestion:* >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> While removal of the FK link, If any of the table is selected, it is being deleted with FK link. >>>>>>>>>>>>>>> Either we should warn the user OR make 2 different buttons for FK removal and table removal as the user may be confused if the selected table is also removed with the FK. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I've added a confirmation dialog which will show the number >>>>>>>>>>>>>> of tables and links selected. This way user will know what he has selected >>>>>>>>>>>>>> before deleting. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> *Observations:* >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Lodash has been used in this module in place of Underscore, >>>>>>>>>>>>>>> though the dependency is already introduced by another module, >>>>>>>>>>>>>>> but we have mentioned it in the package.json file, which is >>>>>>>>>>>>>>> somewhat not convincing to me. >>>>>>>>>>>>>>> Lodash is more advanced than Underscore but we should pick >>>>>>>>>>>>>>> anyone as it will be easy to manage. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> TL;DR; we cannot. >>>>>>>>>>>>>> lodash is a peer dependency for react-diagrams (and some >>>>>>>>>>>>>> existing modules in pgAdmin) so it will come to package.json without >>>>>>>>>>>>>> choice. We cannot remove underscore because it is a dependency of backbone. >>>>>>>>>>>>>> Underscore is outdated, and I cannot migrate the complete pgAdmin code. So, >>>>>>>>>>>>>> I decided to go with 100/0 method. All the new codes will use lodash only >>>>>>>>>>>>>> as we'll phase out underscore with time. Just like jQuery vs ReactJS. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Table dialog code is duplicate of the table node, as it was >>>>>>>>>>>>>>> difficult to extend it because it was attached to the tree. >>>>>>>>>>>>>>> So, we need to keep in mind that while implementing React in >>>>>>>>>>>>>>> pgAdmin, the nodes should be properly detached from the tree itself, so we >>>>>>>>>>>>>>> can reuse it. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Yes. I agree. We need to separate out data source from UI >>>>>>>>>>>>>> going forward with React. >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Khushboo >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Dec 28, 2020 at 10:53 AM Khushboo Vashi < >>>>>>>>>>>>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi < >>>>>>>>>>>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi Khushboo, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Can you please review it? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On it. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal < >>>>>>>>>>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi Hackers, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Attached patch introduces ERD Tool(Beta) to pgAdmin. >>>>>>>>>>>>>>>>>> Below are the details: >>>>>>>>>>>>>>>>>> 1) Create a diagram from scratch or generate for an >>>>>>>>>>>>>>>>>> existing DB. >>>>>>>>>>>>>>>>>> 2) Generate "Create" DDL from the diagram. >>>>>>>>>>>>>>>>>> 3) Save the diagram and resume it later. >>>>>>>>>>>>>>>>>> 4) Supports basic table fields, one-to-many >>>>>>>>>>>>>>>>>> relationships, many-to-many relationships, adding notes. >>>>>>>>>>>>>>>>>> 5) Test cases added with 75-80% test coverage. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Please review. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Aditya Toshniwal >>>>>>>>>>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | >>>>>>>>>>>>>>>>>> *edbpostgres.com* >>>>>>>>>>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>>>>>>>>>> *EDB Postgres * >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Aditya Toshniwal >>>>>>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>>>>>> >>>>>>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>>>>>> *EDB Postgres * >>>>>>>>>>>>> >>>>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Aditya Toshniwal >>>>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>>>> >>>>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> *Thanks & Regards* >>>>>>>>>>> *Akshay Joshi* >>>>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>>>> *EDB Postgres * >>>>>>>>>>> >>>>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Thanks, >>>>>>>>>> Aditya Toshniwal >>>>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>>>> >>>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> *Thanks & Regards* >>>>>>>>> *Akshay Joshi* >>>>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>>>> *EDB Postgres * >>>>>>>>> >>>>>>>>> *Mobile: +91 976-788-8246* >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks, >>>>>>>> Aditya Toshniwal >>>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>>> >>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards* >>>>>>> *Akshay Joshi* >>>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>>> *EDB Postgres * >>>>>>> >>>>>>> *Mobile: +91 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EDB: http://www.enterprisedb.com >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: http://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Thanks, >> Aditya Toshniwal >> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >> >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000a26c8605b9b8553b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Jan 25, 2021 at 5:18 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

Please find the rebase= d patch from the latest pull.

On Mon, Jan 25, 2021 at 5:12 PM Aditya T= oshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Atta= ched is the patch to fix below issues in ERD:
  1. After opening an existing project, the first table= is already selected but edit, clone, delete buttons are disable. Fixed.=
  2. ERD project title gets c= hanged when 2 ERD projects are open & anyone of it edited. Fixed.<= /font>
  3. Closing ERD tab, does not= ask for confirmation pop up. Added.
  4. Shortcut for 'Show more/Fewer details' is missing. Added= .
  5. Deleting primary= key does not delete associated links. Fixed.
  6. Long table & schema name are getting out of bo= x. F= ixed.
  7. Long table n= ame in notes pop-up need re-alignment. Fixed.
  8. Same table name present in ERD/canvas is allowed i= n Add Table dialogue. Added validation in the dialog.
  9. Download image option=C2=A0is added, but it is = not perfect yet. Image icons (table, schema, etc.) are not showing up.
  10. Rename panel option sh= ould be disabled by default. It should be enabled for the tools which implem= ent rename functionality.
  11. The Toolbar is not visible in Safari for the ERD tool. Fixed.
Please review.

On Thu, Jan 21, 2021 at 4:32 PM Aditya Toshniwal <aditya.toshniwal@= enterprisedb.com> wrote:
Hi,


On Thu, Jan 21, = 2021 at 3:08 PM Dave Page <dpage@pgadmin.org> wrote:

On Thu, = Jan 21, 2021 at 4:48 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">
Hi Dave,

Hi

Where's the Save Image button gone? I know Adi= tya was removing it whilst working on other things, but it's still requ= ired for phase 1 release.
It was not working 100% = right. :(
So I've removed it for the time being. I'm s= till working on it.=C2=A0

=
OK, so that work will be completed in time for the build next we= ek?
I'm trying my best to make it avail= able before release. I'm struggling to make it work perfectly.
=C2=A0

On Mon, Jan 18, 2021 at 11:45 AM Akshay Joshi= <aks= hay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

=
On Mon, Ja= n 18, 2021 at 5:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
OK, So the chan= ges have worked. But still failing at one more place.
Attached the patch fixes it.

<= div class=3D"gmail_quote">
On Mon, Jan= 18, 2021 at 4:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:<= br>
Thanks, patch applied.

On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
Hi,
The jasmine test case= s are working=C2=A0fine on my local machine. The test cases are successful = on jenkins other than on linux, not sure why.
I have made some fixes by looking at the log. Please = review and try.

On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi <akshay.joshi@= enterprisedb.com> wrote:
Thanks, patch applied.

On Mon, Jan 18, = 2021 at 10:34 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>= wrote:
Hi Akshay,

I forgot to remove few of the dependencies which are= not required as of now (may be in future). Attached patch removes those de= pendencies from package.json.

On Sat, Jan 16, 2021 at 5:08 PM Akshay J= oshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
=
On Fri= , Jan 15, 2021 at 7:01 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.co= m> wrote:
Hi,

I&#= 39;ve fixed the issues. You can find the comments inline.
I= 9;ve also added PropTypes for the components for increased validation.

On Tue, Jan 12, 2021 at 12:18 PM Khushboo Vashi <khushboo.vashi@en= terprisedb.com> wrote:
Hi Aditya,
The functionalities and =
the code looks good to me, however some of the comments as below:
  • Correct the comments at some places (3 occurrences found  in /erd/__init__.py)  which mention Schema diff =
instead of ERD.
Some comments in the JS/JSX f=
ile regarding components/functions (For example, IconButton (forwardRef), B=
odywidget etc.) would
be great help as we all are new to React.
Done. Added comments to the comp= onents.
  • Remove the unused imports (for ex bad_request) i=
n /erd/__init__.py
Removed.= =C2=A0
  • Remove commented code
# req_args =3D request.args
# if ('recreate&#= 39; in req_args and
# =C2=A0 =C2=A0 req_args['recreate'] =3D=3D = '1'):
# =C2=A0 =C2=A0 connect =3D False
<= /div>
Removed.=C2=A0
  • <=
font face=3D"arial, sans-serif">TableNode.jsx, below two lines can be combi=
ned.
import { PortModelAl= ignment, DefaultNodeModel } from '@projectstorm/react-diagrams';import { PortWidget } from '@projectstorm/react-diagrams';<= /blockquote>
Done.=C2=A0
  • onImag= eClick function in BodyWidget.jsx is no use I think, so it should be remove= d.
I wanted to keep the cod= e as it will be used in future. Anyway, I've removed the code.
  • I got some console errors while adding/editing tables. Refer to =
the attached screenshot.
I = tried but I didn't get any. Looking at the screenshot, the error is fro= m the underlying library. Can't do much in this.=C2=A0
  • In the column Edit Mode, while deleting the primary key, it gives the er=
ror, which does not go away with any further modifications.
Fixed.=C2=A0
  • While gene=
rating the SQL, if the server is disconnected, a proper error message shoul=
d be thrown, right now some server side error is coming. 
    • <=
/pre>
    It will show connection lost error now. Fixe= d.=C2=A0
    • Please remove ... from the menu title (New ERD =
Project(Beta)...) as it is not opening a dialog.
    Done.=C2=A0
    • For large data sets, g=
enerate ERD hangs.
    It shows= the spinner and waits for the response to come from the back end. I've= used the existing table fetching code which is used at other places. I'= ;ll create an RM to improve the back end code for fetching the tables data = which will help the schema diff tool as well.
  • Opening th=
e ERD panel in a new window is not working, it opens in the same tab even i=
f you have set the Preference "Open in new browser tab" to True.<=
/font>
    • Fixed. Added the setting in= "Tab settings".
    • No shortcut is provided to op=
en the ERD Tool.
    A shortcut= is helpful if we are using it frequently. ERD tool won't be used that = frequently.=C2=A0We already have a limited number of keys available for = shortcuts. I think we should roll out without shortcut for now. If there is= a user demand for it then we can think of adding it.
    = 
    • So=
narQube fixes required.
    Fix= ed.=C2=A0
    Suggestion:
    While removal of the FK link, If any of the table is selected, it is=
 being deleted with FK link.
    Either we should warn the user OR make 2 dif=
ferent buttons for FK removal and table removal as the user may be confused=
 if the selected table is also removed with the FK.
    <= /blockquote>
    I've added a confirmation dialog which will show the numbe= r of tables and links selected. This way user will know what he has selecte= d before deleting.
    Observations:
    Lodash has been used in = this module in place of Underscore, though the dependency is already introd= uced by another module,
    but we have mentioned it in the package.json fil= e, which is somewhat not convincing to me.
    Lodash is more advanced than = Underscore but we should pick anyone as it will be easy to manage.
    TL;DR; we cannot.
    lodash i= s a peer dependency for react-diagrams (and some existing modules in pgAdmi= n) so it will come to package.json without choice. We cannot remove undersc= ore because it is a dependency of backbone. Underscore is outdated, and I c= annot migrate the complete pgAdmin code.=C2=A0So, I decided to go with 1= 00/0 method. All the new codes will use lodash only as we'll phase out = underscore with time. Just like jQuery vs ReactJS.


    Table dialo= g code is duplicate of the table node, as it was difficult to extend it bec= ause it was attached to the tree.
    So, we need to keep in mind that while= implementing React in pgAdmin, the nodes should be properly detached from = the tree itself, so we can reuse it.
    Yes. I agree. We need to separate out data source from UI going forwar= d=C2=A0with React.

    Thanks,
    Khus= hboo


    On Mon, Dec= 28, 2020 at 10:53 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> = wrote:


    O= n Fri, Dec 25, 2020 at 4:34 PM Akshay Joshi <akshay.joshi@enterprisedb.com&g= t; wrote:
    Hi Khushboo,
    =
    Can you please review it?

    On Fri, Dec 25, 2020 at 3:31 PM Aditya Toshniwal &= lt;a= ditya.toshniwal@enterprisedb.com> wrote:
    Hi Hackers,

    Attached patch= introduces ERD Tool(Beta) to pgAdmin. Below are the details:
    <= div>1) Create a diagram from scratch or ge= nerate for an existing DB.
    3) Save the diagram and resume it later.
    4) Supports basic table field= s, one-to-many relationships, many-to-many relationships, adding notes.
    5) Test cases added with 75-= 80% test coverage.

    Please review.

    --
    Thanks,
    Aditya Toshniwal
    = pgAdmin hacker=C2=A0| Sr. Soft= ware Engineer | edbpostgres.= com
    "Don't Complain about Heat, Plant a TREE&= quot;


    --
    Thanks & Regards
    Akshay Joshi
    = pgAdmin Hacker | Principal Software Ar= chitect
    EDB Po= stgres
    Mobile: +91 976-788-8246

    <= /div>


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thanks & Regards
    Akshay Joshi
    pgAdmi= n Hacker | Principal Software Architect
    EDB Postgres
    Mobile: +91 976-788-8246

    --000000000000a26c8605b9b8553b--