Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqIIS-0007yi-6m for pgadmin-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 16:40:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lqIIR-0003ax-4I for pgadmin-hackers@arkaria.postgresql.org; Mon, 07 Jun 2021 16:40:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqIIQ-0003aL-Mb for pgadmin-hackers@lists.postgresql.org; Mon, 07 Jun 2021 16:40:14 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lqIIO-0007zF-A6 for pgadmin-hackers@postgresql.org; Mon, 07 Jun 2021 16:40:13 +0000 Received: by mail-io1-xd2a.google.com with SMTP id k22so19015838ioa.9 for ; Mon, 07 Jun 2021 09:40:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L4wuHMUZjHyGxRePFJ9moWwrN9149j1EzV/8ktutCnQ=; b=e3ZCTtHLm+3mBPrlEzWUF1/WTWPHeYdzVi+/wyGQfA5Z9V+Li6qVj3XjYZJ+z3o4YK 6HeYVJrGXHTiQXeDDYsABmDZp+FQ0KzK5uH3ZHOlVx2qe+IxjizpaUlDDPCYRObSH7Bf wb99SBDhI85ACQiVfyZSIq/AIrZwYVwZuADz31OzFUW9ainrnC7t780owdzzwmSCGF33 RKN61BsmQqFrf1iVqDiRE21daa3oYCe1rusYCGPtTiA32jAaG0kJGby+az0mboZiGlpX SS0yKTlAstw8+rzSrNs4rjPb9t5CT25TSyzoHmOJYIEQ+mTs5o3/WqH6HT1RH90MyiJB 5umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L4wuHMUZjHyGxRePFJ9moWwrN9149j1EzV/8ktutCnQ=; b=HxkkmvHMKzRXtOrVivOBrIabqO5/BarZoklfp1JDIt96KUstmNJevVWcanBKhh+Ee9 Fc7gd02v6ySy9mQbs+S4XAnjCLywIHUQn0AIMIPzjvYbhdNyFM9RuGsEZOmEpWYJc8Qo AmdmDvQWVvPWmNf5U6jDOo0/GpSobuWD5TB1/GSHVc4e8moHs8cfHfagHZgxnaF1eOaj jHvfINzB6JNoPouTLWKvI1uyHEOfr6KwHa6tDoKK05pF6ljKrFoQmK4LKwJd0eLNHGNZ AMg2U/JDKNojKx9KD7NMa312/ZL8ip8aBdBNlQFtkrc0v4XXRjSryM4zf01gehPUBL9+ vdWQ== X-Gm-Message-State: AOAM533FjSlwR4nyPZFmzqCBitEpKpfdQqIzROF4w4yCJo4Qls3y/G4O 1ZgW0dGNtProaVlgRQj6VJozjcTN9EaaHrPM9fK1KIo3tyVvtxbhnZ+HpG/c4vm3Rt7lO/GHnoc fD31uPgMb5VVvNNpO6TLJ1d8vSXcifuEJlKWDDL1w6RvaJNQkQc+TR1iNqgLoRhV4VbkTiM8aeg 7ldMGNCkxSBcR7x8YvhI1vtNuJj8UZJLvKAnYXC+w8RXRSrQBIQJ1XH4JziBkcb3pPi9PW X-Google-Smtp-Source: ABdhPJxHBv6wNaW5KgUJugRMx3XV+kTYLfXLfOxQBYLe+XBku3s4F2eelhtRosW8QOntHbq5t6T+mwgdTPIijTDt04M= X-Received: by 2002:a05:6602:2f08:: with SMTP id q8mr14873616iow.18.1623084011591; Mon, 07 Jun 2021 09:40:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 7 Jun 2021 22:10:00 +0530 Message-ID: Subject: Re: [Patch][pgAdmin] RM4203 Rename Database by another user To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000f3b10105c42fb1a1" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000f3b10105c42fb1a1 Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Mon, Jun 7, 2021 at 5:08 PM Rahul Shirsat wrote: > Hi Akshay, > > Please find the updated patch below for your reference. I have added an > extra check for verifying the database rename. > Sorry for the inconvenience caused. > > On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi > wrote: > >> Thanks, the patch applied. >> >> On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> On Thu, May 27, 2021 at 12:19 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Rahul >>>> >>>> Following are the review comments: >>>> >>>> - Why you have changed the order of the toolbar button on the >>>> browser tree? It should not. >>>> >>>> Changes were related to the wcDocker issue showing >>> reverse order buttons, so had to change in the pgAdmin app to reflect it >>> correctly. >>> >>>> >>>> - *sqleditor.js (check_db_name_change function)* >>>> - var declaration should be comma-separated instead of writing var, >>>> again and again. >>>> >>>> Done. >>> >>>> >>>> - Add proper comments. >>>> >>>> This too is taken care of. >>> >>>> >>>> - Remove dots from the string "Database moved/renamed.." >>>> >>>> Done. >>> >>>> >>>> - "Please note that the database you are working on has been moved >>>> or renamed to ${data.actual_db_name}. Refresh databases in browser panel or >>>> click OK to continue.." should be changed to "Current database has been >>>> moved or renamed to ${data.actual_db_name}. Click on the OK button to >>>> refresh the database name." >>>> >>>> Done. >>> Also have done some code refactoring. >>> >>>> >>>> >>>> On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat < >>>> rahul.shirsat@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Please find the attached patch which resolves the issue of renaming >>>>> the database by another user. >>>>> >>>>> A minor issue of navigation button alignment is also fixed in this >>>>> patch. >>>>> >>>>> -- >>>>> *Rahul Shirsat* >>>>> Senior Software Engineer | EnterpriseDB Corporation. >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000f3b10105c42fb1a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Mon, Jun 7, 2021 at 5:08 = PM Rahul Shirsat <rahu= l.shirsat@enterprisedb.com> wrote:
Hi Akshay,

Please find the updated patch below for your=C2=A0reference. I have added= an extra check for verifying the database rename.
Sorry for the = inconvenience caused.

On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi <= akshay.j= oshi@enterprisedb.com> wrote:
Thanks, the patch applied.
<= br>
On Sun,= May 30, 2021 at 12:03 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com>= wrote:
Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Ak= shay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Rahul

=
Following are the review comments:
  • Why you hav= e changed the order of the toolbar button on the browser tree? It should no= t.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0Changes were related to the wcDocker issue showing = reverse order buttons, so had to change in the pgAdmin app to=C2=A0reflect = it correctly.
  • sqleditor.js (check_db_name_change function)=
    • var declaration=C2=A0should be comma-separated instead of = writing var, again and again.
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 Done.=C2=A0
    • Add proper comments.
    =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 This too is taken care= of.=C2=A0
    • Remove dots from the string "Database moved/= renamed.."
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 Done.=C2=A0
    • "Please note that the database you are w= orking on has been moved or renamed to ${data.actual_db_name}. Refresh data= bases in browser panel or click OK to continue.." should be changed to= "Current database has been moved or renamed to=C2=A0${data.actual_db_= name}. Click on the OK button to refresh the database name."=C2=A0
      =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Done.=C2=A0<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Also have done some code refactoring.
<= br>

On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <rahul.shirsat@enterpris= edb.com> wrote:
Hi Hackers,

Please find the atta= ched patch which resolves the issue of renaming the database by another use= r.

A minor issue of navigation button alignment is= also fixed in this patch.

--
Rahul Shirsat
Senior Softwa= re Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engin= eer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000f3b10105c42fb1a1--