Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0OjZ-0000WU-Nm for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Aug 2019 11:24:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i0OjY-0000Vm-HJ for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Aug 2019 11:24:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0OjY-0000UO-9O for pgadmin-hackers@lists.postgresql.org; Wed, 21 Aug 2019 11:24:56 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i0OjV-0001PK-9R for pgadmin-hackers@postgresql.org; Wed, 21 Aug 2019 11:24:55 +0000 Received: by mail-qk1-x741.google.com with SMTP id w18so1461453qki.0 for ; Wed, 21 Aug 2019 04:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DPBezXsZ9SI/17z/BL03/bU8w/2wuEkxAxMT4XpA+k0=; b=qaSdlz4lZp2Z+j9ON06vCIiLVzS46q9orrahyT9G+tLwgtSGfrY2De/yWn4/hGcYJp pAGlaQbGnVIJaDWjFiGh5j9I5xMpEoyA2iK90pKFe902QlKBuIH10Aaz3XA0fp++t0mR bX0XpbidwYt0afhFUbBRM7c/PI7oauuuY7/4m9vSZnyYwtEitDZnHG5NaEeTnrhcOGSX EJdyh5DCjUDl4uKP3zHc7TzLT2seeWm9XUfaLPr1axWrM8jchILA5y/z5kpVMLbn7kv/ TxonyY/Ydx5c62wuVwGnOulb5WhNPT6XznRiIRQPHynUOlVjqWOHTlIX3ecwMgge7WMx ssbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DPBezXsZ9SI/17z/BL03/bU8w/2wuEkxAxMT4XpA+k0=; b=NahMep1fm3cBfp+a8J8/zqRRxRSLnQjIlMCNIsNPgW+1E85fmbk4Ij5wTTXY7tu565 M0b9gRcJAHjh3Og3mZOKw2tfbfPmk4EfmJafZAkRlUC9wR62YWzpxYPOo8DvyDx8080j wWclaVyUqiaxvgcSrklgtWI9OTETgwEszN/W33OWvIwnUgC6Mmn9UiSOnRGQab9HNx7r mZwjpAsAELkugGvO4bRN5920Cu/sHgK2ITglymN6olpHePLfR4eL+b7NcB/YBZMn3AAL PrUbDSN5LFesU/95XFZZa/dF1+KLQNQU5aIpkDXBPN/N2NhjfUHVwKZpPXK+Zp8eFk2D bzQQ== X-Gm-Message-State: APjAAAUdJnThd45QK7etB2ApALHiergtcH9S5+uxsJVdUYznWCdpW334 KH9/Y1EVCCpfH8fHlcp+KFuRuD7A0IIl3GE1pjYkVw== X-Google-Smtp-Source: APXvYqz5IbUHEWLR/olLOEYqsX/3EI0SbknyK+CpMCeR24SXayIWw7vw4Sz9Z1C4YN1ZAekv2CD8cmLEFj8ya8se1Rs= X-Received: by 2002:a37:bac3:: with SMTP id k186mr29948358qkf.61.1566386690976; Wed, 21 Aug 2019 04:24:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 21 Aug 2019 16:54:40 +0530 Message-ID: Subject: Re: RM 4463 - RESQL test cases for domain node To: Neel Patel Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004c030605909ed29c" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004c030605909ed29c Content-Type: text/plain; charset="UTF-8" Hi Neel MSQL test case for *create* was not running before. In my last patch I have fixed that. Applying your patch on latest code not working can you please fix that and re-send the patch. On Wed, Aug 21, 2019 at 2:33 PM Neel Patel wrote: > Hi, > > Please find attached patch that will add more resql test cases for domain > node. > > - Covered test cases for Length, Precision and Collation. > - Also added msql test cases. > > While writing resql test cases for domain node, I found one more issue > RM-4644 . I am sending > separate patch for the same. > > Thanks, > Neel Patel > > On Fri, Jul 12, 2019 at 7:10 PM Dave Page wrote: > >> Thanks, applied. >> >> On Fri, Jul 12, 2019 at 12:31 PM Neel Patel >> wrote: >> >>> Hi, >>> >>> Please find attached patch for reverse engineering test cases for domain >>> node ( RM #4463 ) >>> Do review it and let me know for comments. >>> >>> Thanks, >>> Neel Patel >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000004c030605909ed29c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Neel

MSQL test case for crea= te was not running before. In my last patch I have fixed that. Applying= your patch on latest code not working can you please fix that and re-send = the patch.

On Wed, Aug 21, 2019 at 2:33 PM Neel Patel <neel.patel@enterprisedb.com> wrot= e:
Hi,

Please find attached patch that will add more re= sql test cases for domain node.
  • Covered test cases for Le= ngth, Precision and Collation.
  • Also added msql test cases.
    • While writing resql test cases for domain node, I found one more issu= e = RM-4644. I am sending separate patch for the same.

    =
    Thanks,
Neel Patel

On Fri, Jul 12, 2019 at 7:10 P= M Dave Page <dpag= e@pgadmin.org> wrote:
Thanks, applied.

On Fri, Jul 12, 2019 at 12:31= PM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch for reverse engineering test cases for domain n= ode ( RM #4463 )
Do review it and let me know for comments.
=

Thanks,
Neel Patel


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000004c030605909ed29c--