Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzHea-0005BR-M3 for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 11:16:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzHeZ-0006dP-L9 for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 11:15:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzHeZ-0006dI-Eg for pgadmin-hackers@lists.postgresql.org; Tue, 12 Jan 2021 11:15:59 +0000 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kzHeQ-0002lS-II for pgadmin-hackers@postgresql.org; Tue, 12 Jan 2021 11:15:57 +0000 Received: by mail-io1-xd2e.google.com with SMTP id p187so3137300iod.4 for ; Tue, 12 Jan 2021 03:15:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qVv0Udm8uIVQ8wJvn8GpEpf8QgqQlS2fD3eqZLalJ2Q=; b=KrrigtkFZWnP5C0b3piR3fmuGy/Exr8/GiPDLQkGNT6mCdyptAuc4BvQGB9IXgIOjK 9JmMYwEIbZLhMvmcEQ5FYzoxLK1S020C1UXdgFYgf9LW2lXW82k9fP0lL9r2mhXeoeF/ 7jGLpa31ZIBPtk4xLBiOz2lgHYbxoKAeqoppMVu0fN3CN6EHEf0Uszv+/RYwtVyT764F nyZ4Gy0Tapa3Ppf6KkboF/ckz9YN8na6EcIU8MvcnTLDKeofyawKU+df8R4WT2M1MVXe iRw0A+nftdvaM2erTZmPT0NhGw7JRsye2Jh71ArTV4PlGaKHRbcs678ThDXrZuDOmVqj 9xwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qVv0Udm8uIVQ8wJvn8GpEpf8QgqQlS2fD3eqZLalJ2Q=; b=eU24MiZMZCDLkzSn090t8SKuo68uVvRFssl6YYpo9Nw+CNDAE+LKsqlpl0bXv6qELD L9Trq9cp0HUcCaERTqraZo6tlqijz1VshpyTeqFaHVuO+XgZgCdn+QpC+mO+K7rq87qj Tg5JH74mwXuMoXpAarGMKnQIbQ0Ksagjxls7gGduZ8DCdhocyPrZbA2/Am/tjgseBXzZ v9KQFotxwk5VFY0OA5YtAtDiejzixEH1x2x/oMVueqPOB6rVOk/+KqXE510QPHAgczqz 0HW05vakzCT1vH6L/WT0BRGIwCpsBUU+MwPDkBK5WEbTurS1ktrYmWi432ZQ8n/a37ll 8H0w== X-Gm-Message-State: AOAM530ZY/PReAyCHHDr26ApcoEhP0hRblTn2GJfzGNPaVdCIGB1UkFP nfp22Y8DUUdetHmQicScpAaXgbOZom0W0+V0CB/uuh4jEVg30+idG6mqJ8SK6m9zz6g3+GAQLru Od8dQSDAnRQcghD21SRCof4hW6hc4g/0Py4tcYuaydr+weTKWiqfQSykSffmDrZxY6BwmmjeTvl DjQtKdZnDkvDUKf0UiFlXTPdsNJPD5unEtuGolEc8UrhPzvwyfQazevAaneA== X-Google-Smtp-Source: ABdhPJxlWsjkBRba4vzZxIpn9MZ6EOwy04JuOCcD9OHf0fEoCAGca2XeRC+a5AnwRJ+x1Yh4ViwyUWo7gfX09gNhTRw= X-Received: by 2002:a05:6e02:1985:: with SMTP id g5mr881776ilf.257.1610450147858; Tue, 12 Jan 2021 03:15:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 12 Jan 2021 16:45:35 +0530 Message-ID: Subject: Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000fdebd705b8b2240c" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000fdebd705b8b2240c Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Akshay, > > Attached is the updated patch. Please review. > > On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Code looks good to me. Below are the review comments: >> >> - Copy and Paste not working in the popup. >> - Documentation needs to be updated. >> >> >> On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached patch improves the way explain plan details tooltip for a node >>> is shown. With the change, popup with details will be shown upon clicking a >>> node, and it will remain open until explicitly closed. >>> >>> Please review. >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000fdebd705b8b2240c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Attached is the= updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay = Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs = to be updated.

    • On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshni= wal <aditya.toshniwal@enterprisedb.com> wrote:
    Hi Hackers,

    Attached = patch improves the way explain plan details tooltip for a node is shown. Wi= th the change, popup with details will be shown upon clicking a node, and i= t will remain=C2=A0open until=C2=A0explicitly closed.

    Please review.<= /div>

    --
    Thanks,
    Aditya Toshniwal
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edb= postgres.com
    "Don't Complain about Heat= , Plant a TREE"


    --
    Thank= s & Regards
    Akshay Joshi
    pgAdmin Hacker | Principal Softw= are Architect
    EDB Po= stgres
    Mobile: +91 976-788-8246



    --
    Thanks,
    Aditya Toshniwal=
    pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
    &quo= t;Don't Complain about Heat, Plant a TREE"


    --
    Thanks & Regards
    Akshay Joshi
    pgAdmi= n Hacker | Principal Software Architect
    EDB Postgres
    Mobile: +91 976-788-8246

    --000000000000fdebd705b8b2240c--