Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZ79F-0003Vf-2b for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Nov 2019 05:42:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZ78F-0006Kc-Ry for pgadmin-hackers@arkaria.postgresql.org; Mon, 25 Nov 2019 05:41:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZ78F-0006AO-Aq for pgadmin-hackers@lists.postgresql.org; Mon, 25 Nov 2019 05:41:55 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iZ78C-0002Wn-U2 for pgadmin-hackers@postgresql.org; Mon, 25 Nov 2019 05:41:54 +0000 Received: by mail-io1-xd2b.google.com with SMTP id z193so14841220iof.1 for ; Sun, 24 Nov 2019 21:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3uFtle0jyxFQlMaGQAmyLWjd+FWcgn+eAL/88Wx9yZU=; b=19fgj07hTwIYROU9RKsuz3x+pPLyK1giHqPZNLgPSKrbVUrLvDGuzOdSbbcodpYKMi sEKQmIdOK+o7ZBReVxbwCHIK7EhrIHha/TdfQiLMtCo245Kpf+OuI8Q8t79zKTC4yesv 26JfXiq+oZUeEfuhbn17hBZPTPLeNiF4ypnQ7UXLEs1hVOwOgRpfxx1AJwD+hy6nQAOg Q32nlr6AHD7mtGOJm+NwsS7BBsakK3Vu52iXlzdPveD303/UhM5mhxDTNSmLfEtelbV4 2i45lWuZjhsoLjG5hyUEr6V5JMn0LbF8QzgFcidHGWjblowBESANSH55Gxq3Anz9q1xz bbVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3uFtle0jyxFQlMaGQAmyLWjd+FWcgn+eAL/88Wx9yZU=; b=homdn0RggeQ1zmuFVl5KiAjVaqRx7w6YeMm3xImIHOYYTmuRgdQ8kbKPWJmM5wSRh4 T/nlNesw7hMmoYZDtmBwjq7n6tMQBtZ0re9dFnC/Eegs5nduX0PP7akduYfF54pE8BwE oEtdO2fsGJwDTXRK/ArCne2iLR3YxtZ672sSzSdC/rby1Ihi2XJy32wvrj80Ngca4SPi 7lSCTrakC4ldk5K4cpDu0YdD7VVU7zZbqMbSC88s4zlNidParV2WrLvME/Qp0bqnWSSQ P0M9elKTaDywDiAOD1rX8Sl+la5/7gVxedikw2O9PSWZFzhm9TVrJ8QKddvNtOyFzmx2 +naQ== X-Gm-Message-State: APjAAAVdyuecTvZc5KeJCzL5Sc8W2X3lIBBwW7MhBYQx1/VnELxF/GpB nGIiIw4mv4JJL688Z0KYiJ/XDPhhlf01/4hEct1qVp//QiLe7DyxgtLFOkZ3jEqbiF3X9ulM7hX I7YiE+kZ8HziKKzOd56mZr4dEe7lw0wAdF1DFqKr08fYlwhkUIIWVV4C0i736O9NZ0kOzlhNluk udiK7jHR7aZXRL4gKBPfJtSC4hieoILEBV9hkFe8qZpeIDEGvVz8g= X-Google-Smtp-Source: APXvYqzkW22LQC44JLdFKi1ko5oyej/dyc3pC0bhJJ+0oW1lmMjdV6Wg3uFldYgVS15PoPG5HTI2LNr4W7Z1uRsONng= X-Received: by 2002:a02:13c2:: with SMTP id 185mr18047974jaz.0.1574660511924; Sun, 24 Nov 2019 21:41:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 25 Nov 2019 11:11:40 +0530 Message-ID: Subject: Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View To: Rahul Shirsat Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000074a1fa0598253853" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000074a1fa0598253853 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Sat, Nov 23, 2019 at 12:37 AM Rahul Shirsat < rahul.shirsat@enterprisedb.com> wrote: > Akshay, > > Please find the correction done in this updated patch based on your review > comments. > > Regards, > Rahul Shirsat. > > On Thu, Nov 21, 2019 at 1:08 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Rahul >> >> Some more review comments: >> >> - Don't create new file test_view.json as I tested and committed the >> old code. >> - Remove hardcoded "oid: 17869" from JSON file. >> - MSQL endpoints and file name missing in some test cases. >> - Cover all the controls in create and alter as much as possible. >> >> >> On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Rahul >>> >>> Test cases failing on all EPAS servers. Please fix and send the patch >>> again. >>> >>> On Tue, Nov 19, 2019 at 12:47 PM Rahul Shirsat < >>> rahul.shirsat@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> I have attached the patch for RE-SQL/MSQL test cases for View as well >>>> as Materialized View. >>>> >>>> -- >>>> *Rahul Shirsat* >>>> Software Engineer | EnterpriseDB Corporation. >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000074a1fa0598253853 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Sat, Nov 23, 2019 at 12:37 AM Rah= ul Shirsat <rahul.shir= sat@enterprisedb.com> wrote:
Akshay,

Please find= the correction done in this updated patch based on your review comments.

Regards,
Rahul Shirsat.

On Thu, Nov = 21, 2019 at 1:08 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
= Hi=C2=A0Rahul

Some more review comments:
    <= li>Don't create new file test_view.json as I tested and committed the o= ld code.
  • Remove hardcoded "oid: 17869" from JSON file.
  • MSQL=C2=A0endpoints and file name=C2=A0missing in some test cases.
  • Cover all the controls in create and alter as much as possible.
    • <= /ul>

On Tue, Nov 19, 2019 at 6:27 PM Akshay Joshi <akshay.joshi@enterprised= b.com> wrote:
Hi=C2=A0Rahul

Test cases failing o= n all EPAS servers. Please fix and send the patch again.

On Tue, Nov 1= 9, 2019 at 12:47 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote= :
Hi Hackers,

I have attached the patch for RE-SQL/MSQL= =C2=A0test cases for View as well as Materialized View.

=
--
Rahul Shirsat
Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000074a1fa0598253853--