MIME-Version: 1.0
References: 
 <CAFOhELd+8ump0kQ-UHeN9szfefVh-QG0HvGSFZif47ryPoETrw@mail.gmail.com>
In-Reply-To: 
 <CAFOhELd+8ump0kQ-UHeN9szfefVh-QG0HvGSFZif47ryPoETrw@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Tue, 4 Aug 2020 12:10:17 +0530
Message-ID: 
 <CANxoLDf93wWrt8W94wVhtz1mzFJJe2Hb8UNDPmL+maxwnpNcrQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - SonarQube Fixes
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ef1ba705ac0787f8"
Precedence: bulk

--000000000000ef1ba705ac0787f8
Content-Type: text/plain; charset="UTF-8"

Hi Khushboo

As per offline discussion, multiple developers declaring the constant for
the same string and error messages. To avoid that only one developer should
work on this task.
Suggestions:

   - We should have a common class for Constants (which are not module
   specific).
   - For module specific constants we should not declare them as Global
   variables if possible declare them as the Class variable.
   - For common error messages(if any) we can define functions in
   PGChildNodeView.

Please incorporate the changes send by Yogesh.

On Mon, Aug 3, 2020 at 1:36 PM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch to fix the sonarqube code smells having the
> rule "String literals should not be duplicated".
>
> Thanks,
> Khushboo
>


-- 
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Sr. Software Architect*
*EDB Postgres <http://edbpostgres.com>*

*Mobile: +91 976-788-8246*

--000000000000ef1ba705ac0787f8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi=C2=A0Khushboo<div><br></div><div>As per offline discuss=
ion, multiple developers declaring the constant for the same string and err=
or messages. To avoid that only one developer should work on this task.</di=
v><div>Suggestions:</div><div><ul><li>We should have a=C2=A0common=C2=A0cla=
ss for Constants (which are not module specific).</li><li>For module specif=
ic constants we should not declare them as Global variables if possible dec=
lare them as the Class variable.</li><li>For common error messages(if any) =
we can define functions in PGChildNodeView.</li></ul></div><div>Please inco=
rporate the changes send by Yogesh.=C2=A0 =C2=A0</div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Aug 3, 2020 =
at 1:36 PM Khushboo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprisedb=
.com" target=3D"_blank">khushboo.vashi@enterprisedb.com</a>&gt; wrote:<br><=
/div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bo=
rder-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><fo=
nt face=3D"arial, sans-serif" color=3D"#000000" style=3D"background-color:r=
gb(255,255,255)">Hi,</font><div><font face=3D"arial, sans-serif" color=3D"#=
000000" style=3D"background-color:rgb(255,255,255)"><br></font></div><div><=
font face=3D"arial, sans-serif" color=3D"#000000" style=3D"background-color=
:rgb(255,255,255)">Please find the attached patch to fix the sonarqube code=
 smells having the rule &quot;</font>String literals should not be duplicat=
ed<font face=3D"arial, sans-serif" color=3D"#000000" style=3D"background-co=
lor:rgb(255,255,255)">&quot;.</font></div><div><font face=3D"arial, sans-se=
rif" color=3D"#000000" style=3D"background-color:rgb(255,255,255)"><br></fo=
nt></div><div><font face=3D"arial, sans-serif" color=3D"#000000" style=3D"b=
ackground-color:rgb(255,255,255)">Thanks,</font></div><div><font face=3D"ar=
ial, sans-serif" style=3D"background-color:rgb(255,255,255)" color=3D"#0000=
00">Khushboo</font></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Thank=
s &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><spa=
n style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;bor=
der-collapse:collapse">Akshay Joshi</span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">pgAdmin Hacker | Sr. Software Ar=
chitect</span></b></font></div><font color=3D"#000000" face=3D"arial, sans-=
serif"><b><a href=3D"http://edbpostgres.com" target=3D"_blank">EDB Postgres=
</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><span style=3D"co=
lor:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:=
collapse">Mobile: +91 976-788-8246<br></span></b><br></div></div></div></di=
v></div></div></div>

--000000000000ef1ba705ac0787f8--