Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRr4u-0000P9-CH for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Apr 2021 06:45:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lRr4t-0004sM-9G for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Apr 2021 06:45:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRr4t-0004sF-2W for pgadmin-hackers@lists.postgresql.org; Thu, 01 Apr 2021 06:45:15 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRr4p-0002cQ-NU for pgadmin-hackers@postgresql.org; Thu, 01 Apr 2021 06:45:14 +0000 Received: by mail-io1-xd2b.google.com with SMTP id f19so1152989ion.3 for ; Wed, 31 Mar 2021 23:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k8110OVJePuVCEE/Cn2twu1rwv5JwIybJRCymXjDsFI=; b=kzLM5P7+SMX+ayGx2eVkPZu+ImALj4oqHTeJtK/oTXZVEon0AeScTMnDFqDI88/too nqILK+oisKatZPvgiUnjJ1KwVGXJpftIDGOuDIFb+J4V0QyaGNk++gZyp26PeV59G9tu kNm12tRsnJ2txNgkcQslKlXC0+nsS1ekiKLdjrDnlNHDvGCBZBuWbokNx2Lg/VmVG+ip PcYUwQT/36vstAv4GHZvC4OUK4AlXVrtxACzMPF3EZ/r4uymbsQIYbzANerZHKdA2drC df5w1qWOtR+EItv15KHamGYzJWGJ3P1Au7zfaBRRNQwQKCIct/kFQqBloF07URm6JJ3Z fwdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k8110OVJePuVCEE/Cn2twu1rwv5JwIybJRCymXjDsFI=; b=DA7nFakypNb8+AH1jQB6z967Z8v36MOTL8Mu/czBihJl45kDRx2CpvCisaSuw/cpuG 9oRitv9RVK3Se9X0v+5gDvx1fZ/7n3OTwYiLAGwVL0/l6Lqwtgiwc2nny190Y5c8q0k9 HfTGl46zdND/0xT2B4Ww+31xOPHtupJnvnKDqSAB7WjRE5kEd9GBTOsh66sR60ydC7oS nxqwQBXL6U6/27+Wdc5lDG7SwiStUPTiTwfwH68NSHCGgzlB9fRoOktMrvwDmwuFRVo2 tJca6tUrV/M4wIPHeyig+s5hdTs5gqIjs61E9FbJJe+obNw5+jNoK1ThW4jrOBVGSiUJ CzXA== X-Gm-Message-State: AOAM531lJ6iMFK2BxmJrOZYV3+n3oQ7SkpStvIESdoUwGqvtRGARvRXF Xn8lFcuxwewCN7XX9OBHwiQRfQcPc56NiV7DrDP0P12fHx3Xtg/oVvjC1H5dn4eqKDZow+/bHjT 1y5V0KsvxBjr+lzJgKklHi9/nD5lWy2XwVWKu4Jd+AKj/gVOWByjTRKhao/GkNr1P7gQiEjoKmx dNz0CiHfBnJ+Q5XgqpsPrnDTK/QsNneGsloaElILmFzdAJUS6xUtdCnv4xOg== X-Google-Smtp-Source: ABdhPJz+eL0HyXJHj0Ox16eTWRn6s2HRWZlYnjcaXI5K6p7dYN3HrEbNRwLH9gfOQ9dsM7BLepJEPSzsiFh/e7mBi2Y= X-Received: by 2002:a5d:8707:: with SMTP id u7mr5275621iom.18.1617259508238; Wed, 31 Mar 2021 23:45:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 1 Apr 2021 12:14:56 +0530 Message-ID: Subject: Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server. To: Pradip Parkale Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000007fa27705bee39263" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000007fa27705bee39263 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Apr 1, 2021 at 11:40 AM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Hackers, > > Please find the updated patch with the change mentioned by Dave. > > On Wed, Mar 31, 2021 at 7:53 PM Dave Page wrote: > >> Thanks Pradip. >> >> Before this is committed, let's change this: >> >> gettext('Current trasaction is not commited because server is >> disconnected.'), >> >> to: >> >> gettext('The current transaction has been rolled back because the server >> was disconnected.'), >> >> On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> Please find the attached patch for #5519. Updated the existing >>> confirmation message and also added a new confirmation dialog before >>> closing the query tool if the server is disconnected. >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000007fa27705bee39263 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Apr 1, 2021 at 11:40 AM Prad= ip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi Hackers,

Pleas= e find the updated patch with the change mentioned by Dave.

=
On Wed, Ma= r 31, 2021 at 7:53 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks Pradip.

Before this is committed, let= 9;s change this:

gettext('Current trasaction i= s not commited because server is disconnected.'),

to:

gettext('The current transaction h= as been rolled back because the server was disconnected.'),

On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <pradip.parkale@enter= prisedb.com> wrote:
Hi Hackers,
Please find the attached patch = for #5519. Updated the existing confirmation message and also added a new c= onfirmation dialog before closing the query tool if the server is disconnec= ted.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB C= orporation


--


--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000007fa27705bee39263--