Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiF6Q-0000Mj-8D for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:29:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiF6P-0008BO-3x for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:29:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiF6O-00088F-QK for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 09:29:28 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiF6M-0001qF-O3 for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 09:29:28 +0000 Received: by mail-qk1-x732.google.com with SMTP id l128so13364564qke.2 for ; Tue, 02 Jul 2019 02:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sCio5D5Cu1pmbx2JCuGda+pfsd9BGQacvVeSAUMK49c=; b=KVZmHl9O5DfBdQwJUiPG0cDy2/xF6WTW+uyo0jJWpYn9RP2/agcbc/6IVwRe0KsZh+ 0LhAv/P2EG+pw96QlDmxiVAD1m6+YRtUOcyuetrrII8QHj2ydSnAtngZ4PbRhPb8s9lQ NFSg9HFGdd6doGs2EnT2271Qrq5Ey7thtRGDqL5xALmotTVF77h4AapZxdGPtwwd506u L+xozuk3/ZzvrC3AFqi1zC7/XsnXlBybFf8FtcGKOV4EL++AIWXZ23+KBweYOqI1MpLa Xvd/6qllNpPmIcKcjAE25uOo81LhC0Zs16rFXyZgf2vLpcpqtPW1Ii4H35Jotd6P5Vcl OMgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sCio5D5Cu1pmbx2JCuGda+pfsd9BGQacvVeSAUMK49c=; b=Cb1/JomhqubPQ04khN3ZAkfsZUytzWmyoqdcsVCNDRioLoDmPvV8xFE3r9Gye6rqWt Nbt1dWUHMGOUQLzpRrUaBVYQVUncx7ocBvIqoZSR5jQJclj0brQ4XotuM5DeVNgPisNU nY/yePZGyLcTPyre5p9as6bF8wccSxsn4u+1hp5m2sM/ADewMvmu5ZKEXMhQduDyEmU6 5dCTGuI+M3fqS8Ze6HwAWMq9msvChU5Wfb96rAdbbOPm6cEw7fvWfvwN+IaWGxmxD4ry ENwu5dcIK1ZE48w0CAzT4HnY9ZuwvWQRzMSe0h9Qi5U8AMTRVFFqg1C+oNaLqJ6iVLHA a69Q== X-Gm-Message-State: APjAAAVI1veWFbShdrymrhqV3rL+wgUELn6L7LoRpplueWx4wYna9Wt6 Rih1xkbddbNk1Ju29ea+XrIclJQiILDwJLa0mnreBw== X-Google-Smtp-Source: APXvYqxp6bD3NHcXCQ1eTxjEO+JEMcN+BF4whpzmDBBz9UfY6v5isfbtc5iSgWxOfppaj41/FW+hjy5Np4vHZI50gjQ= X-Received: by 2002:ae9:dcc1:: with SMTP id q184mr24121982qkf.61.1562059764823; Tue, 02 Jul 2019 02:29:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 2 Jul 2019 14:59:12 +0530 Message-ID: Subject: Re: [pgAdmin][RM4421] Inno setup script version compare fix To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000668d68058caf6153" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000668d68058caf6153 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Tue, Jul 2, 2019 at 2:51 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. Instead of float comparison, string > comparison is done now with the help of a nice article here - > http://www.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/ > > Kindly review. > > On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> I have asked Paresh to review the patch, he has given some review >> comments. Please fix those and the updated patch asap. >> >> On Tue, Jul 2, 2019 at 1:38 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix a potential issue where version compare >>> while upgrading will be incorrect. Currently, it is comparing strings. So >>> while comparing '4.9' and '4.10' it will consider '4.9' as greater. >>> The patch will convert the values to float and compare. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000668d68058caf6153 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Tue, Jul 2, 2019 at 2:51 PM Aditya= Toshniwal <aditya.= toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the upda= ted patch. Instead of float comparison, string comparison is done now with = the help of a nice article here -=C2=A0http://w= ww.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">
K= indly review.

On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Hi Aditya=C2=A0

I have as= ked Paresh to review the patch, he has given some review comments. Please f= ix those and the updated patch asap.=C2=A0=C2=A0

On Tue, Jul 2, 2019 = at 1:38 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote= :
Hi= Hackers,

Attached is the patch to fix a potential issue where version= compare while upgrading will be incorrect. Currently, it is comparing stri= ngs. So while comparing '4.9' and '4.10' it will consider &= #39;4.9' as greater.
The patch will convert the values to float and com= pare.

Kindly review.

--
Thanks and Regards,
Adit= ya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain ab= out Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
=
Sr. Software Arc= hitect
EnterpriseDB Sof= tware India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000668d68058caf6153--