public inbox for [email protected]  

help / color / mirror / Atom feed

From: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters
Date: Fri, 29 Jun 2018 15:42:27 +0530
Message-ID: <CANxoLDfCm1Y=Z_8Z4uM8FT3eWfvni+kgcQNMfzyRdJfLcQTb6Q@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nZikTmx0JkrDyev3Z8qk26MskoEF2=N1T2-Ji-mK8Q-Q@mail.gmail.com>
References: <CAM9w-_nZikTmx0JkrDyev3Z8qk26MskoEF2=N1T2-Ji-mK8Q-Q@mail.gmail.com>

Hi Aditya

I have applied your patch and run pgAdmin4. I have found following two
issue in the browser:

   - Found error while open Preferences dialog. Refer
   Open_Preferences_Dialog.png
   - Set the preferences setting "Open in new browser tab" to True and open
   the query tool. Refer "Open_In_New_Broswer.png".

I haven't review the code.

On Thu, Jun 28, 2018 at 8:04 PM, Aditya Toshniwal <
[email protected]> wrote:

> Hi Hackers,
>
> Attached is the patch for making preferences realtime and applying without
> reseting the layout. Please note, the patch is only for one module - SQL
> Editor and is the first part for the RM. There are lot of changes to be
> done to cover all and hence sending in parts. This will not affect/break
> existing code. Further patches will cover other modules.
>
> Highlights of this patch include:
> - Changes will affect SQL Editors in Create dialog boxes, SQL tab of the
> main screen, Query tool, History entries in the query tool, Query tool
> opened in New Tab/Window
> - All the components of SQL editor will refer to single source of
> preferences which is cached in the Browser object. All other redundant ajax
> get preference calls are removed.
> - SQL editor will not refer template JS variables anymore, once all the
> references are removed the template variables will also be removed.
> - Code refactoring wherever possible.
> - Covered JS test cases wherever possible.
>
> Request you to kindly review.
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"
>



-- 
*Akshay Joshi*

*Sr. Software Architect *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Attachments:

  [image/png] Open_In_New_Browser.png (95.6K, 3-Open_In_New_Browser.png)
  download | view image

  [image/png] Open_Preferences_Dialog.png (157.4K, 4-Open_Preferences_Dialog.png)
  download | view image

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM3294] User need to reset the layout to see the changed preferences parameters
  In-Reply-To: <CANxoLDfCm1Y=Z_8Z4uM8FT3eWfvni+kgcQNMfzyRdJfLcQTb6Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox